Skip to content

Commit

Permalink
Revert "Lazy load cache and session stores"
Browse files Browse the repository at this point in the history
This reverts commit 19895f0.
  • Loading branch information
dhh committed Jun 13, 2008
1 parent a3caf28 commit 6573f6a
Show file tree
Hide file tree
Showing 5 changed files with 14 additions and 8 deletions.
9 changes: 7 additions & 2 deletions actionpack/lib/action_controller/session_management.rb
@@ -1,3 +1,10 @@
require 'action_controller/session/cookie_store'
require 'action_controller/session/drb_store'
require 'action_controller/session/mem_cache_store'
if Object.const_defined?(:ActiveRecord)
require 'action_controller/session/active_record_store'
end

module ActionController #:nodoc:
module SessionManagement #:nodoc:
def self.included(base)
Expand All @@ -15,8 +22,6 @@ module ClassMethods
# <tt>:p_store</tt>, <tt>:drb_store</tt>, <tt>:mem_cache_store</tt>, or
# <tt>:memory_store</tt>) or your own custom class.
def session_store=(store)
require "action_controller/session/#{store.to_s}" if [:active_record_store, :drb_store, :mem_cache_store].include?(store)

ActionController::CgiRequest::DEFAULT_SESSION_OPTIONS[:database_manager] =
store.is_a?(Symbol) ? CGI::Session.const_get(store == :drb_store ? "DRbStore" : store.to_s.camelize) : store
end
Expand Down
1 change: 0 additions & 1 deletion actionpack/test/controller/caching_test.rb
@@ -1,6 +1,5 @@
require 'fileutils'
require 'abstract_unit'
require "active_support/cache/memory_store"

CACHE_DIR = 'test_cache'
# Don't change '/../temp/' cavalierly or you might hose something you don't want hosed
Expand Down
2 changes: 1 addition & 1 deletion actionpack/test/controller/session/mem_cache_store_test.rb
@@ -1,7 +1,7 @@
require 'abstract_unit'
require 'action_controller/cgi_process'
require 'action_controller/cgi_ext'
require 'action_controller/session/mem_cache_store'


class CGI::Session
def cache
Expand Down
9 changes: 6 additions & 3 deletions activesupport/lib/active_support/cache.rb
Expand Up @@ -7,13 +7,10 @@ def self.lookup_store(*store_option)

case store
when Symbol
require "active_support/cache/#{store.to_s}"

store_class_name = (store == :drb_store ? "DRbStore" : store.to_s.camelize)
store_class = ActiveSupport::Cache.const_get(store_class_name)
store_class.new(*parameters)
when nil
require "active_support/cache/memory_store"
ActiveSupport::Cache::MemoryStore.new
else
store
Expand Down Expand Up @@ -140,3 +137,9 @@ def delete_matched(matcher, options = nil) #:nodoc:
end
end
end

require 'active_support/cache/file_store'
require 'active_support/cache/memory_store'
require 'active_support/cache/drb_store'
require 'active_support/cache/mem_cache_store'
require 'active_support/cache/compressed_mem_cache_store'
1 change: 0 additions & 1 deletion activesupport/lib/active_support/cache/drb_store.rb
@@ -1,5 +1,4 @@
require 'drb'
require 'active_support/cache/memory_store'

module ActiveSupport
module Cache
Expand Down

0 comments on commit 6573f6a

Please sign in to comment.