Commit
…ups before the request
- Loading branch information
There are no files selected for viewing
2 comments
on commit 7259baa
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This has huge effect if you’re using the Thinking Sphinx plugin. TS loads all the models using a to_prepare callback which is then dumped by the call to ActiveSupport::Dependencies.clear. What was the reason for moving cleanup_application into reload_application? Maybe we could move the cleanup stuff before the call to run_callbacks?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lighthouse ticket created:
http://rails.lighthouseapp.com/projects/8994-ruby-on-rails/tickets/1898-clearing-dependencies-in-reload_application-performance-issue
This line is over-escaped.