@@ -28,7 +28,6 @@ module ActionController #:nodoc: base.class_eval do include InstanceMethods alias_method_chain :assign_shortcuts, :flash - alias_method_chain :process_cleanup, :flash alias_method_chain :reset_session, :flash end end @@ -166,11 +165,7 @@ module ActionController #:nodoc: def assign_shortcuts_with_flash(request, response) #:nodoc: assign_shortcuts_without_flash(request, response) flash(:refresh) - end - - def process_cleanup_with_flash - flash.sweep if @_session - process_cleanup_without_flash + flash.sweep if @_session && !component_request? end end end actionpack/lib/action_controller/flash.rb @@ -12,6 +12,11 @@ class TestTest < Test::Unit::TestCase render :text => 'ignore me' end + def set_flash_now + flash.now["test_now"] = ">#{flash["test_now"]}<" + render :text => 'ignore me' + end + def set_session session['string'] = 'A wonder' session[:symbol] = 'it works' @@ -145,6 +150,11 @@ XML assert_equal '>value<', flash['test'] end + def test_process_with_flash_now + process :set_flash_now, nil, nil, { "test_now" => "value_now" } + assert_equal '>value_now<', flash['test_now'] + end + def test_process_with_session process :set_session assert_equal 'A wonder', session['string'], "A value stored in the session should be available by string key" actionpack/test/controller/test_test.rb a7ea06b4ebe252e258f83e7de945b4baa30ec3bc Andreas Neuhaus zargony@zargony.com http://github.com/rails/rails/commit/74eed6290e63111d1aad2b181692a84f4f040aea 74eed6290e63111d1aad2b181692a84f4f040aea 2008-05-10T23:30:10-07:00 2008-05-10T08:54:09-07:00 Fixed flash.now not being accessible in tests. Flash sweeping is now done before action processing instead after Signed-off-by: Michael Koziarski <michael@koziarski.com> [#10 state:resolved] c135f4062dce31d8dabf39753f1a1256f4776d16 Michael Koziarski michael@koziarski.com