Skip to content

Commit

Permalink
Rename Orchestra to Notifications [#3321 state:resolved]
Browse files Browse the repository at this point in the history
  • Loading branch information
josh committed Oct 15, 2009
1 parent bf9819f commit 8cbf825
Show file tree
Hide file tree
Showing 11 changed files with 61 additions and 61 deletions.
20 changes: 10 additions & 10 deletions actionmailer/lib/action_mailer/base.rb
Expand Up @@ -394,7 +394,7 @@ def mailer_name=(value)
def controller_path
self.class.controller_path
end

def formats
@template.formats
end
Expand Down Expand Up @@ -481,7 +481,7 @@ def initialize(method_name=nil, *parameters) #:nodoc:
# Initialize the mailer via the given +method_name+. The body will be
# rendered and a new TMail::Mail object created.
def create!(method_name, *parameters) #:nodoc:
ActiveSupport::Orchestra.instrument(:create_mail, :name => method_name) do
ActiveSupport::Notifications.instrument(:create_mail, :name => method_name) do
initialize_defaults(method_name)
__send__(method_name, *parameters)

Expand Down Expand Up @@ -550,7 +550,7 @@ def deliver!(mail = @mail)
logger.debug "\n#{mail.encoded}"
end

ActiveSupport::Orchestra.instrument(:deliver_mail, :mail => @mail) do
ActiveSupport::Notifications.instrument(:deliver_mail, :mail => @mail) do
begin
__send__("perform_delivery_#{delivery_method}", mail) if perform_deliveries
rescue Exception => e # Net::SMTP errors or sendmail pipe errors
Expand Down Expand Up @@ -583,9 +583,9 @@ def render_template(template, body)
if template.respond_to?(:mime_type)
@current_template_content_type = template.mime_type && template.mime_type.to_sym.to_s
end

@template = initialize_template_class(body)
layout = _pick_layout(layout, true) unless
layout = _pick_layout(layout, true) unless
ActionController::Base.exempt_from_layout.include?(template.handler)
@template._render_template(template, layout, {})
ensure
Expand All @@ -600,16 +600,16 @@ def render_message(method_name, body)

def render(opts)
layout, file = opts.delete(:layout), opts[:file]

begin
@template = initialize_template_class(opts.delete(:body))

if file
prefix = mailer_name unless file =~ /\//
template = view_paths.find(file, {:formats => formats}, prefix)
end

layout = _pick_layout(layout,
layout = _pick_layout(layout,
!template || ActionController::Base.exempt_from_layout.include?(template.handler))

if template
Expand Down Expand Up @@ -648,7 +648,7 @@ def initialize_template_class(assigns)

def sort_parts(parts, order = [])
order = order.collect { |s| s.downcase }

parts = parts.sort do |a, b|
a_ct = a.content_type.downcase
b_ct = b.content_type.downcase
Expand Down Expand Up @@ -689,7 +689,7 @@ def create_mail
headers.each { |k, v| m[k] = v }

real_content_type, ctype_attrs = parse_content_type

if @parts.empty?
m.set_content_type(real_content_type, nil, ctype_attrs)
m.body = normalize_new_lines(body)
Expand Down
2 changes: 1 addition & 1 deletion actionpack/lib/abstract_controller/logger.rb
Expand Up @@ -47,7 +47,7 @@ def method_missing(*args, &block)
# Override process_action in the AbstractController::Base
# to log details about the method.
def process_action(action)
event = ActiveSupport::Orchestra.instrument(:process_action,
event = ActiveSupport::Notifications.instrument(:process_action,
:controller => self, :action => action) do
super
end
Expand Down
8 changes: 4 additions & 4 deletions actionpack/lib/action_controller/caching/fragments.rb
Expand Up @@ -53,7 +53,7 @@ def write_fragment(key, content, options = nil)
return content unless cache_configured?

key = fragment_cache_key(key)
event = ActiveSupport::Orchestra.instrument(:write_fragment, :key => key) do
event = ActiveSupport::Notifications.instrument(:write_fragment, :key => key) do
cache_store.write(key, content, options)
end

Expand All @@ -66,7 +66,7 @@ def read_fragment(key, options = nil)
return unless cache_configured?

key = fragment_cache_key(key)
event = ActiveSupport::Orchestra.instrument(:read_fragment, :key => key) do
event = ActiveSupport::Notifications.instrument(:read_fragment, :key => key) do
cache_store.read(key, options)
end

Expand All @@ -79,7 +79,7 @@ def fragment_exist?(key, options = nil)
return unless cache_configured?

key = fragment_cache_key(key)
event = ActiveSupport::Orchestra.instrument(:fragment_exist?, :key => key) do
event = ActiveSupport::Notifications.instrument(:fragment_exist?, :key => key) do
cache_store.exist?(key, options)
end

Expand Down Expand Up @@ -110,7 +110,7 @@ def expire_fragment(key, options = nil)
key = fragment_cache_key(key) unless key.is_a?(Regexp)
message = nil

event = ActiveSupport::Orchestra.instrument(:expire_fragment, :key => key) do
event = ActiveSupport::Notifications.instrument(:expire_fragment, :key => key) do
if key.is_a?(Regexp)
message = "Expired fragments matching: #{key.source}"
cache_store.delete_matched(key, options)
Expand Down
4 changes: 2 additions & 2 deletions actionpack/lib/action_controller/caching/pages.rb
Expand Up @@ -64,7 +64,7 @@ def expire_page(path)
return unless perform_caching
path = page_cache_path(path)

event = ActiveSupport::Orchestra.instrument(:expire_page, :path => path) do
event = ActiveSupport::Notifications.instrument(:expire_page, :path => path) do
File.delete(path) if File.exist?(path)
end

Expand All @@ -78,7 +78,7 @@ def cache_page(content, path)
return unless perform_caching
path = page_cache_path(path)

event = ActiveSupport::Orchestra.instrument(:cache_page, :path => path) do
event = ActiveSupport::Notifications.instrument(:cache_page, :path => path) do
FileUtils.makedirs(File.dirname(path))
File.open(path, "wb+") { |f| f.write(content) }
end
Expand Down
2 changes: 1 addition & 1 deletion actionpack/lib/action_view/template/template.rb
Expand Up @@ -27,7 +27,7 @@ def initialize(source, identifier, handler, details)
end

def render(view, locals, &block)
ActiveSupport::Orchestra.instrument(:render_template, :identifier => identifier) do
ActiveSupport::Notifications.instrument(:render_template, :identifier => identifier) do
method_name = compile(locals, view)
view.send(method_name, locals, &block)
end.result
Expand Down
4 changes: 2 additions & 2 deletions actionpack/test/controller/caching_test.rb
Expand Up @@ -626,7 +626,7 @@ def test_fragment_for_logging
fragment_computed = false

listener = []
ActiveSupport::Orchestra.register listener
ActiveSupport::Notifications.register listener

buffer = 'generated till now -> '
@controller.fragment_for(buffer, 'expensive') { fragment_computed = true }
Expand All @@ -637,7 +637,7 @@ def test_fragment_for_logging
assert fragment_computed
assert_equal 'generated till now -> ', buffer
ensure
ActiveSupport::Orchestra.unregister listener
ActiveSupport::Notifications.unregister listener
end

end
Expand Down
Expand Up @@ -201,7 +201,7 @@ def log_info(sql, name, ms)

protected
def log(sql, name)
event = ActiveSupport::Orchestra.instrument(:sql, :sql => sql, :name => name) do
event = ActiveSupport::Notifications.instrument(:sql, :sql => sql, :name => name) do
yield if block_given?
end
@runtime += event.duration
Expand Down
2 changes: 1 addition & 1 deletion activesupport/lib/active_support/autoload.rb
Expand Up @@ -18,7 +18,7 @@ module ActiveSupport
autoload :MessageVerifier, 'active_support/message_verifier'
autoload :Multibyte, 'active_support/multibyte'
autoload :OptionMerger, 'active_support/option_merger'
autoload :Orchestra, 'active_support/orchestra'
autoload :Notifications, 'active_support/notifications'
autoload :OrderedHash, 'active_support/ordered_hash'
autoload :OrderedOptions, 'active_support/ordered_options'
autoload :Rescuable, 'active_support/rescuable'
Expand Down
2 changes: 1 addition & 1 deletion activesupport/lib/active_support/cache.rb
Expand Up @@ -247,7 +247,7 @@ def instrument(operation, key, options, &block)
payload = { :key => key }
payload.merge!(options) if options.is_a?(Hash)

event = ActiveSupport::Orchestra.instrument(:"cache_#{operation}", payload, &block)
event = ActiveSupport::Notifications.instrument(:"cache_#{operation}", payload, &block)
log("#{operation} (%.1fms)" % event.duration, key, options)
event.result
end
Expand Down
@@ -1,34 +1,34 @@
require 'thread'

module ActiveSupport
# Orchestra provides an instrumentation API for Ruby. To instrument an action
# Notifications provides an instrumentation API for Ruby. To instrument an action
# in Ruby you just need to:
#
# ActiveSupport::Orchestra.instrument(:render, :extra => :information) do
# ActiveSupport::Notifications.instrument(:render, :extra => :information) do
# render :text => "Foo"
# end
#
# Those actions are consumed by listeners. A listener is anything that responds
# to push. You can even register an array:
#
# @listener = []
# ActiveSupport::Orchestra.register @listener
# ActiveSupport::Notifications.register @listener
#
# ActiveSupport::Orchestra.instrument(:render, :extra => :information) do
# ActiveSupport::Notifications.instrument(:render, :extra => :information) do
# render :text => "Foo"
# end
#
# event #=> ActiveSupport::Orchestra::Event
# event #=> ActiveSupport::Notifications::Event
# event.name #=> :render
# event.duration #=> 10 (in miliseconds)
# event.result #=> "Foo"
# event.payload #=> { :extra => :information }
#
# Orchestra ships with a default listener implementation which puts events in
# Notifications ships with a default listener implementation which puts events in
# a stream and consume them in a Thread. This implementation is thread safe
# and is available at ActiveSupport::Orchestra::Listener.
# and is available at ActiveSupport::Notifications::Listener.
#
module Orchestra
module Notifications
@stacked_events = Hash.new { |h,k| h[k] = [] }
@listeners = []

Expand Down

0 comments on commit 8cbf825

Please sign in to comment.