@@ -10,14 +10,14 @@ module ActiveRecord def create!(attrs = nil) @reflection.klass.transaction do - self << (object = @reflection.klass.send(:with_scope, :create => attrs) { @reflection.klass.create! }) + self << (object = attrs ? @reflection.klass.send(:with_scope, :create => attrs) { @reflection.klass.create! } : @reflection.klass.create!) object end end def create(attrs = nil) @reflection.klass.transaction do - self << (object = @reflection.klass.send(:with_scope, :create => attrs) { @reflection.klass.create }) + self << (object = attrs ? @reflection.klass.send(:with_scope, :create => attrs) { @reflection.klass.create } : @reflection.klass.create) object end end activerecord/lib/active_record/associations/has_many_through_association.rb @@ -115,6 +115,18 @@ class HasManyThroughAssociationsTest < ActiveRecord::TestCase assert posts(:thinking).reload.people(true).collect(&:first_name).include?("Jeb") end + def test_associate_with_create_and_no_options + peeps = posts(:thinking).people.count + posts(:thinking).people.create + assert_equal peeps + 1, posts(:thinking).people.count + end + + def test_associate_with_create_exclaimation_and_no_options + peeps = posts(:thinking).people.count + posts(:thinking).people.create! + assert_equal peeps + 1, posts(:thinking).people.count + end + def test_clear_associations assert_queries(2) { posts(:welcome);posts(:welcome).people(true) } activerecord/test/cases/associations/has_many_through_associations_test.rb c353794dff580c8aa63b357b2857c1fadff3104b Steven Soroka ssoroka78@gmail.com http://github.com/rails/rails/commit/9c20391bbe6ec1c56f8c8ed4aefb31a93576f76a 9c20391bbe6ec1c56f8c8ed4aefb31a93576f76a 2008-05-01T12:22:55-07:00 2008-05-01T12:09:12-07:00 best solution? Signed-off-by: Steven Soroka <ssoroka78@gmail.com> fb66a893a06c0a0f452748d808f10a5d74faf61f David Heinemeier Hansson david@loudthinking.com