public
Description: Ruby on Rails
Homepage: http://rubyonrails.org
Clone URL: git://github.com/rails/rails.git
Base.skip_time_zone_conversion_for_attributes uses class_inheritable_accessor, 
so that subclasses don't overwrite Base [#346 state:resolved]
miloops (author)
Fri Sep 12 07:28:47 -0700 2008
gbuesing (committer)
Sun Sep 14 15:18:17 -0700 2008
commit  9c4730d01e892df8d5c5493a08e0cddf0de5d575
tree    197f3ba0d291def506aa2dc85ba1caff88d31c32
parent  d28c724b4074605445d2834888ad280778f0af6a
...
1
2
 
 
3
4
5
...
1
2
3
4
5
6
7
0
@@ -1,5 +1,7 @@
0
 *Edge*
0
 
0
+* Base.skip_time_zone_conversion_for_attributes uses class_inheritable_accessor, so that subclasses don't overwrite Base [#346 state:resolved] [miloops]
0
+
0
 * Added find_last_by dynamic finder #762 [miloops]
0
 
0
 * Internal API: configurable association options and build_association method for reflections so plugins may extend and override.  #985 [Hongli Lai]
...
10
11
12
13
 
14
15
16
...
10
11
12
 
13
14
15
16
0
@@ -10,7 +10,7 @@ module ActiveRecord
0
       base.attribute_types_cached_by_default = ATTRIBUTE_TYPES_CACHED_BY_DEFAULT
0
       base.cattr_accessor :time_zone_aware_attributes, :instance_writer => false
0
       base.time_zone_aware_attributes = false
0
-      base.cattr_accessor :skip_time_zone_conversion_for_attributes, :instance_writer => false
0
+      base.class_inheritable_accessor :skip_time_zone_conversion_for_attributes, :instance_writer => false
0
       base.skip_time_zone_conversion_for_attributes = []
0
     end
0
 
...
1
2
 
3
4
5
...
219
220
221
 
 
 
 
 
 
 
 
222
223
224
...
1
2
3
4
5
6
...
220
221
222
223
224
225
226
227
228
229
230
231
232
233
0
@@ -1,5 +1,6 @@
0
 require "cases/helper"
0
 require 'models/topic'
0
+require 'models/minimalistic'
0
 
0
 class AttributeMethodsTest < ActiveRecord::TestCase
0
   fixtures :topics
0
@@ -219,6 +220,14 @@ class AttributeMethodsTest < ActiveRecord::TestCase
0
     end
0
   end
0
 
0
+  def test_setting_time_zone_conversion_for_attributes_should_write_value_on_class_variable
0
+    Topic.skip_time_zone_conversion_for_attributes = [:field_a]
0
+    Minimalistic.skip_time_zone_conversion_for_attributes = [:field_b]
0
+    
0
+    assert_equal [:field_a], Topic.skip_time_zone_conversion_for_attributes 
0
+    assert_equal [:field_b], Minimalistic.skip_time_zone_conversion_for_attributes 
0
+  end
0
+
0
   private
0
   def time_related_columns_on_topic
0
     Topic.columns.select{|c| [:time, :date, :datetime, :timestamp].include?(c.type)}.map(&:name)

Comments