Navigation Menu

Skip to content

Commit

Permalink
Revert "fallback_string_to_date sets Date._parse comp arg to true, so…
Browse files Browse the repository at this point in the history
… that strings with two-digit years, e.g. '1/1/09', are interpreted as modern years" [#2019 state:wontfix]

This reverts commit 55d1d12.
  • Loading branch information
gbuesing committed Aug 5, 2009
1 parent f8d3c72 commit bfafe8c
Show file tree
Hide file tree
Showing 3 changed files with 1 addition and 9 deletions.
2 changes: 0 additions & 2 deletions activerecord/CHANGELOG
@@ -1,7 +1,5 @@
*Edge*

* fallback_string_to_date sets Date._parse comp arg to true, so that strings with two-digit years, e.g. '1/1/09', are interpreted as modern years #2019 [Matt Ganderup]

* quoted_date converts time-like objects to ActiveRecord::Base.default_timezone before serialization. This allows you to use Time.now in find conditions and have it correctly be serialized as the current time in UTC when default_timezone == :utc. #2946 [Geoff Buesing]

* SQLite: drop support for 'dbfile' option in favor of 'database.' #2363 [Paul Hinze, Jeremy Kemper]
Expand Down
Expand Up @@ -201,7 +201,7 @@ def fast_string_to_time(string)
end

def fallback_string_to_date(string)
new_date(*::Date._parse(string, true).values_at(:year, :mon, :mday))
new_date(*::Date._parse(string, false).values_at(:year, :mon, :mday))
end

def fallback_string_to_time(string)
Expand Down
6 changes: 0 additions & 6 deletions activerecord/test/cases/date_time_test.rb
Expand Up @@ -34,10 +34,4 @@ def test_assign_empty_time
topic.bonus_time = ''
assert_nil topic.bonus_time
end

def test_two_digit_year
topic = Topic.new
topic.last_read = '1/1/09'
assert_equal Date.new(2009,1,1), topic.last_read
end
end

0 comments on commit bfafe8c

Please sign in to comment.