@@ -120,6 +120,13 @@ module ActiveSupport dup.merge!(other_hash) end + # When replacing with another hash, the initial order of our keys must come from the other hash -ordered or not. + def replace(other) + super + @keys = other.keys + self + end + def inspect "#<OrderedHash #{super}>" end activesupport/lib/active_support/ordered_hash.rb @@ -191,4 +191,11 @@ class OrderedHashTest < Test::Unit::TestCase assert_equal "odd number of arguments for Hash", $!.message end end + + def test_replace_updates_keys + @other_ordered_hash = ActiveSupport::OrderedHash[:black, '000000', :white, '000000'] + original = @ordered_hash.replace(@other_ordered_hash) + assert_same original, @ordered_hash + assert_equal @other_ordered_hash.keys, @ordered_hash.keys + end end activesupport/test/ordered_hash_test.rb 4ae03b2d5a7b81a8b8d330c12de40f970525a67a Chris Hapgood cch1@hapgoods.com http://github.com/rails/rails/commit/c3ef028b818779996472e018486446a216657251 c3ef028b818779996472e018486446a216657251 2009-11-05T00:16:06-08:00 2009-11-04T07:13:59-08:00 Fix OrderedHash#replace Signed-off-by: Michael Koziarski <michael@koziarski.com> e48654d29cde5306ccac4ba5f10d3ae25b59d0ad Michael Koziarski michael@koziarski.com