Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Check for uninitialized instance variables
- Loading branch information
Showing
4 changed files
with
24 additions
and
20 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dc0411f
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I’m updating to Rails 2.2 and I got a lot of deprecation messages like:
DEPRECATION WARNING: @change will no longer be implicitly assigned to change.
This deprecation check seems to be a little overzealous. If I set an ivar @change in the action and then pass it to a partial with:
:locals => { :change => @change }
then I get this deprecation message even if I use change and not @change in the partial. I wasn’t taking advantage of an implicit assignment. If I don’t use @change in the partial because I only use the local change, should I still get this deprecation message?
dc0411f
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you open a ticket in lighthouse and then email the core list about this?
It’s entirely possible that this warning is a little over-eager and would be good to catch it.