@@ -402,6 +402,7 @@ module ActionController if rjs_type if rjs_type == :insert position = args.shift + id = args.shift insertion = "insert_#{position}".to_sym raise ArgumentError, "Unknown RJS insertion type #{position}" unless RJS_STATEMENTS[insertion] statement = "(#{RJS_STATEMENTS[insertion]})" actionpack/lib/action_controller/assertions/selector_assertions.rb @@ -248,6 +248,14 @@ class AssertSelectTest < ActionController::TestCase end end + def test_assert_select_rjs_for_positioned_insert_should_fail_when_mixing_arguments + render_rjs do |page| + page.insert_html :top, "test1", "<div id=\"1\">foo</div>" + page.insert_html :bottom, "test2", "<div id=\"2\">foo</div>" + end + assert_raises(Assertion) {assert_select_rjs :insert, :top, "test2"} + end + # # Test css_select. # actionpack/test/controller/assert_select_test.rb d7b6e48c70076a7760e22c381e48834ecddfa6e3 Frederick Cheung frederick.cheung@gmail.com http://github.com/rails/rails/commit/dce0da77e7ef602f7420f43c0d1aba5a99a00bdb dce0da77e7ef602f7420f43c0d1aba5a99a00bdb 2008-12-26T10:25:32-08:00 2008-12-25T03:11:00-08:00 Fix assert_select_rjs not checking id for inserts [#540 state:resolved] d917bf9cd17da1575ea6ad3c97c8311ddc3ad2a6 Frederick Cheung frederick.cheung@gmail.com