Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Add constraints to resources in new routing DSL
Signed-off-by: Rizwan Reza <rizwanreza@gmail.com>
- Loading branch information
1 parent
5c05829
commit e1a70fa
Showing
2 changed files
with
73 additions
and
14 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e1a70fa
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This commit has no rdoc?
e1a70fa
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't add any documentation since constraints are already documented, however looking at the documentation in ActionDispatch::Routing I can see there's no documentation at all on resources so we certainly do with some documentation on resource routing in the new DSL. Currently there's no rdoc attached to any of the new routing methods so should the resource docs go with the rest of the docs in ActionDispatch::Routing or is the intention to add docs to each of the methods? Also I'm guessing that any doc commits should go to docrails?
e1a70fa
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah some more docs would be good indeed. Would you like to contribute them? If so please just write them and ping me, I'll apply.
Regarding docrails, the idea is that a patch should always have proper test and rdoc coverage to be accepted. The docrails branch is only a shortcut to fix docs bypassing LH (and it does guides as well). But rdoc is still something contributed together with code and tests.