This repository is private.
All pages are served over SSL and all pushing and pulling is done over SSH.
No one may fork, clone, or view it unless they are added as a member.
Every repository with this icon (
) is private.
Every repository with this icon (
This repository is public.
Anyone may fork, clone, or view it.
Every repository with this icon (
) is public.
Every repository with this icon (
commit ef9b6b5cba08f13dcbf7095226b78aaf22df13f7
tree d9b332eba71925ceb524fbf638369bafe19d8786
parent 2c7abe1b5682d287b19dde5900087908c976109c
tree d9b332eba71925ceb524fbf638369bafe19d8786
parent 2c7abe1b5682d287b19dde5900087908c976109c
... |
... |
|
... |
... |
|












Thank you very much! This is really useful ;)
I may be being dense here but shouldn’t this be CGI.unescapeHTML otherwise we’re double escaping the generated url and it stands no chance of being equal to the request uri if there’s an ampersand in the url.
@pixeltrix: That code has been there a while, it’s not new with this changeset.
But anyway, the query-string is ignored now, so it shouldn’t matter right?
The source of it is:
http://github.com/rails/rails/commit/3dc7f7603785c1173df5c24f8b76323f7a795443
I think it’s been broken for a while. :-)
The query string is only ignored if the url being checked doesn’t have a query string of its own, so it fails it two circumstances – once when passing in a hash where the current request has multiple params and also when passing in explicit urls with multiple params.
I’ve created a ticket with a patch at:
http://rails.lighthouseapp.com/projects/8994-ruby-on-rails/tickets/1385-fix-current_page-to-work-with-multiple-parameters-in-the-query-string