@@ -1155,7 +1155,7 @@ module ActionController #:nodoc: def log_processing if logger && logger.info? - logger.info "\n\nProcessing #{controller_class_name}\##{action_name} (for #{request_origin}) [#{request.method.to_s.upcase}]" + logger.info "\n\nProcessing #{self.class.name}\##{action_name} (for #{request_origin}) [#{request.method.to_s.upcase}]" logger.info " Session ID: #{@_session.session_id}" if @_session and @_session.respond_to?(:session_id) logger.info " Parameters: #{respond_to?(:filter_parameters) ? filter_parameters(params).inspect : params.inspect}" end actionpack/lib/action_controller/base.rb @@ -7,6 +7,7 @@ module Submodule end class ContainedNonEmptyController < ActionController::Base def public_action + render :nothing => true end hide_action :hidden_action @@ -105,6 +106,18 @@ end class PerformActionTest < Test::Unit::TestCase + class MockLogger + attr_reader :logged + + def initialize + @logged = [] + end + + def method_missing(method, *args) + @logged << args.first + end + end + def use_controller(controller_class) @controller = controller_class.new @@ -142,6 +155,13 @@ class PerformActionTest < Test::Unit::TestCase get :another_hidden_action assert_response 404 end + + def test_namespaced_action_should_log_module_name + use_controller Submodule::ContainedNonEmptyController + @controller.logger = MockLogger.new + get :public_action + assert_match /Processing\sSubmodule::ContainedNonEmptyController#public_action/, @controller.logger.logged[1] + end end class DefaultUrlOptionsTest < Test::Unit::TestCase actionpack/test/controller/base_test.rb 396f9df8916b71f83aad8d56559cf55fc8501679 Ripta Pasay ripta@hogan.home.r8y.org http://github.com/rails/rails/commit/f7fdbae770275ccbc277c42287b9783cb00fa9fa f7fdbae770275ccbc277c42287b9783cb00fa9fa 2008-07-16T17:33:44-07:00 2008-07-12T15:54:24-07:00 Use fully-qualified controller name when logging. [#600 state:resolved] Signed-off-by: Pratik Naik <pratiknaik@gmail.com> e24232610d6261421a7a1f9e353c817f1f5b7b30 Pratik Naik pratiknaik@gmail.com