Move background jobs to the 'jobs' branch until fully baked. Not ship…

…ping with Rails 4.0.
rails · Dec 22, 2012 · f9da785 · f9da785 · Aupajo · Dec 22, 2012
1 parent 10c0a3b
commit f9da785
Show file tree

Hide file tree

Showing 25 changed files with 4 additions and 724 deletions.
diff --git a/actionmailer/CHANGELOG.md b/actionmailer/CHANGELOG.md
@@ -28,8 +28,6 @@
 
 *   Raise an `ActionView::MissingTemplate` exception when no implicit template could be found. *Damien Mathieu*
 
-*   Asynchronously send messages via the Rails Queue *Brian Cardarella*
-
 *   Allow callbacks to be defined in mailers similar to `ActionController::Base`. You can configure default
     settings, headers, attachments, delivery settings or change delivery using
     `before_filter`, `after_filter` etc. *Justin S. Leitgeb*

diff --git a/actionmailer/lib/action_mailer.rb b/actionmailer/lib/action_mailer.rb
@@ -44,5 +44,4 @@ module ActionMailer
   autoload :MailHelper
   autoload :TestCase
   autoload :TestHelper
-  autoload :QueuedMessage
 end
diff --git a/actionmailer/lib/action_mailer/base.rb b/actionmailer/lib/action_mailer/base.rb
@@ -1,10 +1,8 @@
 require 'mail'
-require 'action_mailer/queued_message'
 require 'action_mailer/collector'
 require 'active_support/core_ext/string/inflections'
 require 'active_support/core_ext/hash/except'
 require 'active_support/core_ext/module/anonymous'
-require 'active_support/queueing'
 require 'action_mailer/log_subscriber'
 
 module ActionMailer
@@ -361,8 +359,6 @@ module ActionMailer
   #
   # * <tt>deliveries</tt> - Keeps an array of all the emails sent out through the Action Mailer with
   #   <tt>delivery_method :test</tt>. Most useful for unit and functional testing.
-  #
-  # * <tt>queue</> - The queue that will be used to deliver the mail. The queue should expect a job that responds to <tt>run</tt>.
   class Base < AbstractController::Base
     include DeliveryMethods
     abstract!
@@ -389,9 +385,6 @@ class Base < AbstractController::Base
       parts_order:  [ "text/plain", "text/enriched", "text/html" ]
     }.freeze
 
-    class_attribute :queue
-    self.queue = ActiveSupport::SynchronousQueue.new
-
     class << self
       # Register one or more Observers which will be notified when mail is delivered.
       def register_observers(*observers)
@@ -483,8 +476,8 @@ def set_payload_for_mail(payload, mail) #:nodoc:
       end
 
       def method_missing(method_name, *args)
-        if action_methods.include?(method_name.to_s)
-          QueuedMessage.new(queue, self, method_name, *args)
+        if respond_to?(method_name)
+          new(method_name, *args).message
         else
           super
         end

diff --git a/actionmailer/lib/action_mailer/queued_message.rb b/actionmailer/lib/action_mailer/queued_message.rb
diff --git a/actionmailer/lib/action_mailer/railtie.rb b/actionmailer/lib/action_mailer/railtie.rb
@@ -19,8 +19,6 @@ class Railtie < Rails::Railtie # :nodoc:
       options.javascripts_dir ||= paths["public/javascripts"].first
       options.stylesheets_dir ||= paths["public/stylesheets"].first
 
-      options.queue ||= app.queue
-
       # make sure readers methods get compiled
       options.asset_host          ||= app.config.asset_host
       options.relative_url_root   ||= app.config.relative_url_root

diff --git a/actionmailer/test/abstract_unit.rb b/actionmailer/test/abstract_unit.rb
@@ -11,7 +11,6 @@
 require 'minitest/autorun'
 require 'action_mailer'
 require 'action_mailer/test_case'
-require 'active_support/queueing'
 
 silence_warnings do
   # These external dependencies have warnings :/

diff --git a/actionmailer/test/base_test.rb b/actionmailer/test/base_test.rb
@@ -3,13 +3,11 @@
 require 'set'
 
 require 'action_dispatch'
-require 'active_support/queueing'
 require 'active_support/time'
 
 require 'mailers/base_mailer'
 require 'mailers/proc_mailer'
 require 'mailers/asset_mailer'
-require 'mailers/async_mailer'
 
 class BaseTest < ActiveSupport::TestCase
   def teardown
@@ -422,17 +420,6 @@ def teardown
     assert_equal(1, BaseMailer.deliveries.length)
   end
 
-  test "delivering message asynchronously" do
-    AsyncMailer.delivery_method = :test
-    AsyncMailer.deliveries.clear
-
-    AsyncMailer.welcome.deliver
-    assert_equal 0, AsyncMailer.deliveries.length
-
-    AsyncMailer.queue.drain
-    assert_equal 1, AsyncMailer.deliveries.length
-  end
-
   test "calling deliver, ActionMailer should yield back to mail to let it call :do_delivery on itself" do
     mail = Mail::Message.new
     mail.expects(:do_delivery).once

diff --git a/actionmailer/test/mailers/async_mailer.rb b/actionmailer/test/mailers/async_mailer.rb
diff --git a/actionpack/test/controller/assert_select_test.rb b/actionpack/test/controller/assert_select_test.rb
@@ -10,16 +10,6 @@
 require 'action_mailer'
 ActionMailer::Base.view_paths = FIXTURE_LOAD_PATH
 
-class SynchronousQueue < Queue
-  def push(job)
-    job.run
-  end
-  alias <<  push
-  alias enq push
-end
-
-ActionMailer::Base.queue = SynchronousQueue.new
-
 class AssertSelectTest < ActionController::TestCase
   Assertion = ActiveSupport::TestCase::Assertion
 

diff --git a/activesupport/lib/active_support/queueing.rb b/activesupport/lib/active_support/queueing.rb
diff --git a/activesupport/test/queueing/synchronous_queue_test.rb b/activesupport/test/queueing/synchronous_queue_test.rb