3a2ff17af66dfb135ead212de458e7f6860c8004 Miles Georgi azimux@gmail.com http://github.com/rails/rails/commit/09343166ac213e5fcbd3eb5b21d44606b56afa62 09343166ac213e5fcbd3eb5b21d44606b56afa62 2008-08-20T13:25:49-07:00 2008-08-17T23:45:25-07:00 PostgreSQL: fix transaction bug that can occur if you call change_column with invalid parameters [#861 state:resolved] 5bb8d124d41807a2dda272a08a62c98b47b0dd4d Jeremy Kemper jeremy@bitsweat.net 6f530de9443a4e2ab3d193624ff6ecd3c2b06de2 Joshua Peek josh@joshpeek.com http://github.com/rails/rails/commit/3a2ff17af66dfb135ead212de458e7f6860c8004 3a2ff17af66dfb135ead212de458e7f6860c8004 2008-08-19T18:24:34-07:00 2008-08-19T18:22:27-07:00 Don't shadow query string method 58f3a8b8e5079737d1f8a7c0441f52485a615d9e Joshua Peek josh@joshpeek.com 5de340e79f1d11973b7c7bbec82f320fc92b9c99 Joshua Peek josh@joshpeek.com http://github.com/rails/rails/commit/6f530de9443a4e2ab3d193624ff6ecd3c2b06de2 6f530de9443a4e2ab3d193624ff6ecd3c2b06de2 2008-08-19T18:15:51-07:00 2008-08-19T18:15:51-07:00 Test coverage for integration testing with parameters db67146ae2a6d1117b25d3ba57c8e08fbf83fb83 Joshua Peek josh@joshpeek.com a8ece12fe2ac7838407954453e0d31af6186a5db Joshua Peek josh@joshpeek.com http://github.com/rails/rails/commit/5de340e79f1d11973b7c7bbec82f320fc92b9c99 5de340e79f1d11973b7c7bbec82f320fc92b9c99 2008-08-19T17:20:10-07:00 2008-08-19T17:20:10-07:00 Ensure objects cached with MemoryStore are immutable 71673fecc53a7904629424522feafaaca933f2c2 Joshua Peek josh@joshpeek.com 71c4ff07ab4313c1f4781d59ad2f4528f5875665 Ryan Bates ryan@railscasts.com http://github.com/rails/rails/commit/a8ece12fe2ac7838407954453e0d31af6186a5db a8ece12fe2ac7838407954453e0d31af6186a5db 2008-08-19T17:09:04-07:00 2008-08-19T17:09:04-07:00 Return nil instead of a space when passing an empty collection or nil to 'render :partial' [#791 state:resolved] Signed-off-by: Joshua Peek <josh@joshpeek.com> 5a6cb0a957bebc1da95c1918563db10447cacd26 Joshua Peek josh@joshpeek.com 5df8ff1d6b6c35a7b5924f95ad12693984323513 Joshua Peek josh@joshpeek.com http://github.com/rails/rails/commit/71c4ff07ab4313c1f4781d59ad2f4528f5875665 71c4ff07ab4313c1f4781d59ad2f4528f5875665 2008-08-19T16:53:46-07:00 2008-08-19T16:53:46-07:00 Delegate xhr helper method to integration session e67348ef53061f3bf4402d73e91718f58a25a2a1 Joshua Peek josh@joshpeek.com 6e4ea66dc0d41ef611e2b2187e940321f5dc748a Joshua Peek josh@joshpeek.com http://github.com/rails/rails/commit/5df8ff1d6b6c35a7b5924f95ad12693984323513 5df8ff1d6b6c35a7b5924f95ad12693984323513 2008-08-19T15:16:35-07:00 2008-08-19T15:14:17-07:00 Touch file with git revision when freezing edge 2da15b6facbcce3b8e580a13fdaab9068a19e070 Joshua Peek josh@joshpeek.com bd7edcf286421b090b8de5674422a7316ed043a9 Jamis Buck jamis@37signals.com http://github.com/rails/rails/commit/6e4ea66dc0d41ef611e2b2187e940321f5dc748a 6e4ea66dc0d41ef611e2b2187e940321f5dc748a 2008-08-19T15:07:17-07:00 2008-08-19T15:07:17-07:00 Make AbstractRequest.if_modified_sense return nil if the header could not be parsed e84e78c3b35c34876e6e83adfcffe9c32caa0db5 Jamis Buck jamis@37signals.com 977317da55b6ba9bbb1326392516480902145c5b Joshua Peek josh@joshpeek.com http://github.com/rails/rails/commit/bd7edcf286421b090b8de5674422a7316ed043a9 bd7edcf286421b090b8de5674422a7316ed043a9 2008-08-19T14:46:15-07:00 2008-08-19T14:46:15-07:00 Removed config.ru template from app generator 85da52684756d93e7aba2c7d3135ed4d1a8162bc Joshua Peek josh@joshpeek.com e9ae2b2f4cae3e9ba4fc8ce91de951d18879af8b Joshua Peek josh@joshpeek.com http://github.com/rails/rails/commit/977317da55b6ba9bbb1326392516480902145c5b 977317da55b6ba9bbb1326392516480902145c5b 2008-08-19T14:29:02-07:00 2008-08-19T14:29:02-07:00 hack around CGI session close 1583c217c4d91822d476da91532bb0190140aa8e Joshua Peek josh@joshpeek.com 96ab01e8f2b5a4475453acf60f9cf9bd8cd98483 Joshua Peek josh@joshpeek.com http://github.com/rails/rails/commit/e9ae2b2f4cae3e9ba4fc8ce91de951d18879af8b e9ae2b2f4cae3e9ba4fc8ce91de951d18879af8b 2008-08-18T22:18:26-07:00 2008-08-18T22:18:26-07:00 Added rack logger middleware that tails the environment log 527dd06fed61304471719a0319280143f0aa1620 Joshua Peek josh@joshpeek.com c1a8690d582c08777055caf449c03f85b4c8aa4b Joshua Peek josh@joshpeek.com http://github.com/rails/rails/commit/96ab01e8f2b5a4475453acf60f9cf9bd8cd98483 96ab01e8f2b5a4475453acf60f9cf9bd8cd98483 2008-08-18T21:36:13-07:00 2008-08-18T21:33:46-07:00 Maintain a seperate buffer for each thread 6bf2233365025492b6ec20bd74dd95f287fe3c5e Joshua Peek josh@joshpeek.com a4da8175a2c989104de1a38e43d5ddfb0f89b055 Joshua Peek josh@joshpeek.com http://github.com/rails/rails/commit/c1a8690d582c08777055caf449c03f85b4c8aa4b c1a8690d582c08777055caf449c03f85b4c8aa4b 2008-08-18T21:36:13-07:00 2008-08-18T20:38:58-07:00 Consistently use the framework's configured logger and avoid reverting to RAILS_DEFAULT_LOGGER unless necessary. aa88127d58845658f32fb9284b0f837f13700800 Joshua Peek josh@joshpeek.com cd8e653d5b18e6d3c3acc9930832f8e23945e392 Joshua Peek josh@joshpeek.com http://github.com/rails/rails/commit/a4da8175a2c989104de1a38e43d5ddfb0f89b055 a4da8175a2c989104de1a38e43d5ddfb0f89b055 2008-08-18T18:17:08-07:00 2008-08-18T18:14:56-07:00 Replace MemoryStore mutex with a monitor to avoid issues with nested calls 5446ffe7473aaf8f2275e792a3237df4d011ada6 Joshua Peek josh@joshpeek.com 7fbe226de5c63565fcca67d01687d83009ab9886 Jeremy Kemper jeremy@bitsweat.net http://github.com/rails/rails/commit/cd8e653d5b18e6d3c3acc9930832f8e23945e392 cd8e653d5b18e6d3c3acc9930832f8e23945e392 2008-08-18T17:34:38-07:00 2008-08-11T10:25:57-07:00 Performance: freeze cached rows instead of duping 6a0063580c0563ecace2216a45189c11065fe5bf Jeremy Kemper jeremy@bitsweat.net 38c7d73e73d569211c4dfadf96fc295a925b7c9c Jeremy Kemper jeremy@bitsweat.net http://github.com/rails/rails/commit/7fbe226de5c63565fcca67d01687d83009ab9886 7fbe226de5c63565fcca67d01687d83009ab9886 2008-08-18T16:41:08-07:00 2008-08-07T01:22:03-07:00 Ruby 1.9 and GC::Profiler updates b81c2ba051a68ca2e0ece219ce9ce08d012cf8e6 Jeremy Kemper jeremy@bitsweat.net dbb0abfb7e9eb9a63b721a38625e3eff66ced49d Ryan Bates ryan@railscasts.com http://github.com/rails/rails/commit/38c7d73e73d569211c4dfadf96fc295a925b7c9c 38c7d73e73d569211c4dfadf96fc295a925b7c9c 2008-08-17T17:29:24-07:00 2008-08-17T17:29:24-07:00 pass yielded arguments to block for ActionView::Base#render with :layout [#847 state:resolved] Signed-off-by: Joshua Peek <josh@joshpeek.com> 9400fbbd277dafdde822fb9d3968f30764dbe9da Joshua Peek josh@joshpeek.com f245658495865eff0882589b3e159704e48e1820 Joshua Peek josh@joshpeek.com http://github.com/rails/rails/commit/dbb0abfb7e9eb9a63b721a38625e3eff66ced49d dbb0abfb7e9eb9a63b721a38625e3eff66ced49d 2008-08-17T17:18:18-07:00 2008-08-17T17:18:18-07:00 More integration test coverage 179f6711e39ce5d7b3feb9facb93be95603df46c Joshua Peek josh@joshpeek.com b8e930aa016e26471046d3f7d7ca1c10103791e7 Joshua Peek josh@joshpeek.com http://github.com/rails/rails/commit/f245658495865eff0882589b3e159704e48e1820 f245658495865eff0882589b3e159704e48e1820 2008-08-17T17:13:49-07:00 2008-08-17T17:13:49-07:00 Use Response status accessor instead of the Status header be998ca2cea639b7e8b9018ecbdbda54dff2e4ea Joshua Peek josh@joshpeek.com 894f9ccc5354c29e102f316f388d1dc0b98ef080 Joshua Peek josh@joshpeek.com http://github.com/rails/rails/commit/b8e930aa016e26471046d3f7d7ca1c10103791e7 b8e930aa016e26471046d3f7d7ca1c10103791e7 2008-08-17T17:09:38-07:00 2008-08-17T17:09:38-07:00 Merge RackProcess#normalize_headers logic into AbstractResponse#prepare! 65733f05f69fa0b8648b8c473e34fdf5e8d16c2d Joshua Peek josh@joshpeek.com 96607996eaa826b5299780c7c9142e6e0157d198 Joshua Peek josh@joshpeek.com http://github.com/rails/rails/commit/894f9ccc5354c29e102f316f388d1dc0b98ef080 894f9ccc5354c29e102f316f388d1dc0b98ef080 2008-08-17T17:04:01-07:00 2008-08-17T17:04:01-07:00 Use RackRequest as a mock instead of StubCGI into RequestTest 23b13a97e49738a2eaa275aa3d1d3e5877e494a6 Joshua Peek josh@joshpeek.com 8cfdcdb35db6e2f6fd5a72a38f4352beab148af1 Tarmo Tänav tarmo@itech.ee http://github.com/rails/rails/commit/96607996eaa826b5299780c7c9142e6e0157d198 96607996eaa826b5299780c7c9142e6e0157d198 2008-08-16T14:26:11-07:00 2008-08-16T14:20:55-07:00 Test for eager loading of STI subclasses from htm associations Signed-off-by: Pratik Naik <pratiknaik@gmail.com> bfe3d0a54a0d688c9d9df9c4b78040730b330e93 Pratik Naik pratiknaik@gmail.com 2b69a636c431d62a85b2896d87b69cb13e2b8af0 Nathan Witmer nwitmer@gmail.com http://github.com/rails/rails/commit/8cfdcdb35db6e2f6fd5a72a38f4352beab148af1 8cfdcdb35db6e2f6fd5a72a38f4352beab148af1 2008-08-16T14:23:48-07:00 2008-08-16T12:38:01-07:00 Updated has_and_belongs_to_many association to fix :finder_sql interpolation. [#848 state:resolved] Signed-off-by: Pratik Naik <pratiknaik@gmail.com> 73ee2a1467cfa181807625b7bba10e3bec15b27b Pratik Naik pratiknaik@gmail.com 8f4d3957a6986fe450cfd9058bb92ae1d6e5e745 Tarmo Tänav tarmo@itech.ee http://github.com/rails/rails/commit/2b69a636c431d62a85b2896d87b69cb13e2b8af0 2b69a636c431d62a85b2896d87b69cb13e2b8af0 2008-08-16T12:41:19-07:00 2008-08-15T16:24:29-07:00 Fixed STI type condition for eager loading of associations Signed-off-by: Pratik Naik <pratiknaik@gmail.com> 56490c5c00af972feaa9e80432303d124ecc6150 Pratik Naik pratiknaik@gmail.com b3c9d53b348f586ed223ec5de9f525faee6f564d Ryan Bates ryan@railscasts.com http://github.com/rails/rails/commit/8f4d3957a6986fe450cfd9058bb92ae1d6e5e745 8f4d3957a6986fe450cfd9058bb92ae1d6e5e745 2008-08-16T12:21:36-07:00 2008-08-15T13:51:57-07:00 Don't raise exception when comparing ActiveRecord::Reflection. [#842 state:resolved] Signed-off-by: Pratik Naik <pratiknaik@gmail.com> 1b7833a2d0594835f44646bc4ebc7e70a2cc219b Pratik Naik pratiknaik@gmail.com e3523f1d33c3cf53f1a65e520be5e937e9c68c1d Tarmo Tänav tarmo@itech.ee http://github.com/rails/rails/commit/b3c9d53b348f586ed223ec5de9f525faee6f564d b3c9d53b348f586ed223ec5de9f525faee6f564d 2008-08-15T15:57:33-07:00 2008-06-02T06:48:06-07:00 Use type_condition method for hmt STI condition 5f663b37aa9088b8315051aaa863e5818eb8b4bf Jeremy Kemper jeremy@bitsweat.net aad7cac6add2fa01cebbb36e9f546292d632c9ea Tarmo Tänav tarmo@itech.ee http://github.com/rails/rails/commit/e3523f1d33c3cf53f1a65e520be5e937e9c68c1d e3523f1d33c3cf53f1a65e520be5e937e9c68c1d 2008-08-15T15:44:11-07:00 2008-08-15T08:39:11-07:00 Fixed validates_uniqueness_of with decimal columns Only use special case-sensitive comparison operators for text columns in validates_uniqueness_of as mysql can fail at decimal comparisons with the BINARY operator. 4133486e17e4cafb88225bf86a8a1ee9efaf9730 Jeremy Kemper jeremy@bitsweat.net 8aad8cb3906fce40fa583839fec7f8591fab8ec7 David Heinemeier Hansson david@loudthinking.com http://github.com/rails/rails/commit/aad7cac6add2fa01cebbb36e9f546292d632c9ea aad7cac6add2fa01cebbb36e9f546292d632c9ea 2008-08-15T07:27:07-07:00 2008-08-15T07:27:07-07:00 Fixed problems with the logger used if the logging string included %'s [#840 state:resolved] (Jamis Buck) b4afc215d41692ec7dbe1766905d8c8fea451080 David Heinemeier Hansson david@loudthinking.com f1f4e84a7ef88d941f6508673bb448de640d6f77 Jeremy Kemper jeremy@bitsweat.net http://github.com/rails/rails/commit/8aad8cb3906fce40fa583839fec7f8591fab8ec7 8aad8cb3906fce40fa583839fec7f8591fab8ec7 2008-08-14T21:45:14-07:00 2008-08-14T21:45:14-07:00 Set cache control to require revalidation if cache freshness response headers are set. Don't set Content-Length header if 304 status. e6b903348c95ed060ddac963209065304fabd336 Jeremy Kemper jeremy@bitsweat.net 8cb14ee1203c9ed380c4b192e8730757a52d43cb Jeremy Kemper jeremy@bitsweat.net http://github.com/rails/rails/commit/f1f4e84a7ef88d941f6508673bb448de640d6f77 f1f4e84a7ef88d941f6508673bb448de640d6f77 2008-08-14T12:28:02-07:00 2008-08-14T12:23:29-07:00 Fix asset file paths with dangling queries in mtime check 26549476ba44de26fbad378f69680d83ed451ae5 Jeremy Kemper jeremy@bitsweat.net