28393e6e9c9368036e65e77175ea4f65a862259c Will Bryant will.bryant@gmail.com http://github.com/rails/rails/commit/4c05055487e149bfa4152c1b42f3519671ca22ac 4c05055487e149bfa4152c1b42f3519671ca22ac 2008-10-10T07:58:39-07:00 2008-09-26T20:28:21-07:00 explicitly including child associations that are also included in the parent association definition should not result in double records in the collection/double loads (#1110) Signed-off-by: Michael Koziarski <michael@koziarski.com> [#1110 state:committed] e48d836fa25a2c06544b792f4d72c0f7051be9ee Michael Koziarski michael@koziarski.com aa4a7c35309ff95ef1165844d637f7e583ac20dd Hongli Lai (Phusion) hongli@phusion.nl http://github.com/rails/rails/commit/28393e6e9c9368036e65e77175ea4f65a862259c 28393e6e9c9368036e65e77175ea4f65a862259c 2008-10-09T09:11:10-07:00 2008-09-18T04:27:39-07:00 Add documentation for AbstractAdapter#sanitize_limit, and make its code more readable. Signed-off-by: Michael Koziarski <michael@koziarski.com> [#1068 status:committed] d264f4c1d3f995e52bdbfc3ddb0a76e3bcf7f5fd Michael Koziarski michael@koziarski.com d69b4b7bea28fcab04f61afe381e06fa8e37b429 Matt Jones al2o3cr@gmail.com http://github.com/rails/rails/commit/aa4a7c35309ff95ef1165844d637f7e583ac20dd aa4a7c35309ff95ef1165844d637f7e583ac20dd 2008-10-08T17:35:21-07:00 2008-10-08T14:00:38-07:00 Fix script/console --sandbox warning. [#1194 state:resolved] Signed-off-by: Pratik Naik <pratiknaik@gmail.com> 7ea09e704ba9ca3e0b9f65f912f4a6f72d9d3ece Pratik Naik pratiknaik@gmail.com 0dea211f44d85e9c28963784286838bfa6c343f9 Tarmo Tänav tarmo@itech.ee http://github.com/rails/rails/commit/d69b4b7bea28fcab04f61afe381e06fa8e37b429 d69b4b7bea28fcab04f61afe381e06fa8e37b429 2008-10-08T17:19:02-07:00 2008-10-07T04:23:05-07:00 Made i18n simple backend able to store false values (and not confuse them with nil or lack of value) Implemented support.array.skip_last_comma i18n key for Array#to_sentence, this also tests the ability to store false. Signed-off-by: Pratik Naik <pratiknaik@gmail.com> eb58b3068cbe3a76e79a0c373f1458e4d05ab083 Pratik Naik pratiknaik@gmail.com 2d644fd13658fc4084f8df122bc6878c0d18df22 Matt Jones al2o3cr@gmail.com http://github.com/rails/rails/commit/0dea211f44d85e9c28963784286838bfa6c343f9 0dea211f44d85e9c28963784286838bfa6c343f9 2008-10-08T08:36:53-07:00 2008-10-08T07:29:48-07:00 Fix definition of find_name Signed-off-by: Michael Koziarski <michael@koziarski.com> [#1128 state:committed] ec5ce47a2c2663adbdfe2dd13c225d211cc2c77a Michael Koziarski michael@koziarski.com e28ad77bba0574241e6eb64dfd0c1291b221effe Matt Jones al2o3cr@gmail.com http://github.com/rails/rails/commit/2d644fd13658fc4084f8df122bc6878c0d18df22 2d644fd13658fc4084f8df122bc6878c0d18df22 2008-10-08T08:36:52-07:00 2008-10-07T20:10:45-07:00 Mark gem as not loaded when spec not found Signed-off-by: Michael Koziarski <michael@koziarski.com> 44fc496b17d41b136947d9fec297011027c62d70 Michael Koziarski michael@koziarski.com aec391621b6af7af1e0ba61c993bbdd88624eac3 Tom Stuart tom@experthuman.com http://github.com/rails/rails/commit/e28ad77bba0574241e6eb64dfd0c1291b221effe e28ad77bba0574241e6eb64dfd0c1291b221effe 2008-10-08T06:56:52-07:00 2008-10-08T01:31:00-07:00 Allow use of :path_prefix and :name_prefix outside of namespaced routes. [#1188 state:resolved] Signed-off-by: Pratik Naik <pratiknaik@gmail.com> 7027fbe4cf1715ffdf816a6c78c0aed1c579b9cd Pratik Naik pratiknaik@gmail.com 5556db22c57294a9f4e2ee4e633834ec6a200242 Michael Koziarski michael@koziarski.com http://github.com/rails/rails/commit/aec391621b6af7af1e0ba61c993bbdd88624eac3 aec391621b6af7af1e0ba61c993bbdd88624eac3 2008-10-07T12:09:07-07:00 2008-10-07T12:09:07-07:00 Make sure last_modified! works with <= rather than just equality. ea6791cfb67800cf119945befc7c1bafb0fea9d5 Michael Koziarski michael@koziarski.com a4629e707d80a5769f7a71ca6ed9471015e14dc9 Michael Koziarski michael@koziarski.com http://github.com/rails/rails/commit/5556db22c57294a9f4e2ee4e633834ec6a200242 5556db22c57294a9f4e2ee4e633834ec6a200242 2008-10-07T12:01:43-07:00 2008-10-07T11:59:03-07:00 Reduce memory usage slightly in String#parameterize [#1034 state:committed] f18e457538db1f72f06f39e8966335740448df67 Michael Koziarski michael@koziarski.com f2c10f27565318b5efbdc57fb608b2afe9ae445d Michael Koziarski michael@koziarski.com http://github.com/rails/rails/commit/a4629e707d80a5769f7a71ca6ed9471015e14dc9 a4629e707d80a5769f7a71ca6ed9471015e14dc9 2008-10-07T12:01:38-07:00 2008-09-29T08:36:09-07:00 Extract transliteration code to a seperate method. Use iconv by default, but only when the transliteration is well behaved. When it isn't, fallback to mb_chars 2f8596d17599d67aeb30e5a90040e929bd1c80dc Michael Koziarski michael@koziarski.com dce6ade4cdc2833b53bd600ef10f9bce83c7102d Cody Fauser codyfauser@gmail.com http://github.com/rails/rails/commit/f2c10f27565318b5efbdc57fb608b2afe9ae445d f2c10f27565318b5efbdc57fb608b2afe9ae445d 2008-10-07T09:48:02-07:00 2008-10-07T09:05:41-07:00 Add ActiveResource::Base#to_xml and ActiveResource::Base#to_json methods. [#1011 state:resolved] Signed-off-by: Pratik Naik <pratiknaik@gmail.com> 584cc6362342480d2c6b576d86bc9a539f8d3043 Pratik Naik pratiknaik@gmail.com 51b986619d88f7ba98be7d271188785cbbb541a0 Andrew Kaspick andrew@redlinesoftware.com http://github.com/rails/rails/commit/dce6ade4cdc2833b53bd600ef10f9bce83c7102d dce6ade4cdc2833b53bd600ef10f9bce83c7102d 2008-10-07T07:17:22-07:00 2008-09-30T12:15:36-07:00 Ensure select_tag#name attribute uses [] when :multiple is true. [#1146 state:resolved] Signed-off-by: Pratik Naik <pratiknaik@gmail.com> 70774db6de17c2e5a4e82f7832b213288fab3d1a Pratik Naik pratiknaik@gmail.com 8e50f0f96ef53ee8cc7ffa86ce0e71cc357b2b6c Tarmo Tänav tarmo@itech.ee http://github.com/rails/rails/commit/51b986619d88f7ba98be7d271188785cbbb541a0 51b986619d88f7ba98be7d271188785cbbb541a0 2008-10-06T16:12:20-07:00 2008-10-06T07:35:21-07:00 Implement submit_to_remote as a wrapper around a more generic button_to_remote Removed the "return false" from submit_to_remote onclick end as button input elements have no default behavior to cancel. Signed-off-by: Pratik Naik <pratiknaik@gmail.com> e0fbc752ec252c8a1bef0a5cd96db9a3dd999fa3 Pratik Naik pratiknaik@gmail.com efb9ef65ccd1e047605887fc76eab41b9add45bd madlep madlep@ubercharged.net http://github.com/rails/rails/commit/8e50f0f96ef53ee8cc7ffa86ce0e71cc357b2b6c 8e50f0f96ef53ee8cc7ffa86ce0e71cc357b2b6c 2008-10-06T15:43:41-07:00 2008-10-06T15:43:03-07:00 Fix image_tag behavior on windows. [#1085 state:resolved] Signed-off-by: Pratik Naik <pratiknaik@gmail.com> a4981b6aae144164887ae2827d47e6ad32a6c73d Pratik Naik pratiknaik@gmail.com 5bc91b059209f4d659346ace31c4014be789e0be Manfred Stienstra manfred@fngtps.com http://github.com/rails/rails/commit/efb9ef65ccd1e047605887fc76eab41b9add45bd efb9ef65ccd1e047605887fc76eab41b9add45bd 2008-10-06T11:04:45-07:00 2008-10-06T10:42:51-07:00 Fix a typo in ActiveSupport::Multibyte::NORMALIZATION_FORMS. [#1179 state:resolved] Signed-off-by: Pratik Naik <pratiknaik@gmail.com> a4b491e43a5ce0573508a9196caff46d31ded645 Pratik Naik pratiknaik@gmail.com 8603813ac6e1bff8d3addad58d0a56b33baafc59 Jeremy Kemper jeremy@bitsweat.net http://github.com/rails/rails/commit/5bc91b059209f4d659346ace31c4014be789e0be 5bc91b059209f4d659346ace31c4014be789e0be 2008-10-06T10:56:56-07:00 2008-10-06T10:56:56-07:00 Mark utf-8 source encoding 9657a41b09c186ad3e8ce778386ffdd01a4d2c67 Jeremy Kemper jeremy@bitsweat.net 1c75b4fd42c707ce3d539e8453784b4abf74e035 Eugene Pimenov libc@mac.com http://github.com/rails/rails/commit/8603813ac6e1bff8d3addad58d0a56b33baafc59 8603813ac6e1bff8d3addad58d0a56b33baafc59 2008-10-05T15:25:58-07:00 2008-10-05T15:24:52-07:00 Fix memoize_all for methods with punctuation [#1175 state:resolved] Signed-off-by: Joshua Peek <josh@joshpeek.com> 05e41813fde44b811bc69a4a87f63e74420c5913 Joshua Peek josh@joshpeek.com a2932784bb71e72a78c32819ebd7ed2bed551e3e Chris Cherry ctcherry@gmail.com http://github.com/rails/rails/commit/1c75b4fd42c707ce3d539e8453784b4abf74e035 1c75b4fd42c707ce3d539e8453784b4abf74e035 2008-10-05T15:25:57-07:00 2008-10-05T15:11:18-07:00 Fix deprecated ActionController::Base.relative_url_root call in mongrel command Signed-off-by: Joshua Peek <josh@joshpeek.com> 6364d265319a84f1d60b7424177d24a912e0c9b6 Joshua Peek josh@joshpeek.com 4df45d86097efbeabceecfe53d8ea2da9ccbb107 Pratik Naik pratiknaik@gmail.com http://github.com/rails/rails/commit/a2932784bb71e72a78c32819ebd7ed2bed551e3e a2932784bb71e72a78c32819ebd7ed2bed551e3e 2008-10-05T14:16:26-07:00 2008-10-05T14:16:26-07:00 Merge docrails 99bfd589a48153e33f19ae72baa6e98f5708a9b8 Pratik Naik pratiknaik@gmail.com 2bf58aa782d3b493f2d98f153324b93c5b058ba6 Matthew Moore matt@thrivesmart.com http://github.com/rails/rails/commit/4df45d86097efbeabceecfe53d8ea2da9ccbb107 4df45d86097efbeabceecfe53d8ea2da9ccbb107 2008-10-05T10:29:13-07:00 2008-09-15T18:09:22-07:00 ActiveResource can load array of strings, like serialize :bar, Array Signed-off-by: rick <technoweenie@gmail.com> [#1055 state:resolved] 6c0b1918687ff05ca5ee8d40dd2549eb4c991a43 rick technoweenie@gmail.com 4f53db0096be4b167628a136044b0d1262215277 Matt Jones al2o3cr@gmail.com http://github.com/rails/rails/commit/2bf58aa782d3b493f2d98f153324b93c5b058ba6 2bf58aa782d3b493f2d98f153324b93c5b058ba6 2008-10-05T10:16:17-07:00 2008-10-04T10:51:23-07:00 Fix a number of errors in the config.gem mechanism. * Rails::GemDependency was missing definitions for hash and eql?, causing Array#uniq to not work. * If several versions of a gem are unpacked in vendor, now chooses the highest if no version is specified. * streamlined add_load_path. Now sets up Rubygems correctly to allow 'gem' to find frozen gems, with gems frozen to vendor/gems and specifications in vendor/gems/<gem-name>/.specification * Rails::GemDependency#specification would return a spec for the highest installed version, even for frozen gems and/or previously loaded lower versions. See in part ticket #1123. * removed vendor from default_load_paths - it was causing autoloading to append Gems::Gems::<gem-dir> to constant names * added additional tests for loading frozen gems. * incorporates the fix from #1107 for vendor rails * defers to freeze:gems for handling the Rails framework. gems:unpack WILL NOT place a copy of Rails in vendor/gems. Should close #1123 completely. * incorporates, via using the gem loader for frozen gems, fixes corresponding to #227, #324, #362, #527, and #742. * gem plugins now work the same whether frozen or not. Correctness of the behavior is a matter for another ticket... Signed-off-by: rick <technoweenie@gmail.com> 53278af87e3590bb901754b2e2f8ce1d13d49d73 rick technoweenie@gmail.com 259a7a844b53b7d508145cc61fed9e11581e5409 Pratik Naik pratiknaik@gmail.com http://github.com/rails/rails/commit/4f53db0096be4b167628a136044b0d1262215277 4f53db0096be4b167628a136044b0d1262215277 2008-10-05T06:01:00-07:00 2008-10-05T05:55:28-07:00 Move controller ivar copying to a separate method 00277aeb7d0e949aec56b4bf3b2846dd73104a59 Pratik Naik pratiknaik@gmail.com 964dfc15572d7c10771c81ac3cbfb455dd5e378e Pratik Naik pratiknaik@gmail.com http://github.com/rails/rails/commit/259a7a844b53b7d508145cc61fed9e11581e5409 259a7a844b53b7d508145cc61fed9e11581e5409 2008-10-04T14:13:50-07:00 2008-10-04T13:48:18-07:00 Add tests for ActiveSupport::Rescuable. Use ActiveSupport::Rescuable in ActionController::Base. ca91608fbab39d03b59137d018046606717883bd Pratik Naik pratiknaik@gmail.com 9599948fbcd67c1c2c5fecc2dca148e998479e33 Norbert Crombach norbert.crombach@primetheory.org http://github.com/rails/rails/commit/964dfc15572d7c10771c81ac3cbfb455dd5e378e 964dfc15572d7c10771c81ac3cbfb455dd5e378e 2008-10-04T12:28:08-07:00 2008-10-04T12:28:08-07:00 First draft of ActiveSupport::Rescuable Signed-off-by: Pratik Naik <pratiknaik@gmail.com> 93c3e129b92ef16255509429eaf47bff684f53f5 Pratik Naik pratiknaik@gmail.com 1dfebd4f0d25ecf50ba4e320234523d9ee3f7523 Pratik Naik pratiknaik@gmail.com http://github.com/rails/rails/commit/9599948fbcd67c1c2c5fecc2dca148e998479e33 9599948fbcd67c1c2c5fecc2dca148e998479e33 2008-10-04T12:13:44-07:00 2008-10-04T12:03:42-07:00 Ensure Model.sum and Model.avg typecast appropriately. [#1066 state:resolved] Model.sum delegates typecasting to the column being summed. If that's not feasible, returns a string. Model.avg always returns big decimal. 919ce7796f1605c3ba6f7edc81afc2bcac4eaad5 Pratik Naik pratiknaik@gmail.com 923eb9569c2289581d6a48dbd4447202a5ac93d8 Michael Koziarski michael@koziarski.com http://github.com/rails/rails/commit/1dfebd4f0d25ecf50ba4e320234523d9ee3f7523 1dfebd4f0d25ecf50ba4e320234523d9ee3f7523 2008-10-04T12:11:30-07:00 2008-10-04T12:10:36-07:00 1.8 compatibility for random_number method on SecureRandom. 1.9 has its own version. 56edc41aa201b47804cb1eebd34f2636e79bbd8f Michael Koziarski michael@koziarski.com 5e3517ea7b9fbd460f772bffc9212d882011f2bc Michael Koziarski michael@koziarski.com http://github.com/rails/rails/commit/923eb9569c2289581d6a48dbd4447202a5ac93d8 923eb9569c2289581d6a48dbd4447202a5ac93d8 2008-10-04T12:11:30-07:00 2008-10-04T12:10:14-07:00 Fix mismatched assertions. 8eb7c7ce81cf4ec4378bcdb21b86af29cc00c3de Michael Koziarski michael@koziarski.com 4918e6de989a80bb2ae92183f1b4eb98c15b487f Pratik Naik pratiknaik@gmail.com http://github.com/rails/rails/commit/5e3517ea7b9fbd460f772bffc9212d882011f2bc 5e3517ea7b9fbd460f772bffc9212d882011f2bc 2008-10-04T10:43:46-07:00 2008-10-04T10:43:46-07:00 Ensure rescue_from handlers are respected inside tests. [#835 state:resolved] Note : If you're not using rescue_from, you should overrider rescue_action_without_handler() method and not rescue_action(). Afterwards, you can set request.remote_addr to a non "0.0.0.0" value for testing the overridden behavior. b715e53185ffca19a2c7c1ea099ed8eaa1bec7e1 Pratik Naik pratiknaik@gmail.com 25ca21ae21d49f06708357a5ce0670103ced2d58 Pratik Naik pratiknaik@gmail.com http://github.com/rails/rails/commit/4918e6de989a80bb2ae92183f1b4eb98c15b487f 4918e6de989a80bb2ae92183f1b4eb98c15b487f 2008-10-04T09:49:39-07:00 2008-10-04T09:41:27-07:00 Remove HasManyAssociationStrategy and move the logic to ActiveRecord::Reflection::ThroughReflection. fe8842f0204f1bf4934efe7a02f7df192b0f263b Pratik Naik pratiknaik@gmail.com 95e1cf4812d4b964d7ab0fdf4bfa31177d27909c Pratik Naik pratiknaik@gmail.com http://github.com/rails/rails/commit/25ca21ae21d49f06708357a5ce0670103ced2d58 25ca21ae21d49f06708357a5ce0670103ced2d58 2008-10-04T09:49:39-07:00 2008-10-04T08:53:13-07:00 Introduce ActiveRecord::Reflection::ThroughReflection to simplify hm:t reflection logic 90fbb7068d3836589a090b740ef7c57ff1b809de Pratik Naik pratiknaik@gmail.com