8e50f0f96ef53ee8cc7ffa86ce0e71cc357b2b6c Tarmo Tänav tarmo@itech.ee http://github.com/rails/rails/commit/51b986619d88f7ba98be7d271188785cbbb541a0 51b986619d88f7ba98be7d271188785cbbb541a0 2008-10-06T16:12:20-07:00 2008-10-06T07:35:21-07:00 Implement submit_to_remote as a wrapper around a more generic button_to_remote Removed the "return false" from submit_to_remote onclick end as button input elements have no default behavior to cancel. Signed-off-by: Pratik Naik <pratiknaik@gmail.com> e0fbc752ec252c8a1bef0a5cd96db9a3dd999fa3 Pratik Naik pratiknaik@gmail.com efb9ef65ccd1e047605887fc76eab41b9add45bd madlep madlep@ubercharged.net http://github.com/rails/rails/commit/8e50f0f96ef53ee8cc7ffa86ce0e71cc357b2b6c 8e50f0f96ef53ee8cc7ffa86ce0e71cc357b2b6c 2008-10-06T15:43:41-07:00 2008-10-06T15:43:03-07:00 Fix image_tag behavior on windows. [#1085 state:resolved] Signed-off-by: Pratik Naik <pratiknaik@gmail.com> a4981b6aae144164887ae2827d47e6ad32a6c73d Pratik Naik pratiknaik@gmail.com 5bc91b059209f4d659346ace31c4014be789e0be Manfred Stienstra manfred@fngtps.com http://github.com/rails/rails/commit/efb9ef65ccd1e047605887fc76eab41b9add45bd efb9ef65ccd1e047605887fc76eab41b9add45bd 2008-10-06T11:04:45-07:00 2008-10-06T10:42:51-07:00 Fix a typo in ActiveSupport::Multibyte::NORMALIZATION_FORMS. [#1179 state:resolved] Signed-off-by: Pratik Naik <pratiknaik@gmail.com> a4b491e43a5ce0573508a9196caff46d31ded645 Pratik Naik pratiknaik@gmail.com 8603813ac6e1bff8d3addad58d0a56b33baafc59 Jeremy Kemper jeremy@bitsweat.net http://github.com/rails/rails/commit/5bc91b059209f4d659346ace31c4014be789e0be 5bc91b059209f4d659346ace31c4014be789e0be 2008-10-06T10:56:56-07:00 2008-10-06T10:56:56-07:00 Mark utf-8 source encoding 9657a41b09c186ad3e8ce778386ffdd01a4d2c67 Jeremy Kemper jeremy@bitsweat.net 1c75b4fd42c707ce3d539e8453784b4abf74e035 Eugene Pimenov libc@mac.com http://github.com/rails/rails/commit/8603813ac6e1bff8d3addad58d0a56b33baafc59 8603813ac6e1bff8d3addad58d0a56b33baafc59 2008-10-05T15:25:58-07:00 2008-10-05T15:24:52-07:00 Fix memoize_all for methods with punctuation [#1175 state:resolved] Signed-off-by: Joshua Peek <josh@joshpeek.com> 05e41813fde44b811bc69a4a87f63e74420c5913 Joshua Peek josh@joshpeek.com a2932784bb71e72a78c32819ebd7ed2bed551e3e Chris Cherry ctcherry@gmail.com http://github.com/rails/rails/commit/1c75b4fd42c707ce3d539e8453784b4abf74e035 1c75b4fd42c707ce3d539e8453784b4abf74e035 2008-10-05T15:25:57-07:00 2008-10-05T15:11:18-07:00 Fix deprecated ActionController::Base.relative_url_root call in mongrel command Signed-off-by: Joshua Peek <josh@joshpeek.com> 6364d265319a84f1d60b7424177d24a912e0c9b6 Joshua Peek josh@joshpeek.com 4df45d86097efbeabceecfe53d8ea2da9ccbb107 Pratik Naik pratiknaik@gmail.com http://github.com/rails/rails/commit/a2932784bb71e72a78c32819ebd7ed2bed551e3e a2932784bb71e72a78c32819ebd7ed2bed551e3e 2008-10-05T14:16:26-07:00 2008-10-05T14:16:26-07:00 Merge docrails 99bfd589a48153e33f19ae72baa6e98f5708a9b8 Pratik Naik pratiknaik@gmail.com 2bf58aa782d3b493f2d98f153324b93c5b058ba6 Matthew Moore matt@thrivesmart.com http://github.com/rails/rails/commit/4df45d86097efbeabceecfe53d8ea2da9ccbb107 4df45d86097efbeabceecfe53d8ea2da9ccbb107 2008-10-05T10:29:13-07:00 2008-09-15T18:09:22-07:00 ActiveResource can load array of strings, like serialize :bar, Array Signed-off-by: rick <technoweenie@gmail.com> [#1055 state:resolved] 6c0b1918687ff05ca5ee8d40dd2549eb4c991a43 rick technoweenie@gmail.com 4f53db0096be4b167628a136044b0d1262215277 Matt Jones al2o3cr@gmail.com http://github.com/rails/rails/commit/2bf58aa782d3b493f2d98f153324b93c5b058ba6 2bf58aa782d3b493f2d98f153324b93c5b058ba6 2008-10-05T10:16:17-07:00 2008-10-04T10:51:23-07:00 Fix a number of errors in the config.gem mechanism. * Rails::GemDependency was missing definitions for hash and eql?, causing Array#uniq to not work. * If several versions of a gem are unpacked in vendor, now chooses the highest if no version is specified. * streamlined add_load_path. Now sets up Rubygems correctly to allow 'gem' to find frozen gems, with gems frozen to vendor/gems and specifications in vendor/gems/<gem-name>/.specification * Rails::GemDependency#specification would return a spec for the highest installed version, even for frozen gems and/or previously loaded lower versions. See in part ticket #1123. * removed vendor from default_load_paths - it was causing autoloading to append Gems::Gems::<gem-dir> to constant names * added additional tests for loading frozen gems. * incorporates the fix from #1107 for vendor rails * defers to freeze:gems for handling the Rails framework. gems:unpack WILL NOT place a copy of Rails in vendor/gems. Should close #1123 completely. * incorporates, via using the gem loader for frozen gems, fixes corresponding to #227, #324, #362, #527, and #742. * gem plugins now work the same whether frozen or not. Correctness of the behavior is a matter for another ticket... Signed-off-by: rick <technoweenie@gmail.com> 53278af87e3590bb901754b2e2f8ce1d13d49d73 rick technoweenie@gmail.com 259a7a844b53b7d508145cc61fed9e11581e5409 Pratik Naik pratiknaik@gmail.com http://github.com/rails/rails/commit/4f53db0096be4b167628a136044b0d1262215277 4f53db0096be4b167628a136044b0d1262215277 2008-10-05T06:01:00-07:00 2008-10-05T05:55:28-07:00 Move controller ivar copying to a separate method 00277aeb7d0e949aec56b4bf3b2846dd73104a59 Pratik Naik pratiknaik@gmail.com 964dfc15572d7c10771c81ac3cbfb455dd5e378e Pratik Naik pratiknaik@gmail.com http://github.com/rails/rails/commit/259a7a844b53b7d508145cc61fed9e11581e5409 259a7a844b53b7d508145cc61fed9e11581e5409 2008-10-04T14:13:50-07:00 2008-10-04T13:48:18-07:00 Add tests for ActiveSupport::Rescuable. Use ActiveSupport::Rescuable in ActionController::Base. ca91608fbab39d03b59137d018046606717883bd Pratik Naik pratiknaik@gmail.com 9599948fbcd67c1c2c5fecc2dca148e998479e33 Norbert Crombach norbert.crombach@primetheory.org http://github.com/rails/rails/commit/964dfc15572d7c10771c81ac3cbfb455dd5e378e 964dfc15572d7c10771c81ac3cbfb455dd5e378e 2008-10-04T12:28:08-07:00 2008-10-04T12:28:08-07:00 First draft of ActiveSupport::Rescuable Signed-off-by: Pratik Naik <pratiknaik@gmail.com> 93c3e129b92ef16255509429eaf47bff684f53f5 Pratik Naik pratiknaik@gmail.com 1dfebd4f0d25ecf50ba4e320234523d9ee3f7523 Pratik Naik pratiknaik@gmail.com http://github.com/rails/rails/commit/9599948fbcd67c1c2c5fecc2dca148e998479e33 9599948fbcd67c1c2c5fecc2dca148e998479e33 2008-10-04T12:13:44-07:00 2008-10-04T12:03:42-07:00 Ensure Model.sum and Model.avg typecast appropriately. [#1066 state:resolved] Model.sum delegates typecasting to the column being summed. If that's not feasible, returns a string. Model.avg always returns big decimal. 919ce7796f1605c3ba6f7edc81afc2bcac4eaad5 Pratik Naik pratiknaik@gmail.com 923eb9569c2289581d6a48dbd4447202a5ac93d8 Michael Koziarski michael@koziarski.com http://github.com/rails/rails/commit/1dfebd4f0d25ecf50ba4e320234523d9ee3f7523 1dfebd4f0d25ecf50ba4e320234523d9ee3f7523 2008-10-04T12:11:30-07:00 2008-10-04T12:10:36-07:00 1.8 compatibility for random_number method on SecureRandom. 1.9 has its own version. 56edc41aa201b47804cb1eebd34f2636e79bbd8f Michael Koziarski michael@koziarski.com 5e3517ea7b9fbd460f772bffc9212d882011f2bc Michael Koziarski michael@koziarski.com http://github.com/rails/rails/commit/923eb9569c2289581d6a48dbd4447202a5ac93d8 923eb9569c2289581d6a48dbd4447202a5ac93d8 2008-10-04T12:11:30-07:00 2008-10-04T12:10:14-07:00 Fix mismatched assertions. 8eb7c7ce81cf4ec4378bcdb21b86af29cc00c3de Michael Koziarski michael@koziarski.com 4918e6de989a80bb2ae92183f1b4eb98c15b487f Pratik Naik pratiknaik@gmail.com http://github.com/rails/rails/commit/5e3517ea7b9fbd460f772bffc9212d882011f2bc 5e3517ea7b9fbd460f772bffc9212d882011f2bc 2008-10-04T10:43:46-07:00 2008-10-04T10:43:46-07:00 Ensure rescue_from handlers are respected inside tests. [#835 state:resolved] Note : If you're not using rescue_from, you should overrider rescue_action_without_handler() method and not rescue_action(). Afterwards, you can set request.remote_addr to a non "0.0.0.0" value for testing the overridden behavior. b715e53185ffca19a2c7c1ea099ed8eaa1bec7e1 Pratik Naik pratiknaik@gmail.com 25ca21ae21d49f06708357a5ce0670103ced2d58 Pratik Naik pratiknaik@gmail.com http://github.com/rails/rails/commit/4918e6de989a80bb2ae92183f1b4eb98c15b487f 4918e6de989a80bb2ae92183f1b4eb98c15b487f 2008-10-04T09:49:39-07:00 2008-10-04T09:41:27-07:00 Remove HasManyAssociationStrategy and move the logic to ActiveRecord::Reflection::ThroughReflection. fe8842f0204f1bf4934efe7a02f7df192b0f263b Pratik Naik pratiknaik@gmail.com 95e1cf4812d4b964d7ab0fdf4bfa31177d27909c Pratik Naik pratiknaik@gmail.com http://github.com/rails/rails/commit/25ca21ae21d49f06708357a5ce0670103ced2d58 25ca21ae21d49f06708357a5ce0670103ced2d58 2008-10-04T09:49:39-07:00 2008-10-04T08:53:13-07:00 Introduce ActiveRecord::Reflection::ThroughReflection to simplify hm:t reflection logic 90fbb7068d3836589a090b740ef7c57ff1b809de Pratik Naik pratiknaik@gmail.com 7659fb6a2b638703a99a63033d947d19089a6b85 Zach Dennis zach.dennis@gmail.com http://github.com/rails/rails/commit/95e1cf4812d4b964d7ab0fdf4bfa31177d27909c 95e1cf4812d4b964d7ab0fdf4bfa31177d27909c 2008-10-04T09:49:39-07:00 2008-10-04T07:42:36-07:00 Fix has_many :through when the source is a belongs_to association. [#323 state:resolved] Signed-off-by: Pratik Naik <pratiknaik@gmail.com> 82d7154cbf293128a06fafe040cf68f4d9d18f7f Pratik Naik pratiknaik@gmail.com b437a7d34e86c16a211171d491e805b603f0dc99 Lawrence Pit lawrence.pit@gmail.com http://github.com/rails/rails/commit/7659fb6a2b638703a99a63033d947d19089a6b85 7659fb6a2b638703a99a63033d947d19089a6b85 2008-10-04T09:49:38-07:00 2008-10-04T07:31:04-07:00 Try reloading model on class mismatch [#229 state:resolved] Signed-off-by: Pratik Naik <pratiknaik@gmail.com> 8fd60cdb04a6185be763433d0dfa9741972c70c7 Pratik Naik pratiknaik@gmail.com f550c8625739106e957e4260d3d592a9665fc943 Aliaksey Kandratsenka alk@tut.by http://github.com/rails/rails/commit/b437a7d34e86c16a211171d491e805b603f0dc99 b437a7d34e86c16a211171d491e805b603f0dc99 2008-10-04T09:25:08-07:00 2008-10-02T11:06:22-07:00 Return processing lock to dispatcher, the finer grained lock was incompatible with the reloading in development mode. This commit also adds ActionController::Dispatcher#dispatch_unlocking -- non-locking version of dispatch. It's named anologously to POSIX {getc,getchar,...}_unlocked functions. Signed-off-by: Michael Koziarski <michael@koziarski.com> [#1170 state:committed] ecbb3fa54c96c38e492d9fcbd8f677718d0ef0af Michael Koziarski michael@koziarski.com 6080b73b1cf6c9ff969b81751a1e5d26d7633a32 Aliaksey Kandratsenka alk@tut.by http://github.com/rails/rails/commit/f550c8625739106e957e4260d3d592a9665fc943 f550c8625739106e957e4260d3d592a9665fc943 2008-10-04T08:48:13-07:00 2008-10-03T03:40:51-07:00 Fix performance bug in AttibuteMethods#respond_to? in handling of private methods We have hit dramatic increase in tests time after upgrading rails. Profiling revealed this particular place. After this fix our test times returned back to norm. Signed-off-by: Michael Koziarski <michael@koziarski.com> [#1173 state:committed] 3822417cd66dfd4a03f817cdc4e64a4f7062d457 Michael Koziarski michael@koziarski.com 834361145a805b5077f962dc2e67a0a9ea882535 Aliaksey Kandratsenka alk@tut.by http://github.com/rails/rails/commit/6080b73b1cf6c9ff969b81751a1e5d26d7633a32 6080b73b1cf6c9ff969b81751a1e5d26d7633a32 2008-10-04T08:48:13-07:00 2008-10-02T12:59:03-07:00 call clear_active_connections! in :after_dispatch to give pooled connections back This fixes connection pool exhaustion for web servers which create new thread per connection (e.g. Webrick). integration.rb changes are required to keep test transaction active for several requests. Signed-off-by: Michael Koziarski <michael@koziarski.com> [#1171 state:committed] 20ce3433da390db10f9dacb6ea2d63a1c5d4d4a9 Michael Koziarski michael@koziarski.com 21eb18a70c7a1f08e7e2dc1c5bc17d67e1d14c46 Aliaksey Kandratsenka alk@tut.by http://github.com/rails/rails/commit/834361145a805b5077f962dc2e67a0a9ea882535 834361145a805b5077f962dc2e67a0a9ea882535 2008-10-04T08:48:13-07:00 2008-10-02T12:59:49-07:00 made ConnectionPool#checkout more robust by trying to loot dead threads when pool is empty Signed-off-by: Michael Koziarski <michael@koziarski.com> [#1169 state:committed] ca7b7005a3fbe97fb4031ef44320ffb84f721c2c Michael Koziarski michael@koziarski.com 4cb3d27443fa30fde528f07658e76537f38a0661 Aliaksey Kandratsenka alk@tut.by http://github.com/rails/rails/commit/21eb18a70c7a1f08e7e2dc1c5bc17d67e1d14c46 21eb18a70c7a1f08e7e2dc1c5bc17d67e1d14c46 2008-10-04T08:48:13-07:00 2008-10-02T11:44:49-07:00 Fix race in ConnectionPool#checkout After releasing monitor some connection(s) may appear in pool before monitor is re-aquired. When this happens we'll wait for connection which is already available. Signed-off-by: Michael Koziarski <michael@koziarski.com> 099177cd0b202753f11001ba18d7dbf54400424b Michael Koziarski michael@koziarski.com 2def5b6314e1fbbaa789d1311e488ffac498703d Aliaksey Kandratsenka alk@tut.by http://github.com/rails/rails/commit/4cb3d27443fa30fde528f07658e76537f38a0661 4cb3d27443fa30fde528f07658e76537f38a0661 2008-10-04T08:48:13-07:00 2008-09-06T01:22:01-07:00 don't quote decimal values for mysql. It doesn't make sense and breaks in newer versions of mysql Signed-off-by: Michael Koziarski <michael@koziarski.com> [#1168 state:committed] 9a37a3bbe65f770e7b841eb01d3bc6f532286af5 Michael Koziarski michael@koziarski.com f0e90740d0ca35b3fae5cf367334929534c35555 madlep madlep@ubercharged.net http://github.com/rails/rails/commit/2def5b6314e1fbbaa789d1311e488ffac498703d 2def5b6314e1fbbaa789d1311e488ffac498703d 2008-10-04T07:57:18-07:00 2008-10-04T01:13:14-07:00 Fixed load path for actionmailer and activesupport tests to always load from local lib files. [#983 state:committed] Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net> f86e3f2a50cfd7fadb58215a7612fadae6b4bca4 Jeremy Kemper jeremy@bitsweat.net 1bc267d21679408b3624d1c697656ec250c01972 Antonio Cangiano acangiano@gmail.com http://github.com/rails/rails/commit/f0e90740d0ca35b3fae5cf367334929534c35555 f0e90740d0ca35b3fae5cf367334929534c35555 2008-10-04T05:54:27-07:00 2008-10-02T18:50:45-07:00 Add IMB DB support to Rails application generator. [#1136 state:resolved] Usage : rails app_name -d ibm_db Signed-off-by: Pratik Naik <pratiknaik@gmail.com> 8632b5b8f4412b264daf75db7c00951f404f884e Pratik Naik pratiknaik@gmail.com 7553a23c0a84424bdbc09cc81791f41bfebe1b25 Luca Guidi guidi.luca@gmail.com http://github.com/rails/rails/commit/1bc267d21679408b3624d1c697656ec250c01972 1bc267d21679408b3624d1c697656ec250c01972 2008-10-03T13:08:55-07:00 2008-10-03T07:08:17-07:00 Make sure recreate MySQL test database with the proper encoding and collation [#1165 state:resolved] Signed-off-by: Michael Koziarski <michael@koziarski.com> [#1165 state:committed] 215ca0839ffea807b930a3dd3e29e5c48d5061f3 Michael Koziarski michael@koziarski.com 00e2ba76b21d3c433a0ecda0de28d931c34d1791 Michael Koziarski michael@koziarski.com http://github.com/rails/rails/commit/7553a23c0a84424bdbc09cc81791f41bfebe1b25 7553a23c0a84424bdbc09cc81791f41bfebe1b25 2008-10-03T12:35:01-07:00 2008-10-03T12:35:01-07:00 Remove AS for oracle compatibility 5f98e7c320f4eb2e1d0309353fe1f4684a1e19ea Michael Koziarski michael@koziarski.com