f7015336f66d284cff8ecb89df9f430791ac57ea Tim Harper timcharper@gmail.com http://github.com/rails/rails/commit/aef47dcf937a5c9f150c50b73cffd9fa9eb64915 aef47dcf937a5c9f150c50b73cffd9fa9eb64915 2008-05-31T13:23:00-07:00 2008-05-13T18:17:40-07:00 belongs_to polymorphic association assignments update the foreign_id and foreign_type fields regardless of whether the record being assigned is new or not. fixes the following scenarios: * I have validates_inclusion_of on the type field for a polymorphic belongs_to association. I assign a new record to the model's polymorphic relationship of the proper type. validation fails because the type field has not been updated. * I replace the value for a ppolymorphic association to a new record of another class. The type field still says its the previous class, and the id field points to the previous record as well. 8bb596cb3279cf0b703edd6e8a3a70a7b443a082 rick technoweenie@gmail.com 03ba5d7b5183e7cb199a21aa6e06d646f7a5cbfe Ryan Bates ryan@railscasts.com http://github.com/rails/rails/commit/f7015336f66d284cff8ecb89df9f430791ac57ea f7015336f66d284cff8ecb89df9f430791ac57ea 2008-05-31T12:36:07-07:00 2008-05-31T12:36:07-07:00 Fix default nil tests for MySQL 5.0.51 [#192 state:resolved] Signed-off-by: Joshua Peek <josh@joshpeek.com> f304752df971a230cc9af42ec507dc47432af3b8 Joshua Peek josh@joshpeek.com 2ce1be3ac4823ccdfbe36ff5548a562aa5106d2e Jeremy Kemper jeremy@bitsweat.net http://github.com/rails/rails/commit/03ba5d7b5183e7cb199a21aa6e06d646f7a5cbfe 03ba5d7b5183e7cb199a21aa6e06d646f7a5cbfe 2008-05-30T04:36:00-07:00 2008-05-30T04:36:00-07:00 Ensure query assertion counts are the same when partial updates are enabled 9666ddc5c318132a670a2e82a23275d39380e4cc Jeremy Kemper jeremy@bitsweat.net 946f51449a2531b8c1a92035b4482ae633d56894 Jeremy Kemper jeremy@bitsweat.net http://github.com/rails/rails/commit/2ce1be3ac4823ccdfbe36ff5548a562aa5106d2e 2ce1be3ac4823ccdfbe36ff5548a562aa5106d2e 2008-05-30T04:16:57-07:00 2008-05-30T04:16:57-07:00 Enable partial updates by default 3425d26c06104f522d51e33f776b90fc60a42a2f Jeremy Kemper jeremy@bitsweat.net 131dd0e912f4ba1880eb53dfbf2f9add277a183e Jeremy Kemper jeremy@bitsweat.net http://github.com/rails/rails/commit/946f51449a2531b8c1a92035b4482ae633d56894 946f51449a2531b8c1a92035b4482ae633d56894 2008-05-30T02:39:00-07:00 2008-05-30T02:39:00-07:00 Require ruby-prof 0.6.1 or later. Use resume/pause to omit extraneous machinery from profile. ca7b92a109e231ba21ec0380bb30c71d85cc53fc Jeremy Kemper jeremy@bitsweat.net 1b0654ea41d15552c19f767570d4f551d617e742 Jeremy Kemper jeremy@bitsweat.net http://github.com/rails/rails/commit/131dd0e912f4ba1880eb53dfbf2f9add277a183e 131dd0e912f4ba1880eb53dfbf2f9add277a183e 2008-05-30T02:31:39-07:00 2008-05-30T02:31:39-07:00 git ignore rubinius .rbc files c2ce8f3ad761e69747b0f06d30bf0b066cf3dc38 Jeremy Kemper jeremy@bitsweat.net 235d635708dd72bee0828457af5397c79750483a Tekin Suleyman tekin@tekin.co.uk http://github.com/rails/rails/commit/1b0654ea41d15552c19f767570d4f551d617e742 1b0654ea41d15552c19f767570d4f551d617e742 2008-05-29T12:21:49-07:00 2008-05-29T10:40:30-07:00 Ensure script/plugin installs ssh/git plugins. [#277 state:resolved] Signed-off-by: Pratik Naik <pratiknaik@gmail.com> 332bc1f8fa3787c2cbfeb70ad1e5fdfb54c57324 Pratik Naik pratiknaik@gmail.com cf6299dbd73a8cb6d74265df03d01abe885e686a Andrew White andyw@pixeltrix.co.uk http://github.com/rails/rails/commit/235d635708dd72bee0828457af5397c79750483a 235d635708dd72bee0828457af5397c79750483a 2008-05-29T06:10:24-07:00 2008-05-29T04:59:29-07:00 Ensure :select passed in options overrides the one from the scope. [#239 state:resolved] Signed-off-by: Pratik Naik <pratiknaik@gmail.com> 51f09f956b8f4d84d6f0e81dd697d577ffcd7f92 Pratik Naik pratiknaik@gmail.com abb1bd2efa43b8efbb3faf4ccfb9246704a9044c Adam kohnkecomm@Adam-iMac.local http://github.com/rails/rails/commit/cf6299dbd73a8cb6d74265df03d01abe885e686a cf6299dbd73a8cb6d74265df03d01abe885e686a 2008-05-29T02:38:00-07:00 2008-05-23T10:40:36-07:00 Add ActionMailer#reply_to. [#245 state:resolved] Signed-off-by: Pratik Naik <pratiknaik@gmail.com> e54c80862aa91a2ca8fcf48d4d0775bad0bac912 Pratik Naik pratiknaik@gmail.com 4d248543429918bc5a63e109e6f2327ffab9848b Pratik Naik pratiknaik@gmail.com http://github.com/rails/rails/commit/abb1bd2efa43b8efbb3faf4ccfb9246704a9044c abb1bd2efa43b8efbb3faf4ccfb9246704a9044c 2008-05-29T02:20:39-07:00 2008-05-29T02:20:39-07:00 Ensure AssociationCollection#count works with empty condition. [#271 state:resolved] [Jan De Poorter] 197406a437a6f16de276979f983e499e4a448bf7 Pratik Naik pratiknaik@gmail.com c2fbcba16d2349285368c86b849db946dc0e7d57 Pratik Naik pratiknaik@gmail.com http://github.com/rails/rails/commit/4d248543429918bc5a63e109e6f2327ffab9848b 4d248543429918bc5a63e109e6f2327ffab9848b 2008-05-28T14:58:45-07:00 2008-05-28T14:58:45-07:00 Ensure correct db time is reported in production logs. 5506aa754aa64a8fcf7e7ddca0a3e85b590f9d38 Pratik Naik pratiknaik@gmail.com 888a2927b65889465ce7a1a71e87d37640a2b41b Ryan Bates ryan@railscasts.com http://github.com/rails/rails/commit/c2fbcba16d2349285368c86b849db946dc0e7d57 c2fbcba16d2349285368c86b849db946dc0e7d57 2008-05-28T03:02:07-07:00 2008-05-27T07:31:53-07:00 Ensure named_scope#empty? uses count query. [#262 state:resolved] Signed-off-by: Pratik Naik <pratiknaik@gmail.com> 3cf328f85d012018e028c1abf42ece6b47d830c8 Pratik Naik pratiknaik@gmail.com 7520770c825eab21079dd2b69b1199f138294301 Jeremy Kemper jeremy@bitsweat.net http://github.com/rails/rails/commit/888a2927b65889465ce7a1a71e87d37640a2b41b 888a2927b65889465ce7a1a71e87d37640a2b41b 2008-05-26T01:39:21-07:00 2008-05-26T01:39:21-07:00 Remove superfluous tests directive b04f53f1d21ee2c98a93e463b68644f7edacc15b Jeremy Kemper jeremy@bitsweat.net c5d37c0662a65ce9723d668f57b59457e79ee5ca Jeremy Kemper jeremy@bitsweat.net http://github.com/rails/rails/commit/7520770c825eab21079dd2b69b1199f138294301 7520770c825eab21079dd2b69b1199f138294301 2008-05-26T01:38:56-07:00 2008-05-26T01:38:56-07:00 Don't require AV::TestCases to have a helper class. Only include the helper class in setup if it hasn't been already. 2ff015e1747a36eabc0c132359da7b7129457cf2 Jeremy Kemper jeremy@bitsweat.net f88267d532ecbfebb66b95863a4875b65507ddf3 Tarmo Tänav tarmo@itech.ee http://github.com/rails/rails/commit/c5d37c0662a65ce9723d668f57b59457e79ee5ca c5d37c0662a65ce9723d668f57b59457e79ee5ca 2008-05-25T16:45:42-07:00 2008-05-25T15:28:56-07:00 Fix tests for postgres 8.3.x Made test_with_limiting_with_custom_select not dependent on database default order. Fixed tests with non-US monetary locale. The monetary type is fixed precision so it should not expect the database to return a float. Signed-off-by: Pratik Naik <pratiknaik@gmail.com> 61c6aba0f774509405b22b41912593f2c1a0e489 Pratik Naik pratiknaik@gmail.com 98dc582742779081e71e697fcdf8d9ae2b421b16 gbuesing gbuesing@gmail.com http://github.com/rails/rails/commit/f88267d532ecbfebb66b95863a4875b65507ddf3 f88267d532ecbfebb66b95863a4875b65507ddf3 2008-05-25T09:56:29-07:00 2008-05-25T09:56:29-07:00 TimeZone#to_s shows offset as GMT instead of UTC, because GMT will be more familiar to end users (see time zone selects used by Windows OS, google.com and yahoo.com.) Reverts [8370] 105575be266671eecb054406772149ab950d8f2e gbuesing gbuesing@gmail.com 6277fd91133a3566333612857510d74de60d67f4 Pratik Naik pratiknaik@gmail.com http://github.com/rails/rails/commit/98dc582742779081e71e697fcdf8d9ae2b421b16 98dc582742779081e71e697fcdf8d9ae2b421b16 2008-05-25T04:29:00-07:00 2008-05-25T04:29:00-07:00 Merge docrails. Signed-off-by: Pratik Naik <pratiknaik@gmail.com> f5680eef86e689a10d0f75434ba6a4e94829e439 Pratik Naik pratiknaik@gmail.com 6cba97d2a449faf21aec9fe9d4434067e414226f Michael Koziarski michael@koziarski.com http://github.com/rails/rails/commit/6277fd91133a3566333612857510d74de60d67f4 6277fd91133a3566333612857510d74de60d67f4 2008-05-23T23:34:59-07:00 2008-05-23T23:34:59-07:00 Fix faulty tests introduced in 8d0b4fa39 50293bf7a9a2ced9d1bf275b6ff5bca160d98fec Michael Koziarski michael@koziarski.com b88ceb7dc8d31bdbea95ab4242bbdee17178cda9 Ryan Bates ryan@railscasts.com http://github.com/rails/rails/commit/6cba97d2a449faf21aec9fe9d4434067e414226f 6cba97d2a449faf21aec9fe9d4434067e414226f 2008-05-23T23:26:13-07:00 2008-05-23T14:57:11-07:00 Create through associations can now work with blocks. Signed-off-by: Michael Koziarski <michael@koziarski.com> [#248 state:resolved] 3c00a108230fe3471882678f362f4c138e6567df Michael Koziarski michael@koziarski.com 8d0b4fa39fab6e5d1e3382b4b137cc47e559b0be Trevor Turk trevorturk@yahoo.com http://github.com/rails/rails/commit/b88ceb7dc8d31bdbea95ab4242bbdee17178cda9 b88ceb7dc8d31bdbea95ab4242bbdee17178cda9 2008-05-23T23:25:33-07:00 2008-05-23T13:51:56-07:00 add failing test case for block-setting of attributes via association Signed-off-by: Michael Koziarski <michael@koziarski.com> e7ddc9db32dea469c192d7703032cc221f5ad2ae Michael Koziarski michael@koziarski.com 5b8d0f134a5766aa1b3d0945b79f04d2bb911c02 josevalim jose.valim@gmail.com http://github.com/rails/rails/commit/8d0b4fa39fab6e5d1e3382b4b137cc47e559b0be 8d0b4fa39fab6e5d1e3382b4b137cc47e559b0be 2008-05-23T22:58:03-07:00 2008-05-23T02:20:13-07:00 Added :select option to has_one and belongs_to, remove unused :order option on belongs_to. Signed-off-by: Michael Koziarski <michael@koziarski.com> [#241 state:resolved] 06a4ff2e8bbb4646082fd627ed6633d79a4ee949 Michael Koziarski michael@koziarski.com 888d5059bdb71e6d034d0c09d7e3b3e235fd8507 Michael Koziarski michael@koziarski.com http://github.com/rails/rails/commit/5b8d0f134a5766aa1b3d0945b79f04d2bb911c02 5b8d0f134a5766aa1b3d0945b79f04d2bb911c02 2008-05-22T14:07:38-07:00 2008-05-22T14:07:38-07:00 Mention partial updates in environment.rb to make it easier for people to opt-in if they know it's safe 0de7973dba32ea5b4ba56e2eb6f58844dee7b4ba Michael Koziarski michael@koziarski.com 1a73e98660b29a2ce9eccd5b0776367a4969a012 Michael Koziarski michael@koziarski.com http://github.com/rails/rails/commit/888d5059bdb71e6d034d0c09d7e3b3e235fd8507 888d5059bdb71e6d034d0c09d7e3b3e235fd8507 2008-05-22T14:00:46-07:00 2008-05-22T00:28:52-07:00 Return Partial Updates to be purely opt in to prevent users from inadvertently corrupting data. e98ab538899d34406d75610553c7100a5046641f Michael Koziarski michael@koziarski.com cff2291df5d1df106ae8cf116655f0703f53f8c3 Kevin Glowacz glowacz@gmail.com http://github.com/rails/rails/commit/1a73e98660b29a2ce9eccd5b0776367a4969a012 1a73e98660b29a2ce9eccd5b0776367a4969a012 2008-05-22T13:10:40-07:00 2008-05-22T12:21:33-07:00 Fix auto_link helper for already linked urls. [#72 state:resolved] Signed-off-by: Pratik Naik <pratiknaik@gmail.com> 11409f89e450878843adb4fcbe3c17f842f2c065 Pratik Naik pratiknaik@gmail.com c2036adf7658f56c924e2a206731ee63b628f34f Frederick Cheung frederick.cheung@gmail.com http://github.com/rails/rails/commit/cff2291df5d1df106ae8cf116655f0703f53f8c3 cff2291df5d1df106ae8cf116655f0703f53f8c3 2008-05-22T04:13:11-07:00 2008-05-22T03:19:10-07:00 Fix failing tests on mysql 4.1 & ruby 1.8.4. [#237 state:resolved] Signed-off-by: Pratik Naik <pratiknaik@gmail.com> 5921ee714a5df59fc5c1bed2ebd55ed9de84250c Pratik Naik pratiknaik@gmail.com 4e084c3d9860c31fca21395c13031f04bb510b15 Lawrence Pit lawrence.pit@gmail.com http://github.com/rails/rails/commit/c2036adf7658f56c924e2a206731ee63b628f34f c2036adf7658f56c924e2a206731ee63b628f34f 2008-05-22T04:06:27-07:00 2008-05-22T04:06:27-07:00 Show rails version when the server starts. [#235 state:resolved] Signed-off-by: Pratik Naik <pratiknaik@gmail.com> 420dd1e2e9fdc3878623a0737db901343f3a6697 Pratik Naik pratiknaik@gmail.com 314e556e6fb7278e37f6105fedbe5fc51f7f848a Ryan Bates ryan@railscasts.com http://github.com/rails/rails/commit/4e084c3d9860c31fca21395c13031f04bb510b15 4e084c3d9860c31fca21395c13031f04bb510b15 2008-05-22T03:56:30-07:00 2008-05-21T16:12:54-07:00 Add Rails.version. [#236 state:resolved] Signed-off-by: Pratik Naik <pratiknaik@gmail.com> 5dfbb4be28b0861d42b0313eb207f87e6a0e8311 Pratik Naik pratiknaik@gmail.com dd9938a44ee3a7bb6c42527a1be6fcec70bf4772 Adam kohnkecomm@Adam-iMac.local http://github.com/rails/rails/commit/314e556e6fb7278e37f6105fedbe5fc51f7f848a 314e556e6fb7278e37f6105fedbe5fc51f7f848a 2008-05-22T03:16:02-07:00 2008-05-21T11:54:24-07:00 Parentheses should be acceptable characters for auto_link_urls. [#234 state:resolved] Signed-off-by: Pratik Naik <pratiknaik@gmail.com> bd9b9a482ef5d79f46a8cc31d9e820a83bd0b867 Pratik Naik pratiknaik@gmail.com 262d23d763c05bbe5f433a99cb9f02e48a8cdd4a Frederick Cheung frederick.cheung@gmail.com http://github.com/rails/rails/commit/dd9938a44ee3a7bb6c42527a1be6fcec70bf4772 dd9938a44ee3a7bb6c42527a1be6fcec70bf4772 2008-05-21T16:02:27-07:00 2008-05-21T13:03:38-07:00 Fix mysql 4.1 incompatibility in the active record schema tests. Signed-off-by: Michael Koziarski <michael@koziarski.com> [#233 state:resolved ] edc43d66fe1088e435f90efd50f5f7166194645b Michael Koziarski michael@koziarski.com 6e3521e6134e7f0d0b27834266e41354290c4e7e Ryan Bates ryan@railscasts.com http://github.com/rails/rails/commit/262d23d763c05bbe5f433a99cb9f02e48a8cdd4a 262d23d763c05bbe5f433a99cb9f02e48a8cdd4a 2008-05-21T12:40:52-07:00 2008-05-21T08:27:20-07:00 ActiveRecord::Base#reload should clear dirty attributes. [#231 state:resolved] Signed-off-by: Pratik Naik <pratiknaik@gmail.com> 3e4c227cabb899746db0d6f23beb15ac7b10e520 Pratik Naik pratiknaik@gmail.com