367942d93bbb99aa2c2f8dc3900cb7c3f2ba4c65 Bradford Folkens bfolkens@gmail.com http://github.com/rails/rails/commit/b0907153da7b8bc8c02692eaadfac3a0853c0e99 b0907153da7b8bc8c02692eaadfac3a0853c0e99 2008-08-27T23:49:55-07:00 2008-07-10T09:37:07-07:00 Reinstate Range#step default argument. [#595 state:resolved] Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net> 830baadf0706da25236adb5f3529af5ac4d06251 Jeremy Kemper jeremy@bitsweat.net 0ed29df6fa704349fd0af0d9521581d6a8eb109c Tarmo Tänav tarmo@itech.ee http://github.com/rails/rails/commit/367942d93bbb99aa2c2f8dc3900cb7c3f2ba4c65 367942d93bbb99aa2c2f8dc3900cb7c3f2ba4c65 2008-08-27T23:32:43-07:00 2008-08-26T09:29:16-07:00 Implement count limit/offset support for has_many associations [#348 state:resolved] Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net> eae0e36f8177e99195865d873665f853106d82db Jeremy Kemper jeremy@bitsweat.net a3a3067adbd578ad9d145f5a148816ec0460a987 Tarmo Tänav tarmo@itech.ee http://github.com/rails/rails/commit/0ed29df6fa704349fd0af0d9521581d6a8eb109c 0ed29df6fa704349fd0af0d9521581d6a8eb109c 2008-08-27T23:30:25-07:00 2008-08-26T09:00:47-07:00 Alias included associations if needed when doing a count [#302 state:resolved] Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net> 14cc195b7e32977d602a6c858d7e5f08cd683dc2 Jeremy Kemper jeremy@bitsweat.net e21ed3e45429cf4a7ee4f5b6b550f457f0c4c313 Tom Lea contrib@tomlea.co.uk http://github.com/rails/rails/commit/a3a3067adbd578ad9d145f5a148816ec0460a987 a3a3067adbd578ad9d145f5a148816ec0460a987 2008-08-27T23:20:36-07:00 2008-08-11T06:12:53-07:00 Dirty: treat two changes resulting in the original value as being unchanged. [#798 state:resolved] Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net> 66bf724ac9cc65473476fbd4305a51fc080fe773 Jeremy Kemper jeremy@bitsweat.net b23b19109050af04e2e1d0f57aee306463f4cbb9 Michael S. Klishin michael@novemberain.com http://github.com/rails/rails/commit/e21ed3e45429cf4a7ee4f5b6b550f457f0c4c313 e21ed3e45429cf4a7ee4f5b6b550f457f0c4c313 2008-08-27T23:03:27-07:00 2008-07-01T01:52:20-07:00 Request#remote_ip handles the uncommon case that REMOTE_ADDR is a comma-separated list. [#523 state:resolved] Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net> 6b70ebc9d1d29a262166545146833d41d5f45651 Jeremy Kemper jeremy@bitsweat.net 9aa3c59b21433528575052a6571c62c343dd1ce7 Lars Kanis kanis@comcard.de http://github.com/rails/rails/commit/b23b19109050af04e2e1d0f57aee306463f4cbb9 b23b19109050af04e2e1d0f57aee306463f4cbb9 2008-08-27T22:51:36-07:00 2008-08-27T22:49:50-07:00 PostgreSQL: fix quote_string for certain old pg drivers. [#94 state:resolved] c9bf6e2cb140443f276bd407e80c34f061b227b5 Jeremy Kemper jeremy@bitsweat.net dabd8c82827c6547f3f1870d9d6f8a3e6c1a830d Jeremy Kemper jeremy@bitsweat.net http://github.com/rails/rails/commit/9aa3c59b21433528575052a6571c62c343dd1ce7 9aa3c59b21433528575052a6571c62c343dd1ce7 2008-08-27T21:33:46-07:00 2008-08-27T21:32:51-07:00 respond_to? passes along splat args to avoid introducing the second arg if it was omitted 96b35c30e39ad565f1f671efbc87a2731ad38cc7 Jeremy Kemper jeremy@bitsweat.net 4d71e99d1fc1f57900288e008d7528c339138cf0 Tim Haines tmhaines@gmail.com http://github.com/rails/rails/commit/dabd8c82827c6547f3f1870d9d6f8a3e6c1a830d dabd8c82827c6547f3f1870d9d6f8a3e6c1a830d 2008-08-27T18:50:57-07:00 2008-08-27T17:57:25-07:00 Add TestUploadFile.content_type= to match Request.UploadedFile [#920 state:resolved] Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net> 0c9cad277e8d4973c40cdc25fefdf750fda3b023 Jeremy Kemper jeremy@bitsweat.net e710902f26a2eed7adb22082067df449b9641d00 Luca Guidi guidi.luca@gmail.com http://github.com/rails/rails/commit/4d71e99d1fc1f57900288e008d7528c339138cf0 4d71e99d1fc1f57900288e008d7528c339138cf0 2008-08-27T07:12:24-07:00 2008-08-27T02:25:20-07:00 Fix Ruby's Time marshaling bug in pre-1.9 versions of Ruby: utc instances are now correctly unmarshaled with a utc zone instead of the system local zone [#900 state:resolved] 2e29eb4eec3bae3dae3971dbc3c67e8488f01146 gbuesing gbuesing@gmail.com b4d13a97cd90cd453119f7deb264fc6c1b190c10 pivotal pivotal@lexington.flood.pivotallabs.com http://github.com/rails/rails/commit/e710902f26a2eed7adb22082067df449b9641d00 e710902f26a2eed7adb22082067df449b9641d00 2008-08-27T02:24:45-07:00 2008-08-26T09:20:24-07:00 Fix two has_one :through errors * Set the association target on assignment; * Reset target to nil on reset, rather than empty array. Signed-off-by: Michael Koziarski <michael@koziarski.com> [#895 state:committed] 10741d1229503cc9a0a4cb8878584c539f73d0b3 Michael Koziarski michael@koziarski.com d92e4613daa34eca0e862d7610bc0ecac3760057 Joshua Peek josh@joshpeek.com http://github.com/rails/rails/commit/b4d13a97cd90cd453119f7deb264fc6c1b190c10 b4d13a97cd90cd453119f7deb264fc6c1b190c10 2008-08-26T05:14:04-07:00 2008-06-14T13:18:55-07:00 Updated bundled TZInfo gem to version 0.3.9 for Ruby 1.9 compat 8c564db1c6de3fa922c97fb36797e9b99d355256 Tarmo Tänav tarmo@itech.ee 3a59bf0f283d89737a5c30dac3fab55ca4d3b9ee Tarmo Tänav tarmo@itech.ee http://github.com/rails/rails/commit/d92e4613daa34eca0e862d7610bc0ecac3760057 d92e4613daa34eca0e862d7610bc0ecac3760057 2008-08-26T04:44:58-07:00 2008-08-26T03:06:49-07:00 Just look at sql_type when testing that the correct database-specific type was used Signed-off-by: Michael Koziarski <michael@koziarski.com> 1f9a1d5ecec387d8f2de3ef2e1d97d2d1e143e16 Tarmo Tänav tarmo@itech.ee 946067ef9395980218c89aee5e6071164d118bec Tarmo Tänav tarmo@itech.ee http://github.com/rails/rails/commit/3a59bf0f283d89737a5c30dac3fab55ca4d3b9ee 3a59bf0f283d89737a5c30dac3fab55ca4d3b9ee 2008-08-26T04:41:13-07:00 2008-07-31T13:59:53-07:00 Added missing fixtures for tests which fail to run independently if run after schema reset Signed-off-by: Michael Koziarski <michael@koziarski.com> 20945ae6f77be7b7d057a3fa7c47a4b5b354e130 Tarmo Tänav tarmo@itech.ee ad51406d7502fea19f2c94e62c68777501ad3e1f Tarmo Tänav tarmo@itech.ee http://github.com/rails/rails/commit/946067ef9395980218c89aee5e6071164d118bec 946067ef9395980218c89aee5e6071164d118bec 2008-08-26T03:04:01-07:00 2008-08-26T02:57:33-07:00 Back to fetching all versions in ruby instead of letting SQL do it as it's difficult to get all databases to convert the text value to a number with the same SQL Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net> 50942de296e718979e9ab82b2d8107cf33a66bfa Jeremy Kemper jeremy@bitsweat.net eab7611618df6335b9772884dd4263a9e0c5040d Jeremy Kemper jeremy@bitsweat.net http://github.com/rails/rails/commit/ad51406d7502fea19f2c94e62c68777501ad3e1f ad51406d7502fea19f2c94e62c68777501ad3e1f 2008-08-26T02:39:00-07:00 2008-08-26T02:38:48-07:00 Include people and readers fixtures to fix test isolation error d93e7659711b0784b51056cbd3032f244a5e7316 Jeremy Kemper jeremy@bitsweat.net eae903aecfb1b67cbccd20e7342ca91dfdd5d538 Jeremy Kemper jeremy@bitsweat.net http://github.com/rails/rails/commit/eab7611618df6335b9772884dd4263a9e0c5040d eab7611618df6335b9772884dd4263a9e0c5040d 2008-08-26T02:17:47-07:00 2008-08-26T02:17:36-07:00 fix tests relying on implicit ordering 1e445ff8cea3812aa69ce7e4dc97055d56d0b710 Jeremy Kemper jeremy@bitsweat.net d093e90f287fff8bbefa25302b83d8f2c3b5fa55 Tarmo Tänav tarmo@itech.ee http://github.com/rails/rails/commit/eae903aecfb1b67cbccd20e7342ca91dfdd5d538 eae903aecfb1b67cbccd20e7342ca91dfdd5d538 2008-08-26T01:50:14-07:00 2008-08-26T01:45:53-07:00 Create mysql binary_fields table with latin1 character set as with utf8 all the limits would have to be divided by 3 to get the expected text types Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net> ff32d88c9bbc27a3fb0f4368d8bc0d53f68d28f9 Jeremy Kemper jeremy@bitsweat.net ac7a0209bbd92b543e50ee6c8641998c7f04c3c1 Jeremy Kemper jeremy@bitsweat.net http://github.com/rails/rails/commit/d093e90f287fff8bbefa25302b83d8f2c3b5fa55 d093e90f287fff8bbefa25302b83d8f2c3b5fa55 2008-08-26T01:50:11-07:00 2008-08-26T01:48:41-07:00 PostgreSQL: pg driver expects nil instead of empty string for missing user/pass b7f9327103dda65facce02e5b302327d68336c27 Jeremy Kemper jeremy@bitsweat.net 813290d87148cbed9d961672440bd8a2bd5ff80b Tarmo Tänav tarmo@itech.ee http://github.com/rails/rails/commit/ac7a0209bbd92b543e50ee6c8641998c7f04c3c1 ac7a0209bbd92b543e50ee6c8641998c7f04c3c1 2008-08-26T00:53:56-07:00 2008-08-26T00:48:46-07:00 Include mysql older than 5.1.23 in the 5.1 series in the list of those that can't handle NULL defaults Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net> 54052e913a30919f02147bc5aca05881a170d28b Jeremy Kemper jeremy@bitsweat.net 8f03357966e0e12803ac78fd321f0fa6347b3293 Jeremy Kemper jeremy@bitsweat.net http://github.com/rails/rails/commit/813290d87148cbed9d961672440bd8a2bd5ff80b 813290d87148cbed9d961672440bd8a2bd5ff80b 2008-08-26T00:10:52-07:00 2008-08-26T00:10:16-07:00 um.. yeah e984a572d13d52e3b3b3a1013be4d1cf83f04b2f Jeremy Kemper jeremy@bitsweat.net 71c53f6433dd7f0f2737e66efc8adc7434577611 Jeremy Kemper jeremy@bitsweat.net http://github.com/rails/rails/commit/8f03357966e0e12803ac78fd321f0fa6347b3293 8f03357966e0e12803ac78fd321f0fa6347b3293 2008-08-26T00:02:59-07:00 2008-08-26T00:02:30-07:00 typo 550009280ba3c57e108d309e5e403dc3be4454fa Jeremy Kemper jeremy@bitsweat.net 698357b9e4b0d03ea8dc7deb636e9772c4b67635 Jeremy Kemper jeremy@bitsweat.net http://github.com/rails/rails/commit/71c53f6433dd7f0f2737e66efc8adc7434577611 71c53f6433dd7f0f2737e66efc8adc7434577611 2008-08-26T00:02:50-07:00 2008-08-26T00:02:22-07:00 fix another ordering failure 83655cbd13d05b1f80e92155c3da32e85bddc29e Jeremy Kemper jeremy@bitsweat.net 84c10b0f1e3331124bfb30cc73e3264473a690b2 Jeremy Kemper jeremy@bitsweat.net http://github.com/rails/rails/commit/698357b9e4b0d03ea8dc7deb636e9772c4b67635 698357b9e4b0d03ea8dc7deb636e9772c4b67635 2008-08-25T23:53:46-07:00 2008-08-25T23:53:31-07:00 fix tests relying on implicit ordering 71b1330913a6caca9b9de04a50be9f6f2e6f113f Jeremy Kemper jeremy@bitsweat.net 7d2b72f3ae6f92e61d131349c4580be0d1dd12ca Tarmo Tänav tarmo@itech.ee http://github.com/rails/rails/commit/84c10b0f1e3331124bfb30cc73e3264473a690b2 84c10b0f1e3331124bfb30cc73e3264473a690b2 2008-08-25T23:25:08-07:00 2008-08-25T23:14:12-07:00 Use DECIMAL instead of INTEGER when casting as mysql doesn't work with just "INTEGER" and other databases don't like "UNSIGNED" which mysql requires And don't mask exceptions. Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net> f0c4646051b89ff3951bec827f741bcd633a2fb1 Jeremy Kemper jeremy@bitsweat.net 6ae0a0557d5e2859e359275b5feebb7e3c13271c Tarmo Tänav tarmo@itech.ee http://github.com/rails/rails/commit/7d2b72f3ae6f92e61d131349c4580be0d1dd12ca 7d2b72f3ae6f92e61d131349c4580be0d1dd12ca 2008-08-25T22:04:11-07:00 2008-08-25T18:55:57-07:00 Cache migrated versions list in Migrator and use it to fetch the latest migrated version name [#845 state:resolved] Also optimized Migrator#current_version class method to fetch only the latest version number and not all of them. With this change no matter how many migrations there are the schema_migrations table is only SELECTed from once. Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net> 04e3d809fb1815e47514565d3a8e6fd635afb7e2 Jeremy Kemper jeremy@bitsweat.net bff0f5fb6d95c8f844fd6e081f827801df20114c Tarmo Tänav tarmo@itech.ee http://github.com/rails/rails/commit/6ae0a0557d5e2859e359275b5feebb7e3c13271c 6ae0a0557d5e2859e359275b5feebb7e3c13271c 2008-08-25T21:25:27-07:00 2008-08-25T17:01:24-07:00 Load the first and not the last has_one result when doing join-based eager loading This matters when the has_one is defined with an order in which case there is an expectation that the first one will be loaded. [#904 state:resolved] Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net> e4390ed602a73ddf9727bdfcdaf1d5d5f63bf199 Jeremy Kemper jeremy@bitsweat.net fdeeeaea61bb34040f8da03afa9876171db4b17e Frederick Cheung frederick.cheung@gmail.com http://github.com/rails/rails/commit/bff0f5fb6d95c8f844fd6e081f827801df20114c bff0f5fb6d95c8f844fd6e081f827801df20114c 2008-08-25T21:25:24-07:00 2008-08-25T15:20:10-07:00 Implement old-skool eagerloading for has_one :through Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net> c4f0a70ce9fee628c896ab2777dfb41412734807 Jeremy Kemper jeremy@bitsweat.net f47767696479391fbdb967f1321478d4c338cecc Frederick Cheung frederick.cheung@gmail.com http://github.com/rails/rails/commit/fdeeeaea61bb34040f8da03afa9876171db4b17e fdeeeaea61bb34040f8da03afa9876171db4b17e 2008-08-25T20:50:39-07:00 2008-08-25T14:36:19-07:00 Fix preloading of has_one through associations [#903 state:resolved] Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net> f5b28312b3db3e6ddbc76e08a3be6dba54442a67 Jeremy Kemper jeremy@bitsweat.net 11d9669038a1aaa0107b9c16b36a38772b68c716 052875800e5d4f0e85eb34abd606e1bc600f5b83 Michael Koziarski michael@koziarski.com http://github.com/rails/rails/commit/f47767696479391fbdb967f1321478d4c338cecc f47767696479391fbdb967f1321478d4c338cecc 2008-08-25T01:03:53-07:00 2008-08-25T01:03:53-07:00 Merge commit 'tarmo/2-1-stable' into upgrade efda7ffa08708dffaa384b740060729b84d6e81f Michael Koziarski michael@koziarski.com 482f6aa59a2b26101f0e2dd539daa6cf999774ee Tarmo Tänav tarmo@itech.ee http://github.com/rails/rails/commit/052875800e5d4f0e85eb34abd606e1bc600f5b83 052875800e5d4f0e85eb34abd606e1bc600f5b83 2008-08-24T22:40:20-07:00 2008-08-24T22:40:01-07:00 Fixed merge mistake for 38a0d5c0c7a37e22f9376c7cc363f4cf4f19a3d4 e305c179f0da3c9c80eaf4713951796e3dc14918 Tarmo Tänav tarmo@itech.ee