f9f1ab4e3ddeacadf2a7bce021d742f08f67905f Hongli Lai (Phusion hongli@phusion.nl http://github.com/rails/rails/commit/c111522d5b8cd108756240a0348d515d6acee46c c111522d5b8cd108756240a0348d515d6acee46c 2008-08-26T07:28:41-07:00 2008-08-26T06:59:03-07:00 The 'rails' command was broken by the last commit. Fix that. Signed-off-by: Michael Koziarski <michael@koziarski.com> 22d11cb429aae9fbe439beb9435966fcdce5877b Michael Koziarski michael@koziarski.com eec5eb2e444b2b42206e2d5ccfe7f30306c308cb Hongli Lai (Phusion hongli@phusion.nl http://github.com/rails/rails/commit/f9f1ab4e3ddeacadf2a7bce021d742f08f67905f f9f1ab4e3ddeacadf2a7bce021d742f08f67905f 2008-08-26T05:30:19-07:00 2008-07-10T04:21:08-07:00 When an unexpected exception is caught, tell the administrator to read the log file for more information about the error. This should make things less confusing for developers who are new to Rails. Signed-off-by: Michael Koziarski <michael@koziarski.com> 994a4d44905a910bc70d663a7e89860d799c2e30 Michael Koziarski michael@koziarski.com 3dfecfe77347421fbb54be70a5a84eb47c30acb6 Tarmo Tänav tarmo@itech.ee http://github.com/rails/rails/commit/eec5eb2e444b2b42206e2d5ccfe7f30306c308cb eec5eb2e444b2b42206e2d5ccfe7f30306c308cb 2008-08-26T04:16:55-07:00 2008-08-26T04:15:44-07:00 Fix yet another implicit order dependant test Signed-off-by: Michael Koziarski <michael@koziarski.com> 4b10b7bac08aac3b4eebb071afa2b752667d3d58 Michael Koziarski michael@koziarski.com bb557b44e9b0dc0dbb5ca7a4a8645f4af14f8021 Tarmo Tänav tarmo@itech.ee http://github.com/rails/rails/commit/3dfecfe77347421fbb54be70a5a84eb47c30acb6 3dfecfe77347421fbb54be70a5a84eb47c30acb6 2008-08-26T03:45:04-07:00 2008-08-26T03:41:41-07:00 Print the queries that were executed if assert_queries fails d560c78e54e249ed31e0854c0475eef212c98ab6 Michael Koziarski michael@koziarski.com 86bf279b8912302a019c0ce0e47252e8e825c11e Michael Koziarski michael@koziarski.com http://github.com/rails/rails/commit/bb557b44e9b0dc0dbb5ca7a4a8645f4af14f8021 bb557b44e9b0dc0dbb5ca7a4a8645f4af14f8021 2008-08-26T03:21:48-07:00 2008-08-26T03:21:48-07:00 Be more careful 5c29e079e1d6572e8c3d9892f035100ea5504102 Michael Koziarski michael@koziarski.com ce3c76de7c0deda08a5ed0e064b8d37c26b60cfc Michael Koziarski michael@koziarski.com http://github.com/rails/rails/commit/86bf279b8912302a019c0ce0e47252e8e825c11e 86bf279b8912302a019c0ce0e47252e8e825c11e 2008-08-26T03:14:07-07:00 2008-08-26T03:14:07-07:00 Re enable CI for postgresql 6c0ebe8b035b7605a84a36e84498d3cb8b4f1fa3 Michael Koziarski michael@koziarski.com e06878c22bad83c234f5c51644c45629de876b25 Tarmo Tänav tarmo@itech.ee http://github.com/rails/rails/commit/ce3c76de7c0deda08a5ed0e064b8d37c26b60cfc ce3c76de7c0deda08a5ed0e064b8d37c26b60cfc 2008-08-26T03:11:01-07:00 2008-08-26T03:06:49-07:00 Just look at sql_type when testing that the correct database-specific type was used Signed-off-by: Michael Koziarski <michael@koziarski.com> ba758f79a30423cf6eb499b414f79919de92ed81 Michael Koziarski michael@koziarski.com 00d2165f748bc3d7c235daa959c54266a0a283db ab1e82b8f7279301e4363decdef84719f9304443 Jeremy Kemper jeremy@bitsweat.net http://github.com/rails/rails/commit/e06878c22bad83c234f5c51644c45629de876b25 e06878c22bad83c234f5c51644c45629de876b25 2008-08-26T03:04:14-07:00 2008-08-26T03:04:14-07:00 Merge branch 'master' of git@github.com:rails/rails a6285cef4ef7d39d231dcbf71df5a773fcb30e89 Jeremy Kemper jeremy@bitsweat.net 973c0ef26d94b5cf2bd29dce177357d5905be211 Tarmo Tänav tarmo@itech.ee http://github.com/rails/rails/commit/00d2165f748bc3d7c235daa959c54266a0a283db 00d2165f748bc3d7c235daa959c54266a0a283db 2008-08-26T03:00:36-07:00 2008-08-26T02:57:33-07:00 Back to fetching all versions in ruby instead of letting SQL do it as it's difficult to get all databases to convert the text value to a number with the same SQL Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net> 449e11b2b8669c20807917fade197da0ef20ae76 Jeremy Kemper jeremy@bitsweat.net 0c7bbc72fc043ad5debbff34da81f3d68f516d3f Jeremy Kemper jeremy@bitsweat.net http://github.com/rails/rails/commit/ab1e82b8f7279301e4363decdef84719f9304443 ab1e82b8f7279301e4363decdef84719f9304443 2008-08-26T02:38:48-07:00 2008-08-26T02:38:48-07:00 Include people and readers fixtures to fix test isolation error 27d609dad4dabcbb2132b355f971ce3c002a3a9c Jeremy Kemper jeremy@bitsweat.net b319e69ecb06692995664dba263813d99bc2145f Jeremy Kemper jeremy@bitsweat.net http://github.com/rails/rails/commit/0c7bbc72fc043ad5debbff34da81f3d68f516d3f 0c7bbc72fc043ad5debbff34da81f3d68f516d3f 2008-08-26T02:17:36-07:00 2008-08-26T02:17:36-07:00 fix tests relying on implicit ordering f0857fdc466f0064370ae00e1cd53845e879f8d6 Jeremy Kemper jeremy@bitsweat.net d2d739fd0687bf94ee42b69c413a9077b9cdbff7 Jeremy Kemper jeremy@bitsweat.net http://github.com/rails/rails/commit/b319e69ecb06692995664dba263813d99bc2145f b319e69ecb06692995664dba263813d99bc2145f 2008-08-26T01:54:14-07:00 2008-08-26T01:48:41-07:00 PostgreSQL: pg driver expects nil instead of empty string for missing user/pass a50922c75cd6ea9e86b43fea5fff80ce1325b306 Jeremy Kemper jeremy@bitsweat.net 973c0ef26d94b5cf2bd29dce177357d5905be211 11612bf956f4d90e60f0aff6561fa8566cd2bd88 Jeremy Kemper jeremy@bitsweat.net http://github.com/rails/rails/commit/d2d739fd0687bf94ee42b69c413a9077b9cdbff7 d2d739fd0687bf94ee42b69c413a9077b9cdbff7 2008-08-26T01:50:32-07:00 2008-08-26T01:50:32-07:00 Merge branch 'master' of git@github.com:rails/rails 292e2eafec3802b1eae4e31c4b101dae7fdf1320 Jeremy Kemper jeremy@bitsweat.net fa795ccfade59c4bbab91ada3bb34e5fbfac448c Tarmo Tänav tarmo@itech.ee http://github.com/rails/rails/commit/973c0ef26d94b5cf2bd29dce177357d5905be211 973c0ef26d94b5cf2bd29dce177357d5905be211 2008-08-26T01:49:19-07:00 2008-08-26T01:45:53-07:00 Create mysql binary_fields table with latin1 character set as with utf8 all the limits would have to be divided by 3 to get the expected text types Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net> 83aa4c5b927fdbbf7598dd013149148ec5275043 Jeremy Kemper jeremy@bitsweat.net fa795ccfade59c4bbab91ada3bb34e5fbfac448c 289e3b90728cacdb96d61e721b30de566a0a8134 Jeremy Kemper jeremy@bitsweat.net http://github.com/rails/rails/commit/11612bf956f4d90e60f0aff6561fa8566cd2bd88 11612bf956f4d90e60f0aff6561fa8566cd2bd88 2008-08-26T00:55:25-07:00 2008-08-26T00:55:25-07:00 Merge branch 'master' of git@github.com:rails/rails ca539ce5ce22a62ba5ee9ccd05854bcf22428deb Jeremy Kemper jeremy@bitsweat.net 52e15abbedab9ef6f3db03ef39fe5cbab9c3ddde Tarmo Tänav tarmo@itech.ee http://github.com/rails/rails/commit/fa795ccfade59c4bbab91ada3bb34e5fbfac448c fa795ccfade59c4bbab91ada3bb34e5fbfac448c 2008-08-26T00:53:19-07:00 2008-08-26T00:48:46-07:00 Include mysql older than 5.1.23 in the 5.1 series in the list of those that can't handle NULL defaults Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net> 46dffe62ae82245df4449d8eb25049f9e8263652 Jeremy Kemper jeremy@bitsweat.net 52e15abbedab9ef6f3db03ef39fe5cbab9c3ddde Chad Woolley thewoolleyman@gmail.com http://github.com/rails/rails/commit/289e3b90728cacdb96d61e721b30de566a0a8134 289e3b90728cacdb96d61e721b30de566a0a8134 2008-08-26T00:40:19-07:00 2008-08-25T18:49:45-07:00 use double quotes 8b7c09f91901681d48413f167e9db4168620b012 Michael Koziarski michael@koziarski.com 6d66ddaa34ec011a4a20ca5d3f7f695b1a843734 Jeremy Kemper jeremy@bitsweat.net http://github.com/rails/rails/commit/52e15abbedab9ef6f3db03ef39fe5cbab9c3ddde 52e15abbedab9ef6f3db03ef39fe5cbab9c3ddde 2008-08-26T00:10:16-07:00 2008-08-26T00:10:16-07:00 um.. yeah 62f6cc7dadd5bf34276714c93711695503d0e42a Jeremy Kemper jeremy@bitsweat.net 842d55cb16eac7e48660ecd4df5ec1daf946f4d1 Jeremy Kemper jeremy@bitsweat.net http://github.com/rails/rails/commit/6d66ddaa34ec011a4a20ca5d3f7f695b1a843734 6d66ddaa34ec011a4a20ca5d3f7f695b1a843734 2008-08-26T00:02:30-07:00 2008-08-26T00:02:30-07:00 typo 457faec2011659f759302ddf0b29b0135954cce8 Jeremy Kemper jeremy@bitsweat.net ca48da6300ff0b49ae4125dc582f3c4666481005 Jeremy Kemper jeremy@bitsweat.net http://github.com/rails/rails/commit/842d55cb16eac7e48660ecd4df5ec1daf946f4d1 842d55cb16eac7e48660ecd4df5ec1daf946f4d1 2008-08-26T00:02:22-07:00 2008-08-26T00:02:22-07:00 fix another ordering failure cede72b9b0f2b2410189dcc0c05c2ed918401b90 Jeremy Kemper jeremy@bitsweat.net 1092c181b5568d06e84f6a3253aaca81c02a2b2c Jeremy Kemper jeremy@bitsweat.net http://github.com/rails/rails/commit/ca48da6300ff0b49ae4125dc582f3c4666481005 ca48da6300ff0b49ae4125dc582f3c4666481005 2008-08-25T23:53:31-07:00 2008-08-25T23:53:31-07:00 fix tests relying on implicit ordering 485b2ea5137e5d30633104a1a1b769c576e9fc0a Jeremy Kemper jeremy@bitsweat.net 143f5fbb21b6dfcaab63d67b44afd922dab9dcf5 Josh Susser josh@hasmanythrough.com http://github.com/rails/rails/commit/1092c181b5568d06e84f6a3253aaca81c02a2b2c 1092c181b5568d06e84f6a3253aaca81c02a2b2c 2008-08-25T23:33:16-07:00 2008-08-25T21:28:53-07:00 add dynamic finder bang version to raise RecordNotFound [#905 state:resolved] Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net> 3fb246c856bbefddf8fc1e635eb765c540619c41 Jeremy Kemper jeremy@bitsweat.net 3beed9cdb7cf2cf75fb043b72ca99cc23fc11556 Josh Susser josh@hasmanythrough.com http://github.com/rails/rails/commit/143f5fbb21b6dfcaab63d67b44afd922dab9dcf5 143f5fbb21b6dfcaab63d67b44afd922dab9dcf5 2008-08-25T23:32:20-07:00 2008-08-25T19:32:19-07:00 refactor dynamic finder name matching into its own class Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net> 25551d412c07795edc2782035228f430c0290927 Jeremy Kemper jeremy@bitsweat.net 77b003fb615a1a0b197af9fbb9066622bf489b57 Jeremy Kemper jeremy@bitsweat.net http://github.com/rails/rails/commit/3beed9cdb7cf2cf75fb043b72ca99cc23fc11556 3beed9cdb7cf2cf75fb043b72ca99cc23fc11556 2008-08-25T23:32:03-07:00 2008-08-25T23:32:03-07:00 ensure tests load sibling Active Support instead of a gem d469f394875e3ca2257ef84df8886696784ebb05 Jeremy Kemper jeremy@bitsweat.net 3d2ac918b987ef0cff34f6a7fdd20926b7a9e5d9 Tarmo Tänav tarmo@itech.ee http://github.com/rails/rails/commit/77b003fb615a1a0b197af9fbb9066622bf489b57 77b003fb615a1a0b197af9fbb9066622bf489b57 2008-08-25T23:23:34-07:00 2008-08-25T23:14:12-07:00 Use DECIMAL instead of INTEGER when casting as mysql doesn't work with just "INTEGER" and other databases don't like "UNSIGNED" which mysql requires And don't mask exceptions. Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net> bdef1e65031ff67d7d83147fdd95c69d54932e37 Jeremy Kemper jeremy@bitsweat.net 4bcd64c9e93af2f13dc7309cd76bb764e4d7d23d Tarmo Tänav tarmo@itech.ee http://github.com/rails/rails/commit/3d2ac918b987ef0cff34f6a7fdd20926b7a9e5d9 3d2ac918b987ef0cff34f6a7fdd20926b7a9e5d9 2008-08-25T22:03:47-07:00 2008-08-25T18:55:57-07:00 Cache migrated versions list in Migrator and use it to fetch the latest migrated version name [#845 state:resolved] Also optimized Migrator#current_version class method to fetch only the latest version number and not all of them. With this change no matter how many migrations there are the schema_migrations table is only SELECTed from once. Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net> c59dd78994dd9892c0707947d4e02d6c79b2556d Jeremy Kemper jeremy@bitsweat.net a445cdd8840c4e99c40c6d5b15ab380d39a56be3 Jeremy Kemper jeremy@bitsweat.net http://github.com/rails/rails/commit/4bcd64c9e93af2f13dc7309cd76bb764e4d7d23d 4bcd64c9e93af2f13dc7309cd76bb764e4d7d23d 2008-08-25T22:01:02-07:00 2008-08-25T22:01:02-07:00 Ruby 1.9 compat: switch profile_options to superclass_delegating_accessor 946767471cef142651e38f9472c60fd9964040e5 Jeremy Kemper jeremy@bitsweat.net 2dbda11945507a0541d61d13b8c564121c1cd362 Tarmo Tänav tarmo@itech.ee http://github.com/rails/rails/commit/a445cdd8840c4e99c40c6d5b15ab380d39a56be3 a445cdd8840c4e99c40c6d5b15ab380d39a56be3 2008-08-25T21:23:35-07:00 2008-08-25T17:01:24-07:00 Load the first and not the last has_one result when doing join-based eager loading This matters when the has_one is defined with an order in which case there is an expectation that the first one will be loaded. [#904 state:resolved] Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net> 1d9e7ee98e9607fd635f1743fa6c6bf507ba297e Jeremy Kemper jeremy@bitsweat.net 172606e21f54fea39af68ede5f55a43deaf3ac68 Frederick Cheung frederick.cheung@gmail.com http://github.com/rails/rails/commit/2dbda11945507a0541d61d13b8c564121c1cd362 2dbda11945507a0541d61d13b8c564121c1cd362 2008-08-25T21:23:15-07:00 2008-08-25T15:20:10-07:00 Implement old-skool eagerloading for has_one :through Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net> fb388c1f8de151e890045146d11dbfe0849bd0fa Jeremy Kemper jeremy@bitsweat.net b7a37b742c0abd1df8ea48cc82f76385cc0c41ea Jeremy Kemper jeremy@bitsweat.net http://github.com/rails/rails/commit/172606e21f54fea39af68ede5f55a43deaf3ac68 172606e21f54fea39af68ede5f55a43deaf3ac68 2008-08-25T21:22:34-07:00 2008-08-25T21:22:34-07:00 Harmonize framework require strategy. Don't add self to load path since Rails initializer and RubyGems handle it. 19c336e1ebc76a53a4d15b2573d7cce6fbad74c8 Jeremy Kemper jeremy@bitsweat.net