9cf6b1b15e6335134a5af5d9d6296f8d9242e005 Frederick Cheung frederick.cheung@gmail.com http://github.com/rails/rails/commit/c9ab7098be7bdd748c0f4a49c8ef015b4aad3108 c9ab7098be7bdd748c0f4a49c8ef015b4aad3108 2008-12-18T11:19:36-08:00 2008-12-18T11:07:55-08:00 Ensure :include checks joins when determining if it can preload [#528 state:resolved] aedc907d37039a5cbf8dca55f6f7a6f84a37c0c3 Pratik Naik pratiknaik@gmail.com 707d0dd3e1e8df7771073670e4257d933d2818f9 Emilio Tagua miloops@gmail.com http://github.com/rails/rails/commit/9cf6b1b15e6335134a5af5d9d6296f8d9242e005 9cf6b1b15e6335134a5af5d9d6296f8d9242e005 2008-12-18T11:19:36-08:00 2008-12-02T08:47:53-08:00 Add missing model files so tests can run isolated [#1506 state:resolved] Signed-off-by: Frederick Cheung <frederick.cheung@gmail.com> 7e3668de56ac5dfaa7902bf57b42329467c0d1a0 Pratik Naik pratiknaik@gmail.com 428e77bf0fcee4369cb8d94011141f791b8e2ba9 Frederick Cheung frederick.cheung@gmail.com http://github.com/rails/rails/commit/707d0dd3e1e8df7771073670e4257d933d2818f9 707d0dd3e1e8df7771073670e4257d933d2818f9 2008-12-18T11:19:35-08:00 2008-12-17T15:39:09-08:00 Fix preloading of belongs_to with null foreign key generating useless query [#1027 state:resolved] 97ac33fde3f7e4004d607911ad1b9a5437ddf037 Pratik Naik pratiknaik@gmail.com a9fde9a2abd6a6505d5fd197ad9640470d8df9be Frederick Cheung frederick.cheung@gmail.com http://github.com/rails/rails/commit/428e77bf0fcee4369cb8d94011141f791b8e2ba9 428e77bf0fcee4369cb8d94011141f791b8e2ba9 2008-12-18T11:19:35-08:00 2008-12-17T15:37:55-08:00 Make exceptions raise from find_by_foo! have a more helpful message [#1567 state:resolved] 86b37e8e7b7b75b8dec2afe0bbcbc5b0a5b8045c Pratik Naik pratiknaik@gmail.com 3b35366d5df8c8d8a7b216c42dd96b0cfa38fee4 Joshua Peek josh@joshpeek.com http://github.com/rails/rails/commit/a9fde9a2abd6a6505d5fd197ad9640470d8df9be a9fde9a2abd6a6505d5fd197ad9640470d8df9be 2008-12-18T11:14:09-08:00 2008-12-18T11:14:09-08:00 Cleanup dispatch path f115acdeed96396d52a35a875ce5270585db3bc5 Joshua Peek josh@joshpeek.com 2e22c7fda00f78db79cb2dcc79495c085035240d Joshua Peek josh@joshpeek.com http://github.com/rails/rails/commit/3b35366d5df8c8d8a7b216c42dd96b0cfa38fee4 3b35366d5df8c8d8a7b216c42dd96b0cfa38fee4 2008-12-18T10:57:37-08:00 2008-12-18T10:57:37-08:00 Use more generic test env flag 0632280c179df20797a3e59ec7e4df7e315aff06 Joshua Peek josh@joshpeek.com 2eb2ec9e635c740684673495ed547d1c0769038d Joshua Peek josh@joshpeek.com http://github.com/rails/rails/commit/2e22c7fda00f78db79cb2dcc79495c085035240d 2e22c7fda00f78db79cb2dcc79495c085035240d 2008-12-18T10:56:18-08:00 2008-12-18T10:56:18-08:00 Conditionally inject session middleware instead of using session management 92c18edbcab2e2d0733b77604838fe7ee3e53cd5 Joshua Peek josh@joshpeek.com 3ff6b00ee30d0961f57e3c4b64ec8ff0155aaf2d Joshua Peek josh@joshpeek.com http://github.com/rails/rails/commit/2eb2ec9e635c740684673495ed547d1c0769038d 2eb2ec9e635c740684673495ed547d1c0769038d 2008-12-18T10:00:54-08:00 2008-12-18T10:00:54-08:00 Move gaint lock into middleware 55c28e8c3d11823ad15e9815039d8239afe7287a Joshua Peek josh@joshpeek.com 33f76bb25a973a4707437064e2f963c521413fcb Lourens Naude lourens@methodmissing.com http://github.com/rails/rails/commit/3ff6b00ee30d0961f57e3c4b64ec8ff0155aaf2d 3ff6b00ee30d0961f57e3c4b64ec8ff0155aaf2d 2008-12-18T09:33:53-08:00 2008-12-18T09:33:53-08:00 Persistent session identifier support for CookieSessionStore and API compat. with the server side stores [#1591 state:resolved] Signed-off-by: Joshua Peek <josh@joshpeek.com> e8adf40ecf077c4216ee36bcf9cc20f5ef071952 Joshua Peek josh@joshpeek.com f23c2796ee4a217d48bcefbc0056aaab6b1b64fa Brady Bouchard brady@lunardawn.ca http://github.com/rails/rails/commit/33f76bb25a973a4707437064e2f963c521413fcb 33f76bb25a973a4707437064e2f963c521413fcb 2008-12-17T08:23:59-08:00 2008-12-17T08:23:59-08:00 Ensure error file is sent with a 'text/html' content type [#1478 state:resolved] Signed-off-by: Joshua Peek <josh@joshpeek.com> 9f3ca41648223d9e5f9e114938a7503767a7285a Joshua Peek josh@joshpeek.com 175cb7a963a31cf9caecdc40331df4cdc5aa86e2 Joshua Peek josh@joshpeek.com http://github.com/rails/rails/commit/f23c2796ee4a217d48bcefbc0056aaab6b1b64fa f23c2796ee4a217d48bcefbc0056aaab6b1b64fa 2008-12-17T08:20:19-08:00 2008-12-17T08:20:19-08:00 When checking for the wrong routing method, ensure the environment is passed to recognize optimize [#1406 state:resolved] 8809925d8ae65ef2828c96ad84719d153a2748ac Joshua Peek josh@joshpeek.com 61a41154f7d50099da371e0d2f22fd25ab9113c2 Joshua Peek josh@joshpeek.com http://github.com/rails/rails/commit/175cb7a963a31cf9caecdc40331df4cdc5aa86e2 175cb7a963a31cf9caecdc40331df4cdc5aa86e2 2008-12-17T08:10:24-08:00 2008-12-17T08:10:24-08:00 Fix metal tests 4d81b6cf1d77e28a35c9c2dd254a164fd1df2331 Joshua Peek josh@joshpeek.com 97a178bfa4d5101dca73ae931cc9c77385d8c97e Joshua Peek josh@joshpeek.com http://github.com/rails/rails/commit/61a41154f7d50099da371e0d2f22fd25ab9113c2 61a41154f7d50099da371e0d2f22fd25ab9113c2 2008-12-17T07:53:56-08:00 2008-12-17T07:53:56-08:00 Make generated Metal bits a pure rack endpoint application (not middleware) Instead of calling super to pass the request on, return a 404. The modified app looks like this: # app/metal/poller.rb class Poller def self.call(env) if env["PATH_INFO"] =~ /^\/poller/ [200, {"Content-Type" => "text/html"}, "Hello, World!"] else [404, {"Content-Type" => "text/html"}, "Not Found"] end end end But you aren't locked in to just Rails: # app/metal/api.rb require 'sinatra' Sinatra::Application.default_options.merge!(:run => false, :env => :production) Api = Sinatra.application unless defined? Api get '/interesting/new/ideas' do 'Hello Sinatra!' end 257314af12fd4b66473752159b14e288af9864ee Joshua Peek josh@joshpeek.com 1bcfce0130d4fa13d56f58d5cd5e0f5de33e015f Jesse Newland jnewland@gmail.com http://github.com/rails/rails/commit/97a178bfa4d5101dca73ae931cc9c77385d8c97e 97a178bfa4d5101dca73ae931cc9c77385d8c97e 2008-12-17T06:59:47-08:00 2008-12-17T06:21:20-08:00 Decorate responses from Rack Middleware and Rails Metal for the purposes of integration testing. A test for the following Metal: class Poller < Rails::Rack::Metal def call(env) if env["PATH_INFO"] =~ /^\/poller/ [200, {"Content-Type" => "text/plain"}, "Hello World!"] else super end end end might be tested like so: class PollerTest < ActionController::IntegrationTest test "poller returns hello world" do get "/poller" assert_response 200 assert_response :success assert_response :ok assert_equal "Hello World!", response.body end end [#1588 state:committed] Signed-off-by: David Heinemeier Hansson <david@loudthinking.com> 0b7989afbc55ccdb4654de8c6b7eeb577de4ded3 David Heinemeier Hansson david@loudthinking.com 246b582ddf3c2ec4939be9d55018d97066d7fac8 Joshua Peek josh@joshpeek.com http://github.com/rails/rails/commit/1bcfce0130d4fa13d56f58d5cd5e0f5de33e015f 1bcfce0130d4fa13d56f58d5cd5e0f5de33e015f 2008-12-16T18:21:27-08:00 2008-12-16T18:21:27-08:00 Remove set_cookie hack from rack response since we dont use cgi sessions anymore 0554fb51e39984a7554d4751a3ab4e4b53cca01e Joshua Peek josh@joshpeek.com ec1bd987054479d279a181eec26827ec694a61cd Joshua Peek josh@joshpeek.com http://github.com/rails/rails/commit/246b582ddf3c2ec4939be9d55018d97066d7fac8 246b582ddf3c2ec4939be9d55018d97066d7fac8 2008-12-16T17:56:09-08:00 2008-12-16T17:56:09-08:00 Remove CGI::Session memory leak patch e3b6f0f657326e8c3c43c05a5bd631d0156feb30 Joshua Peek josh@joshpeek.com 8c3a54366435eebc2c8aa63b63e1349ce74a7b38 Joshua Peek josh@joshpeek.com http://github.com/rails/rails/commit/ec1bd987054479d279a181eec26827ec694a61cd ec1bd987054479d279a181eec26827ec694a61cd 2008-12-16T14:28:39-08:00 2008-12-16T14:28:39-08:00 Session Fixation tests have been rolled into the session cookie tests 485cab9263d7f338b102a506fdda5556ae6d3235 Joshua Peek josh@joshpeek.com c4023cbe206415cf3ca1ca92cd9980a4aa4aed00 Joshua Peek josh@joshpeek.com http://github.com/rails/rails/commit/8c3a54366435eebc2c8aa63b63e1349ce74a7b38 8c3a54366435eebc2c8aa63b63e1349ce74a7b38 2008-12-16T11:15:06-08:00 2008-12-16T11:11:51-08:00 Introduce Rails Metal # app/metal/poller.rb class Poller < Rails::Rack::Metal def call(env) if env["PATH_INFO"] =~ /^\/poller/ [200, {"Content-Type" => "application/json"}, Message.recent.to_json] else super end end end * There is a generator to help you get started `script/generate metal poller` * Also, metal bits can be ran standalone with rackup `rackup app/metal/poller.rb` 547451f6c639994a948f8cba6505022458aedeac Joshua Peek josh@joshpeek.com 46c7dd234807b2d24c8c742acb18c633b69e385d Daniel Luz dev@mernen.com http://github.com/rails/rails/commit/c4023cbe206415cf3ca1ca92cd9980a4aa4aed00 c4023cbe206415cf3ca1ca92cd9980a4aa4aed00 2008-12-16T05:34:02-08:00 2008-11-30T20:58:39-08:00 Update documentation for default_scope Signed-off-by: David Heinemeier Hansson <david@loudthinking.com> 21ad99adbfb78ad36c93cc693c5e1028a6ac15fa David Heinemeier Hansson david@loudthinking.com 9e2b4a10f7f091868b3c3701efb4c04048455706 Xavier Noria fxn@hashref.com http://github.com/rails/rails/commit/46c7dd234807b2d24c8c742acb18c633b69e385d 46c7dd234807b2d24c8c742acb18c633b69e385d 2008-12-16T05:33:32-08:00 2008-12-09T15:53:32-08:00 normalize author names in changelogs [#1495 state:committed] Signed-off-by: David Heinemeier Hansson <david@loudthinking.com> 3a048c3396ae99d7846892ea520a900bfe6bc495 David Heinemeier Hansson david@loudthinking.com 7c090509994faa19fcbd534aa78324b70b659627 Hongli Lai (Phusion hongli@phusion.nl http://github.com/rails/rails/commit/9e2b4a10f7f091868b3c3701efb4c04048455706 9e2b4a10f7f091868b3c3701efb4c04048455706 2008-12-16T03:30:28-08:00 2008-12-15T12:36:33-08:00 Do not output an ETag header if response body is blank or when sending files with send_file(... :xsendfile => true) [#1578 state:committed] Signed-off-by: David Heinemeier Hansson <david@loudthinking.com> b7bfb7a80b78a22e5ab562a7d26c3d01abc7631d David Heinemeier Hansson david@loudthinking.com 9a733f6c640cb3c4d474ecf44dd62ab73e351fd5 Joshua Peek josh@joshpeek.com http://github.com/rails/rails/commit/7c090509994faa19fcbd534aa78324b70b659627 7c090509994faa19fcbd534aa78324b70b659627 2008-12-15T23:00:48-08:00 2008-12-15T23:00:48-08:00 Lazy load flash access 3ad666fb1b59de3d5fd06744729e4d77e8347c23 Joshua Peek josh@joshpeek.com 95c839bd2aca1576a33a6503f0dd67266d53a353 Joshua Peek josh@joshpeek.com http://github.com/rails/rails/commit/9a733f6c640cb3c4d474ecf44dd62ab73e351fd5 9a733f6c640cb3c4d474ecf44dd62ab73e351fd5 2008-12-15T22:04:04-08:00 2008-12-15T22:04:04-08:00 Don't write nil values to default session options hash 89916886926fd9e9dab2f9c988c3ff9f931d98eb Joshua Peek josh@joshpeek.com 89056885b030b981193d73ebde56cf60829a924c Joshua Peek josh@joshpeek.com http://github.com/rails/rails/commit/95c839bd2aca1576a33a6503f0dd67266d53a353 95c839bd2aca1576a33a6503f0dd67266d53a353 2008-12-15T18:43:01-08:00 2008-12-15T18:33:21-08:00 Session objects are always a hash, so we need to ensure a flash hash is always assigned to the session b25cf2eb1e05c33449b06701b4e3a34e823507da Joshua Peek josh@joshpeek.com 19be3d35b38b6685789d8d343617d465a3652717 43ac42c46a462e1453b1b97da00e11bff7bba55d Jeremy Kemper jeremy@bitsweat.net http://github.com/rails/rails/commit/89056885b030b981193d73ebde56cf60829a924c 89056885b030b981193d73ebde56cf60829a924c 2008-12-15T18:22:35-08:00 2008-12-15T18:22:35-08:00 Merge branch 'master' of git@github.com:rails/rails 9d432f7226754115ac4d2ef8aa1134221ff294bb Jeremy Kemper jeremy@bitsweat.net 0d48408dccd2b69754310cb3702ddfe705dbcd12 Jeremy Kemper jeremy@bitsweat.net http://github.com/rails/rails/commit/19be3d35b38b6685789d8d343617d465a3652717 19be3d35b38b6685789d8d343617d465a3652717 2008-12-15T18:20:18-08:00 2008-12-15T18:20:18-08:00 Revert "Make constantize look into ancestors" [#410 state:open] This reverts commit 262fef7ed57520b857605a0105fe7ba9265654f6. a9556ab5a6c6c4972084287757be2cfc905dbfe7 Jeremy Kemper jeremy@bitsweat.net ed708307137c811d14e5fd2cb4ea550add381a82 Joshua Peek josh@joshpeek.com http://github.com/rails/rails/commit/43ac42c46a462e1453b1b97da00e11bff7bba55d 43ac42c46a462e1453b1b97da00e11bff7bba55d 2008-12-15T17:25:31-08:00 2008-12-15T17:25:31-08:00 Clear empty nil values in session hash before saving 57d6562a61fda26dcb4e79fca70f2e61206bba5a Joshua Peek josh@joshpeek.com e8c1915416579a3840573ca2c80822d96cb31823 Joshua Peek josh@joshpeek.com http://github.com/rails/rails/commit/ed708307137c811d14e5fd2cb4ea550add381a82 ed708307137c811d14e5fd2cb4ea550add381a82 2008-12-15T14:33:31-08:00 2008-12-15T14:33:31-08:00 Switch to Rack based session stores. 31cb7df0a489bb4bbb0a9bc9edb24a70a869a0d1 Joshua Peek josh@joshpeek.com a392f34fb4069ab847ff631130d023cdaf896735 Nathan Weizenbaum nex342@gmail.com http://github.com/rails/rails/commit/e8c1915416579a3840573ca2c80822d96cb31823 e8c1915416579a3840573ca2c80822d96cb31823 2008-12-15T12:49:38-08:00 2008-12-15T12:49:38-08:00 Auto-load template handlers based on unmatched extensions [#1540 state:resolved] Signed-off-by: Joshua Peek <josh@joshpeek.com> 99b7df0571b35701ab6e973024c25e5141c0da23 Joshua Peek josh@joshpeek.com 0d48408dccd2b69754310cb3702ddfe705dbcd12 Hongli Lai (Phusion) hongli@phusion.nl http://github.com/rails/rails/commit/a392f34fb4069ab847ff631130d023cdaf896735 a392f34fb4069ab847ff631130d023cdaf896735 2008-12-15T12:47:19-08:00 2008-12-15T12:47:19-08:00 Require mocha >= 0.9.3, older versions don't work anymore [#1579 state:resolved] Signed-off-by: Joshua Peek <josh@joshpeek.com> c1fe5fc34bdd06b797e7690d8a3eaec7dd052bc8 Joshua Peek josh@joshpeek.com