7db1704068b86fb2212388b14b4963526bacfa5d Frederick Cheung frederick.cheung@gmail.com http://github.com/rails/rails/commit/f9cab0e503a4721c9d0369f89bb85c6e658f778c f9cab0e503a4721c9d0369f89bb85c6e658f778c 2008-12-26T15:26:37-08:00 2008-12-26T15:26:37-08:00 Fix :include of has_one with :primary_key option 8d0c579bd0f75b824779b3a5ba76c3f39af157a6 Frederick Cheung frederick.cheung@gmail.com f4f8923cf0ef5bd31f9e98cecf4603d0c4bde296 Frederick Cheung frederick.cheung@gmail.com http://github.com/rails/rails/commit/7db1704068b86fb2212388b14b4963526bacfa5d 7db1704068b86fb2212388b14b4963526bacfa5d 2008-12-26T15:17:56-08:00 2008-12-26T14:53:07-08:00 Fix :include of has_many associations with :primary_key option 615165073929beb1f1c0ad67fd8f146446ac2c56 Frederick Cheung frederick.cheung@gmail.com 6dc12881110d26bb952bd0f565623144f10a07b6 5cebe69e74d411c3c9e5f6ab9d4b2b16ee36177c Pratik Naik pratiknaik@gmail.com http://github.com/rails/rails/commit/f4f8923cf0ef5bd31f9e98cecf4603d0c4bde296 f4f8923cf0ef5bd31f9e98cecf4603d0c4bde296 2008-12-26T13:56:21-08:00 2008-12-26T13:56:21-08:00 Merge commit 'fred/pullable' 2c5d9b59cefa59476ef48ea85aa0c2f00e1e33c1 Pratik Naik pratiknaik@gmail.com db5a98e6cbb88331a6ce484260e9cce9ba882bcd Yehuda Katz wycats@gmail.com http://github.com/rails/rails/commit/6dc12881110d26bb952bd0f565623144f10a07b6 6dc12881110d26bb952bd0f565623144f10a07b6 2008-12-26T13:41:02-08:00 2008-12-26T13:37:42-08:00 Remove method missing use in respond_to 68c1a4cf50cc28864cf2b72714508e2524798a62 Yehuda Katz wycats@gmail.com eb457ceee13779ade67e1bdebd2919d476148277 Frederick Cheung frederick.cheung@gmail.com http://github.com/rails/rails/commit/5cebe69e74d411c3c9e5f6ab9d4b2b16ee36177c 5cebe69e74d411c3c9e5f6ab9d4b2b16ee36177c 2008-12-26T10:25:55-08:00 2008-12-18T17:02:21-08:00 Preload uses exclusive scope [#643 state:resolved] With self referential associations, the scope for the the top level should not affect fetching of associations, for example when doing Person.male.find :all, :include => :friends we should load all of the friends for each male, not just the male friends. 7e30226bcda0e5f9292b71927a32d5c15133e391 Frederick Cheung frederick.cheung@gmail.com c9d4335418823500548ad8fbc86af7c910b7644b Pivotal Labs opensource@pivotallabs.com http://github.com/rails/rails/commit/eb457ceee13779ade67e1bdebd2919d476148277 eb457ceee13779ade67e1bdebd2919d476148277 2008-12-26T10:25:50-08:00 2008-12-24T14:57:09-08:00 Association preloading no longer stops if it hits a nil object [#1630 state:resolved] Signed-off-by: Frederick Cheung <frederick.cheung@gmail.com> ddaa96980a5b48f4e3d940c4545a2ab3a65a1a2d Frederick Cheung frederick.cheung@gmail.com dce0da77e7ef602f7420f43c0d1aba5a99a00bdb trans transfire@gmail.com http://github.com/rails/rails/commit/c9d4335418823500548ad8fbc86af7c910b7644b c9d4335418823500548ad8fbc86af7c910b7644b 2008-12-26T10:25:42-08:00 2008-12-24T16:24:05-08:00 MaKe Hash#slice! return removed values, akin to Array [#971 state:resolved] Signed-off-by: Frederick Cheung <frederick.cheung@gmail.com> d28fac55b165cfd3aaa8a9a0f38ea3235fb54485 Frederick Cheung frederick.cheung@gmail.com d7b6e48c70076a7760e22c381e48834ecddfa6e3 Frederick Cheung frederick.cheung@gmail.com http://github.com/rails/rails/commit/dce0da77e7ef602f7420f43c0d1aba5a99a00bdb dce0da77e7ef602f7420f43c0d1aba5a99a00bdb 2008-12-26T10:25:32-08:00 2008-12-25T03:11:00-08:00 Fix assert_select_rjs not checking id for inserts [#540 state:resolved] d917bf9cd17da1575ea6ad3c97c8311ddc3ad2a6 Frederick Cheung frederick.cheung@gmail.com e898f82a743063652aed802d99ea8b5deac2ec3c Frederick Cheung frederick.cheung@gmail.com http://github.com/rails/rails/commit/d7b6e48c70076a7760e22c381e48834ecddfa6e3 d7b6e48c70076a7760e22c381e48834ecddfa6e3 2008-12-26T10:25:03-08:00 2008-12-25T04:10:28-08:00 Fix randomly failing cookie store tests Marshal.dump(Marshal.load(marshaled_hash)) is not guarenteed to be equal to marshaled_hash because of the lack of ordering of hash c12cd1e7ae9b8ec1c136b3dd3d84dd63b20011ba Frederick Cheung frederick.cheung@gmail.com 07298fd0929ae1c6dd6d1b41bf320112d6bfc6a0 Pratik Naik pratiknaik@gmail.com http://github.com/rails/rails/commit/db5a98e6cbb88331a6ce484260e9cce9ba882bcd db5a98e6cbb88331a6ce484260e9cce9ba882bcd 2008-12-26T09:19:59-08:00 2008-12-26T09:19:59-08:00 Merge docrails db8fc9b9c07ca9a523a764ad76ce3b75254c73b3 Pratik Naik pratiknaik@gmail.com 80307c8b0a889acc7abb7f4e52fd4c02e1063ba8 Pratik Naik pratiknaik@gmail.com http://github.com/rails/rails/commit/07298fd0929ae1c6dd6d1b41bf320112d6bfc6a0 07298fd0929ae1c6dd6d1b41bf320112d6bfc6a0 2008-12-25T17:49:14-08:00 2008-12-25T17:49:14-08:00 Don't recurse when ActionController#render is called without any arguments 6279544ecdfc283bed0a4b7ea308a82ec2156922 Pratik Naik pratiknaik@gmail.com cd1d6e8768ae13b11bc343701037b20ad35e6f1e Pratik Naik pratiknaik@gmail.com http://github.com/rails/rails/commit/80307c8b0a889acc7abb7f4e52fd4c02e1063ba8 80307c8b0a889acc7abb7f4e52fd4c02e1063ba8 2008-12-25T17:12:11-08:00 2008-12-25T17:03:18-08:00 Make ActionController#render(symbol) behave same as ActionController#render(string) [#1435] c4cb570b8f29a63408c3b74f2cbedd383c48d237 Pratik Naik pratiknaik@gmail.com d67e03871eabb912434dafac3eeb8e6ea7c5585f Pratik Naik pratiknaik@gmail.com http://github.com/rails/rails/commit/cd1d6e8768ae13b11bc343701037b20ad35e6f1e cd1d6e8768ae13b11bc343701037b20ad35e6f1e 2008-12-25T15:05:34-08:00 2008-12-25T15:01:17-08:00 Make ActionController#render(string) work as a shortcut for render :action => string. [#1435] Examples: # Instead of render(:action => 'other_action') render('other_action') Note : Argument must not have any '/' b400f930c3ca31a26c41ab0d30c4283dc17b2d79 Pratik Naik pratiknaik@gmail.com 061952392afd1dae1aa97a816e9a0c79df7c4514 Pratik Naik pratiknaik@gmail.com http://github.com/rails/rails/commit/d67e03871eabb912434dafac3eeb8e6ea7c5585f d67e03871eabb912434dafac3eeb8e6ea7c5585f 2008-12-25T14:26:03-08:00 2008-12-25T14:11:06-08:00 Make ActionController#render(string) work as a shortcut for render :template => string. [#1435] Examples: # Instead of render(:template => 'controller/action') render('controller/action') Note : Argument must not begin with a '/', but have at least one '/' ac7d7092f56c5e5bfe6c690d44bbf5c91fca8c24 Pratik Naik pratiknaik@gmail.com dd0753458f2a16c876c52734f84a242f56746607 Pratik Naik pratiknaik@gmail.com http://github.com/rails/rails/commit/061952392afd1dae1aa97a816e9a0c79df7c4514 061952392afd1dae1aa97a816e9a0c79df7c4514 2008-12-25T13:43:07-08:00 2008-12-25T13:27:56-08:00 Make ActionController#render(string) work as a shortcut for render :file => string. [#1435] Examples: # Instead of render(:file => '/Users/lifo/home.html.erb') render('/Users/lifo/home.html.erb') Note : Filename must begin with a forward slash ('/') ce5599e69468632d5898ddb5088f0d729e4ddc91 Pratik Naik pratiknaik@gmail.com 04a8b2362deb37f33c0a9060510f194286b6822a Pratik Naik pratiknaik@gmail.com http://github.com/rails/rails/commit/dd0753458f2a16c876c52734f84a242f56746607 dd0753458f2a16c876c52734f84a242f56746607 2008-12-25T12:49:31-08:00 2008-12-25T12:45:59-08:00 Move ActionController::Base#render arguments validation to a separate method 7e1a57a9161aca9abf382023cad4796c53e48d4e Pratik Naik pratiknaik@gmail.com 6e2a771661a47fb682108648244837f8616e350d Pratik Naik pratiknaik@gmail.com http://github.com/rails/rails/commit/04a8b2362deb37f33c0a9060510f194286b6822a 04a8b2362deb37f33c0a9060510f194286b6822a 2008-12-25T11:28:08-08:00 2008-12-25T11:28:08-08:00 Make render_test.rb run in isolation 716d8400a1f0dd40556fd5978d267914ef05148f Pratik Naik pratiknaik@gmail.com e898f82a743063652aed802d99ea8b5deac2ec3c Pratik Naik pratiknaik@gmail.com http://github.com/rails/rails/commit/6e2a771661a47fb682108648244837f8616e350d 6e2a771661a47fb682108648244837f8616e350d 2008-12-25T09:54:44-08:00 2008-12-25T09:54:44-08:00 Undry ActionController::TestCase#<HTTP_METHODS> for better documentation d0ab5f66aab84b759b31d1a54ba15eaa301756d4 Pratik Naik pratiknaik@gmail.com 9c1e48eaea921efa67fbeed1ff1876dc710f8fd2 Pratik Naik pratiknaik@gmail.com http://github.com/rails/rails/commit/e898f82a743063652aed802d99ea8b5deac2ec3c e898f82a743063652aed802d99ea8b5deac2ec3c 2008-12-24T19:51:04-08:00 2008-12-24T19:51:04-08:00 Move request parsing related code to ActionController::RequestParser 5cfc968597bdf33bd4de15e81c71bf2923211d50 Pratik Naik pratiknaik@gmail.com 3562d54d18bf6c87384436c63383666617a2a1eb Joshua Peek josh@joshpeek.com http://github.com/rails/rails/commit/9c1e48eaea921efa67fbeed1ff1876dc710f8fd2 9c1e48eaea921efa67fbeed1ff1876dc710f8fd2 2008-12-23T11:36:05-08:00 2008-12-23T11:36:05-08:00 ActionController::VerbPiggybacking middleware 9afb77428da5d309664e9e09960e95a5277faa98 Joshua Peek josh@joshpeek.com 293bb02f91390088890104335c76c51b8990cc49 Pratik Naik pratiknaik@gmail.com http://github.com/rails/rails/commit/3562d54d18bf6c87384436c63383666617a2a1eb 3562d54d18bf6c87384436c63383666617a2a1eb 2008-12-22T16:36:13-08:00 2008-12-22T16:36:13-08:00 Remove duplicate attr_reader :env a4642848630aed396f320620242d41b50241ab84 Pratik Naik pratiknaik@gmail.com b5ecfe78f9fb3b06f4fec4815b5e79399e4993aa Pratik Naik pratiknaik@gmail.com http://github.com/rails/rails/commit/293bb02f91390088890104335c76c51b8990cc49 293bb02f91390088890104335c76c51b8990cc49 2008-12-22T16:30:32-08:00 2008-12-22T16:15:08-08:00 Unify ActionController::AbstractRequest and ActionController::Request 95114746de1de501a05117490cc524001003a304 Pratik Naik pratiknaik@gmail.com 7e1751111ecf3886eba313fef183d73ff1f07eb6 Pratik Naik pratiknaik@gmail.com http://github.com/rails/rails/commit/b5ecfe78f9fb3b06f4fec4815b5e79399e4993aa b5ecfe78f9fb3b06f4fec4815b5e79399e4993aa 2008-12-22T16:30:32-08:00 2008-12-22T15:13:04-08:00 Use Rack::MockRequest for TestRequest 42febcdf9342ac681275fc87f958fbacff04578d Pratik Naik pratiknaik@gmail.com 408ec6c0dcb901b2432c72bd3253fa691c5aede0 Pratik Naik pratiknaik@gmail.com http://github.com/rails/rails/commit/7e1751111ecf3886eba313fef183d73ff1f07eb6 7e1751111ecf3886eba313fef183d73ff1f07eb6 2008-12-22T16:30:32-08:00 2008-12-22T14:36:38-08:00 Rename RackRequest to Request 9e7f833fbb946b9fd01f8d0a990d74376bb9b525 Pratik Naik pratiknaik@gmail.com 900aad677f5bf06dc3a3ad42e68b582550f3b08a Pratik Naik pratiknaik@gmail.com http://github.com/rails/rails/commit/408ec6c0dcb901b2432c72bd3253fa691c5aede0 408ec6c0dcb901b2432c72bd3253fa691c5aede0 2008-12-22T16:30:32-08:00 2008-12-22T14:15:53-08:00 Remove rack_process.rb af6d0419ab923109f92c943d024ba9cca0bc8f6e Pratik Naik pratiknaik@gmail.com faf8364050c0a3925a8b2af85b6b5c9e94090986 Pratik Naik pratiknaik@gmail.com http://github.com/rails/rails/commit/900aad677f5bf06dc3a3ad42e68b582550f3b08a 900aad677f5bf06dc3a3ad42e68b582550f3b08a 2008-12-22T16:30:32-08:00 2008-12-22T14:03:14-08:00 Remove deprecated relative_url_root e49184940cabdff1752653536cfb0f8c6b61129d Pratik Naik pratiknaik@gmail.com 0b22a96b7aa39cb7244d7cee23f3d03b6117b447 Joshua Peek josh@joshpeek.com http://github.com/rails/rails/commit/faf8364050c0a3925a8b2af85b6b5c9e94090986 faf8364050c0a3925a8b2af85b6b5c9e94090986 2008-12-22T14:58:48-08:00 2008-12-22T14:58:48-08:00 Defining a new method is atomic, no mutex needed. de8bc8d61dfe9e582076b2ea9ca3e89b8a4d4414 Joshua Peek josh@joshpeek.com aa002c0e86afdc83693f14667a710107843f0fbd Joshua Peek josh@joshpeek.com http://github.com/rails/rails/commit/0b22a96b7aa39cb7244d7cee23f3d03b6117b447 0b22a96b7aa39cb7244d7cee23f3d03b6117b447 2008-12-22T10:04:32-08:00 2008-12-22T10:04:32-08:00 Move default middleware stack to middlewares.rb 4300480830267a58142a4efe60b76099b6efad8e Joshua Peek josh@joshpeek.com 63aac338332a06d3c9e28dde7954679703ec7620 Joshua Peek josh@joshpeek.com http://github.com/rails/rails/commit/aa002c0e86afdc83693f14667a710107843f0fbd aa002c0e86afdc83693f14667a710107843f0fbd 2008-12-22T09:31:18-08:00 2008-12-22T09:31:18-08:00 ActiveRecord::QueryCache middleware 0ec063c6a18b2f9f523ada8a5d338b68dd562be2 Joshua Peek josh@joshpeek.com 70456aed31ae64b36563fc5d32ac114e0a095231 Luis Hurtado luis@time4code.com http://github.com/rails/rails/commit/63aac338332a06d3c9e28dde7954679703ec7620 63aac338332a06d3c9e28dde7954679703ec7620 2008-12-22T07:19:33-08:00 2008-12-22T07:18:43-08:00 Ensure of Model#create support custom updated_at and updated_on attributes [#1612 state:resolved] Signed-off-by: Pratik Naik <pratiknaik@gmail.com> 29444858c43d6f3a22e9f50ed5e2252ecb6e862a Pratik Naik pratiknaik@gmail.com