Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Ruby 2.2.2 #19753

Merged
merged 1 commit into from Apr 14, 2015
Merged

Upgrade to Ruby 2.2.2 #19753

merged 1 commit into from Apr 14, 2015

Conversation

jonatack
Copy link
Contributor

and fix the grammar in the ruby_version_check.rb user message.

and fix the grammar in the ruby_version_check.rb user message.
guilleiguaran added a commit that referenced this pull request Apr 14, 2015
@guilleiguaran guilleiguaran merged commit 33ea933 into rails:master Apr 14, 2015
@jonatack jonatack deleted the use-ruby-2-2-2 branch April 14, 2015 04:03
@matthewd
Copy link
Member

Err, why bump the dependency?

It's a security release, so there aren't many good reasons for someone to want to run 2.2.1... but we're not the Version Police. 👎

@morgoth
Copy link
Member

morgoth commented Apr 14, 2015

I believe this bump will be required for #19752

@kaspth
Copy link
Contributor

kaspth commented Apr 14, 2015

@matthewd We've deprecated alias_method_chain in favor of prepend, but there was bug when calling super which means we wouldn't be able to follow through with the recommendation. So, we update the version.

@matthewd
Copy link
Member

@kaspth that's why we required 2.2.1, not 2.2.2, though.. right?

@matthewd
Copy link
Member

(or was that a different bug?)

@kaspth
Copy link
Contributor

kaspth commented Apr 14, 2015

No, 2.2.1 caused a segmentation fault with some form of keyword arguments (right, @eileencodes?).

@eileencodes
Copy link
Member

Yea 2.2.1 was causing a segmentation fault

@jonatack
Copy link
Contributor Author

http://svn.ruby-lang.org/repos/ruby/tags/v2_2_2/ChangeLog

Mon Apr 13 00:16:32 2015  Nobuyoshi Nakada  <nobu@ruby-lang.org>
    * vm_eval.c (vm_call_super): search next super class from the
      original class, to get rid of infinite recursion with
      prepending.  a patch by Seiei Higa <hanachin AT gmail.com> at
      [ruby-core:68434].  [ruby-core:68093] [Bug #10847]

Mon Apr 13 00:09:48 2015  Koichi Sasada  <ko1@atdot.net>
    * class.c (rb_prepend_module): need a WB for klass -> origin.

@jonatack
Copy link
Contributor Author

@jonatack
Copy link
Contributor Author

The bug fix appears to have been backported to the ruby_2_2 and ruby_2_1 branches.

@matthewd
Copy link
Member

👍, if we're actually depending on the newer version / about to depend on the newer version, this is fine. My issue was that the PR originally presented as "hey there's a new version, let's require it" with no justification / explanation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants