New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to Ruby 2.2.2 #19753
Upgrade to Ruby 2.2.2 #19753
Conversation
and fix the grammar in the ruby_version_check.rb user message.
Err, why bump the dependency? It's a security release, so there aren't many good reasons for someone to want to run 2.2.1... but we're not the Version Police. 👎 |
I believe this bump will be required for #19752 |
@matthewd We've deprecated |
@kaspth that's why we required 2.2.1, not 2.2.2, though.. right? |
(or was that a different bug?) |
No, 2.2.1 caused a segmentation fault with some form of keyword arguments (right, @eileencodes?). |
Yea 2.2.1 was causing a segmentation fault |
http://svn.ruby-lang.org/repos/ruby/tags/v2_2_2/ChangeLog
|
The bug fix appears to have been backported to the |
👍, if we're actually depending on the newer version / about to depend on the newer version, this is fine. My issue was that the PR originally presented as "hey there's a new version, let's require it" with no justification / explanation. |
and fix the grammar in the ruby_version_check.rb user message.