Remove XML Serialization from core #21161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This includes the following classes: - ActiveModel::Serializers::Xml - ActiveRecord::Serialization::XmlSerializer
rafaelfranca
added a commit
that referenced
this pull request
Aug 7, 2015
Remove XML Serialization from core
|
Re #20612 |
smpoulsen
added a commit
to smartlogic/toystore
that referenced
this pull request
Oct 10, 2016
Bumps versions for `activesupport` and `activemodel` to allow v5 for each. Adds `activemodel-serializers-xml`, as this was removed in Rails 5 (ref: rails/rails#21161).
cdccollins
added a commit
to alphagov/asset-manager
that referenced
this pull request
Jul 7, 2020
Updated mongoid and state_machines-mongoid so that rails could move to version 6. Was getting `uninitialized constant ActiveModel::Serializers::Xml` so added activemodel-serializers-xml gem (was removed from core rails rails/rails#21161)
cdccollins
added a commit
to alphagov/asset-manager
that referenced
this pull request
Jul 8, 2020
Updated mongoid and state_machines-mongoid so that rails could move to version 6. Was getting `uninitialized constant ActiveModel::Serializers::Xml` so added activemodel-serializers-xml gem (was removed from core rails rails/rails#21161)
cdccollins
added a commit
to alphagov/asset-manager
that referenced
this pull request
Jul 8, 2020
Updated mongoid and state_machines-mongoid so that rails could move to version 6. Was getting `uninitialized constant ActiveModel::Serializers::Xml` so added activemodel-serializers-xml gem (was removed from core rails rails/rails#21161)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes the following classes and method:
This code has moved to an external gem called activemodel-serializers-xml. (which we can move to the Rails org.)
#20612