Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backporting a Ruby 1.9.3 fix for MissingSourceFile #3745

Closed
wants to merge 1 commit into from

Conversation

jescalante
Copy link

I backported a Ruby 1.9.3 fix in MissingSourceFile from Rails master.
In Ruby 1.9.3 a new error message was added when the LoadFile exception is thrown; this was fixed in Rails Master but not in 2-3-stable, rendering 2-3-stable unusable with Ruby 1.9.3

This is the specific line from master: https://github.com/rails/rails/blob/master/activesupport/lib/active_support/core_ext/load_error.rb#L6

@josevalim
Copy link
Contributor

Thanks but Rails 2-3 is no longer maintained.

@josevalim josevalim closed this Nov 24, 2011
@elia
Copy link
Contributor

elia commented May 8, 2012

@josevalim this probably can be merged after @dhh's comment on #3650

@grosser
Copy link
Contributor

grosser commented Jul 10, 2012

FYI: monkeypatch would be:
MissingSourceFile::REGEXPS << [/^cannot load such file -- (.+)$/i, 1]

@elia
Copy link
Contributor

elia commented Jul 10, 2012

@spaghetticode will you include this in spaghetticode/rails2ext?

@spaghetticode
Copy link
Contributor

@elia sure I will

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants