serializable_hash: Jobs should partially define how to as serialize and de-serialize themselves #9924
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(based on feedback from #9910)
Problem I'm trying to solve:
Users of Rails Q API expect the Q system to be able to serialize and de-serialize the jobs they enQ. If it's unable to do so, it should complain about it with an exact reason, at the time of enQ.
My take:
This problem can't easily be solved exclusively by the framework. Any attempt to do so fully would likely lead to a leaky abstraction wherein Job authors end up digging in to the guts of such an implementation.
Instead, a simple and minimal contract should exist between Job objects and the framework responsible for enQ-ing and running them.
Additionally:
Backend job systems should have a choice on how to serialize jobs. It's fine for Marshal to be the default in Rails, but it's unnecessarily restricting to impose this requirement on all integrators.