@@ -32,12 +32,6 @@ class TableView
"#{self} #{sort_order}"
end
- def render_sort_order
- if active?
- '<span class="sort">%s</span>' % (ascending? ? '↓' : '↑')
- end
- end
-
def reverse_sort_order
if ascending? then "desc" else "asc" end
end
lib/column.rb
@@ -12,9 +12,15 @@ class TableView
def header(column)
label = column.human_name
field = link_to(label, url_hash_for(column))
- helpers.content_tag(:th, "#{field} #{column.render_sort_order}", column.options[:th])
+ helpers.content_tag(:th, "#{field} #{render_sort_order(column)}", column.options[:th])
end
+ def render_sort_order(column)
+ if column.active?
+ '<span class="sort">%s</span>' % (column.ascending? ? '↓' : '↑')
+ end
+ end
+
def url_hash_for(column)
{
params.sort_by_field_name => column,
lib/column_renderer.rb
69aff86ffe05d20363834ebd62bb75a8cae0032b
Dima Sabanin
sdmitry@gmail.com
http://github.com/railsmonk/table_view/commit/72dcf8c652dfbcf8e53d33254eeed28f7f01ac3b
72dcf8c652dfbcf8e53d33254eeed28f7f01ac3b
2009-04-20T03:06:07-07:00
2009-04-20T03:06:07-07:00
removed code smell
2acd97d60ed0887e3f0a4f85cd2885ee781448ca
Dima Sabanin
sdmitry@gmail.com