rcoyner (Ryan Coyner)

Name
Ryan Coyner
Email
Website/Blog
http://www.ryancoyner.com
Location
Washington DC
Member Since
Mar 22, 2009 (9 months)

Following 2 githubbers and watching 40 repositories view all →

Public Repositories (4)

Public Activity feed

rcoyner pushed to master at rcoyner/pymt Wed Nov 25 13:52:52 -0800 2009
HEAD is 90087b9d74f080174f5e0c1f9e064faa7dc6bc70

31 commits »

rcoyner pushed to master at rcoyner/pymt Fri Nov 20 15:11:33 -0800 2009
HEAD is 166371dd57614e728bf6353529c2477c0711bf57

21 commits »

rcoyner deleted branch core-swig at rcoyner/pymt Thu Nov 19 21:14:40 -0800 2009
Deleted branch was at rcoyner/pymt/tree/core-swig
rcoyner deleted branch imports at rcoyner/pymt Thu Nov 19 21:14:37 -0800 2009
Deleted branch was at rcoyner/pymt/tree/imports
rcoyner pushed to master at rcoyner/pymt Thu Nov 19 21:13:34 -0800 2009
HEAD is fb7ae8f95717c70022ce4459d7a8471ff11ec74f

87 commits »

rcoyner pushed to imports at rcoyner/pymt Wed Nov 18 17:15:18 -0800 2009
HEAD is fb7ae8f95717c70022ce4459d7a8471ff11ec74f

12 commits »

rcoyner pushed to master at rcoyner/pymt Wed Nov 18 17:02:43 -0800 2009
HEAD is 4075468fb67355b6b5841e8ee88c3aa95cd76841

9 commits »

rcoyner commented on rcoyner/pymt Tue Nov 17 10:20:42 -0800 2009
Comment in cf14915:

So under the old model, this is how it worked:

Create the Shadow Window - Calls init which initializes pygame.display and sets GL settings.
Create the Main Window - Repeat of above.

Under this model, this is how it works:

Create the Shadow Window - Calls init, initializes pygame.display, sets GL settings, checks if multisampling is enabled and if it is, enable multisampling.

Create the Main Window - Calls init, initializes pygame.display, sets GL settings.

So I guess what you're saying is - are the multisampling settings reset after re-initializing pygame.display? I assumed that they carried over, but you may be right. My laptop doesn't support multisampling so I can't test this. I'll try running it on my desktop later to see if it is the case. The solution is simple though.

  1. If the gl_set_attribute settings carry over even after re-initialization, then nothing needs to change and this patch can be applied directly.
  2. If the gl_set_attribute settings DO NOT carry over, then the if hasGLExtension statement needs to toggle a multisampling flag (one actually exists in BaseWindow called _have_multisampling), so that multisampling can be initialized in init when the Main Window is created.
rcoyner pushed to imports at rcoyner/pymt Mon Nov 16 20:31:09 -0800 2009
HEAD is 643b099ee3c9373b023a7f8dc895b0bda84e88bd
  • rcoyner committed 643b099e:
    Converted WidgetsFactory to absolute imports.
rcoyner deleted branch core-next at rcoyner/pymt Mon Nov 16 18:17:07 -0800 2009
Deleted branch was at rcoyner/pymt/tree/core-next
rcoyner pushed to imports at rcoyner/pymt Mon Nov 16 18:15:27 -0800 2009
HEAD is 5770829b7d02b01f1a1d2ecac4a6f7209950c168

5 commits »

rcoyner pushed to master at rcoyner/pymt Mon Nov 16 18:08:03 -0800 2009
HEAD is cf14915f9a75f60a279afd96294869ca1f992d80
  • rcoyner committed cf14915f:
    Fixed pygame multisampling crash. GLUT also cooperates now.
rcoyner pushed to master at rcoyner/pymt Mon Nov 16 17:36:33 -0800 2009
HEAD is c7a8881988ec20aa672f735885a59ae1465b5c28

2 commits »

rcoyner pushed to imports at rcoyner/pymt Mon Nov 16 14:43:44 -0800 2009
HEAD is 90363acd698c9035914af4bbb20dcf202e56b818

3 commits »

rcoyner pushed to master at rcoyner/pymt Mon Nov 16 14:43:30 -0800 2009
HEAD is 34fdc686448d2f0233c5dda173377752a4cc9f33

2 commits »

rcoyner pushed to imports at rcoyner/pymt Mon Nov 16 14:42:41 -0800 2009
HEAD is e392cc379ff6c781284862fc86ee6e3a851b4d5d
  • rcoyner committed e392cc37:
    Finished absolute import conversion for video related files.
rcoyner pushed to imports at rcoyner/pymt Mon Nov 16 14:29:37 -0800 2009
HEAD is 792c9ac656b4bcfe979372b6bb772ca0de3d72c6
  • rcoyner committed 792c9ac6:
    Finished absolute import conversion for additional widgets.
rcoyner pushed to imports at rcoyner/pymt Mon Nov 16 14:13:10 -0800 2009
HEAD is fe3d59aa198a9a4477127bd326b7b73db2390f60
  • rcoyner committed fe3d59aa:
    Finished additional absolute import conversions.
rcoyner pushed to imports at rcoyner/pymt Mon Nov 16 13:43:35 -0800 2009
HEAD is a5833933acfbfa70f923a38b92e85059aea8872d

10 commits »

rcoyner pushed to master at rcoyner/pymt Mon Nov 16 13:29:15 -0800 2009
HEAD is f52064aa17fc968bf71003d738c5615e3536f83f

8 commits »

rcoyner pushed to imports at rcoyner/pymt Mon Nov 16 00:50:29 -0800 2009
HEAD is 3d0137c411325ece7ade3bedd5f3dc4f2124b74e
  • rcoyner committed 3d0137c4:
    Fixed bugs in examples, ported pymt.modules to absolute imports.
rcoyner pushed to imports at rcoyner/pymt Mon Nov 16 00:29:31 -0800 2009
HEAD is 558bc442fa9da6abe0fce457c3bd9df69f487ca5

13 commits »

rcoyner pushed to master at rcoyner/pymt Sun Nov 15 23:27:47 -0800 2009
HEAD is 6443026a7fbbd050fd2c6ea6a4a1f0cd8c6717de

11 commits »

rcoyner commented on tito/pymt Sun Nov 15 18:17:58 -0800 2009
Comment in 140036a:

I can understand why the GLUT backend may not work since this patch modified that. But your Pygame backend should not have failed. That file was not modified, and the change introduced in init.py should not have affected the Pygame backend... Thoughts?

rcoyner pushed to imports at rcoyner/pymt Sat Nov 14 18:57:09 -0800 2009
HEAD is 27af1733a0e5c0fe0f490a4b06571d880079e853

3 commits »

rcoyner pushed to master at rcoyner/pymt Sat Nov 14 18:54:53 -0800 2009
HEAD is d566c2cb767d623d117df119b5bb6d1a18668708
  • rcoyner committed d566c2cb:
    Fix GLUT window to properly create shadow window.
rcoyner pushed to imports at rcoyner/pymt Sat Nov 14 15:58:58 -0800 2009
HEAD is 9f2ed9c5ca062cdff655c4108cdbffb1e7df0d1d

7 commits »

rcoyner pushed to master at rcoyner/pymt Sat Nov 14 15:36:44 -0800 2009
HEAD is e0d8e9893f02ef3fa27666cb77acc42028f4151e
  • rcoyner committed e0d8e989:
    Fixed pygame image loader backend to properly load images.
rcoyner pushed to master at rcoyner/pymt Sat Nov 14 15:07:23 -0800 2009
HEAD is d6bd15f6c198f9e07c78302b783585ba1d9623a0
  • rcoyner committed d6bd15f6:
    Added an extra control statement to prevent pygame image loader from crashing.
rcoyner pushed to master at rcoyner/pymt Sat Nov 14 14:56:58 -0800 2009
HEAD is 0d1120a1c489fae3bd9b05ecadc867262295b50a
  • rcoyner committed 0d1120a1:
    Added small logger.info statement for core_register_lib.
rcoyner pushed to imports at rcoyner/pymt Sat Nov 14 14:17:04 -0800 2009
HEAD is 9fcf4500b34288a836491db958217a0fd780c4fa

11 commits »

rcoyner pushed to master at rcoyner/pymt Sat Nov 14 11:24:58 -0800 2009
HEAD is 04c8592e23b34f6ea61f05a05a9cd2cd0db2effa

7 commits »

rcoyner pushed to master at rcoyner/pymt Sat Nov 14 07:00:59 -0800 2009
HEAD is fd5468726c6c5105ad7f2985ac45cb7b35c9e9e1

2 commits »