reagent / fleakr
- Source
- Commits
- Network (14)
- Issues (4)
- Downloads (12)
- Wiki (1)
- Graphs
-
Branch:
master
-
Problems with set titles and other text fields
6 comments Created about 1 month ago by nighthwk1For instance:
>> sets[1] => #<Fleakr::Objects::Set:0x10210d940 @primary_photo_id="3729672314", @description="", @id="12345678901234567890", @count="33", @authentication_options={}, @title="", @document={elem <photoset farm="3" photos="33" videos="0" primary="3729672314" server="2437" id="12345678901234567890" secret="1234567890"> "\n\t\t" {elem <title> "Shake-a-spear" </title>} "\n\t\t" {emptyelem <description>} "\n\t" </photoset>}>As you can see, there is a title associated with the photo, but @title is empty. Maybe Flickr changed their API? I'm seeing similar issues with photo.url and possibly other fields as well.
Comments
-
1 comment Created about 1 month ago by reagentbugxGet Fleakr working with Hpricot 0.8.2compatibilityxExtraction of set titles and other details fails with the newest version of Hpricot, this should be fixed to be compatible with 0.8.2 (and likely change the dependency in the gemspec). See the discussion in issue #1.
Comments
This commit fixes the compatibility issue. Official release is version 0.6.2 and will be available from gemcutter shortly.
-
fleakr <= 0.6.2 and ActiveSupport 2.3.5 incompatible
7 comments Created 27 days ago by base10With fleakr 0.5.1 and 0.6.2, I run into the following error trying to require fleakr in a script:
/Library/Ruby/Gems/1.8/gems/activesupport-2.3.5/lib/active_support/core_ext/blank.rb:2: uninitialized constant ActiveSupport::Deprecation (NameError)
It appears that in ActiveSupport 2.3.5, active_support/core_ext/blank was deprecated for active_support/core_ext/object/blank. active_support/core_ext/blank requires active_support/core_ext/object/blank, but without including active_support/deprecation and its dependencies, no dice.
I created a diff ( http://gist.github.com/250636 ), but this would raise your dependencies from ActiveSupport 2.0 to 2.3.5 specifically.
Thank you,
Nathan
nwalls ismedia -dot- orgComments
I think the real solution here is to get rid of the dependency on ActiveSupport entirely. There are only a couple places that I'm using it, and even then, it was just used as a quick addition to get the features I wanted.
In the meantime, it might be possible to wrap the requre in a begin ... rescue block to handle both 2.0.x and 2.3.5
That's certainly a lot more flexible than my "found after midnight" suggestion. Cheers.
I have yet to do this, but I would need you to test it for me anyway. Would you be able to fork, commit, and test? Then I can pull your change and push out 0.6.3
let me know.
Sorry for the long delay, but I've pushed e77b4e0 in my fork to add a begin/rescue block. However, I'm currently unable to get the tests to run since it seems Test::Unit isn't thrilled with NameError. I spotted that last night and haven't had time to dig into it much.
Thanks for doing this - I'll pull it in tonight / tomorrow and get out a new version. I'm not too concerned with tests for this since I'm planning to rip out AS entirely.
Glad to do it. I greatly appreciate having fleakr available. Cheers.
-
0 comments Created about 1 month ago by reagentPass extra options through when getting public photos for a userperformancexWhen calling people.getPublicPhotos, there are some additional options that can be passed (namely the URLs to the images). The call to getting these photos should always use the relevant extra parameters as documented in the API documentation
Related: Issue #4
Comments
-
0 comments Created about 1 month ago by reagentPass extra options when searching photosperformancexPhoto search has options similar to those when getting public photos for a user (see the documentation). The library should pass the relevant options (e.g. image URLs) through instead of making separate API calls to find this information.
Related: Issue #3
Comments
-
0 comments Created about 1 month ago by reagentImage URLs should be constructed by their attributes when possibleperformancexWhen there is information available for a photo, this should be used to construct the image URL instead of making an API call. See the URL documentation for examples on how to construct the Photo Source URLs.
This is related to issues #3 and #4 - this might make sense to tackle first.
Comments
-
favorites.getPublicList(docs): User’s publicly-accessible favorites.favorites.getList(docs): Full list of a user’s favorites, including non-public ones.rfavorites.add(docs): Add a photo to user’s favorites.w+favorites.remove(docs): Remove photo from user’s favorites.w+
getListandgetPublicListacceptper_page(0..500; default100) andpage(n; default1) parameters for use with large collections of favorites. The<photos>element of the XML response includes apagesattribute indicating how many calls are needed to collect all the favorites for the givenper_page, as well as atotalattribute that states how many favorites the user has.For the user’s convenience, I suggest an optional argument along the lines of
n_favoritesthat will automatically make the required number of calls and assemble a unified list. (A more complicated but full-featured alternative would bestartandendarguments.)Comments





Can you give me some more context around this error? How did you do the assignment to sets? Is it happening with other sets?
Ok, here's a more complete example:
I get nothing. I've tried it with another account as well (and both definitely have sets with titles).
I've looked around on some other sites, and hpricot 0.8.2 is broken.
Hpricot 0.8.1 works with Fleakr.
Thanks for figuring that out - I'd like to get Fleakr working with 0.8.2 since the only thing keeping me in the 0.6.x series is JRuby compatibility (which appears to be fixed in 0.8.2). I'll open a separate issue for this.
I added issue #2 to track this - if you have the time and interest in working on this, let me know.
Another github user submitted a patch - the fix is in 0.6.2