From 16c0eff87e7762d82fdd37d9949e33a7376d5357 Mon Sep 17 00:00:00 2001 From: Andy McCurdy Date: Thu, 19 Aug 2010 09:03:51 -0700 Subject: [PATCH] slight optimization to hmset, mset, and msetnx for both clarity and speed --- redis/client.py | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/redis/client.py b/redis/client.py index 3e226159d0..0e3cac9e00 100644 --- a/redis/client.py +++ b/redis/client.py @@ -587,7 +587,8 @@ def mget(self, keys, *args): def mset(self, mapping): "Sets each key in the ``mapping`` dict to its corresponding value" items = [] - [items.extend(pair) for pair in mapping.iteritems()] + for pair in mapping.iteritems(): + items.extend(pair) return self.execute_command('MSET', *items) def msetnx(self, mapping): @@ -596,7 +597,8 @@ def msetnx(self, mapping): none of the keys are already set """ items = [] - [items.extend(pair) for pair in mapping.iteritems()] + for pair in mapping.iteritems(): + items.extend(pair) return self.execute_command('MSETNX', *items) def move(self, name, db): @@ -1144,7 +1146,8 @@ def hmset(self, name, mapping): in the hash ``name`` """ items = [] - [items.extend(pair) for pair in mapping.iteritems()] + for pair in mapping.iteritems(): + items.extend(pair) return self.execute_command('HMSET', name, *items) def hmget(self, name, keys):