e63d23e359e72e8cfea950c13b4fcc21cbf102e2 Brice Figureau brice-puppet@daysofwonder.com http://github.com/reductivelabs/puppet/commit/61d19116aa53dd62ff214300fba9ec03a6699876 61d19116aa53dd62ff214300fba9ec03a6699876 2009-12-01T18:10:49-08:00 2009-11-26T11:14:36-08:00 Fix 2841 - Puppetdoc/RDoc parses realize function Puppetdoc wasn't parsing the realize function. This patch let puppetdoc find realize and display in RDoc html mode the list of realized resource per class or node. Signed-off-by: Brice Figureau <brice-puppet@daysofwonder.com> 31394514bb7a3f38c8c4b07c482ed95c4a02f39c James Turnbull james@lovedthanlost.net 41da96281f6c8902191b2c6cc8e07e31363d8f45 James Turnbull james@lovedthanlost.net http://github.com/reductivelabs/puppet/commit/e63d23e359e72e8cfea950c13b4fcc21cbf102e2 e63d23e359e72e8cfea950c13b4fcc21cbf102e2 2009-12-01T18:08:49-08:00 2009-12-01T18:08:49-08:00 Added tickets/master/2596 to the testing branch e9eec77f942bfb9173671704a09ddf241a69a0bf James Turnbull james@lovedthanlost.net c9f40be6c567d8de328b9d79dde357672323925a Jesse Wolfe jes5199@gmail.com http://github.com/reductivelabs/puppet/commit/41da96281f6c8902191b2c6cc8e07e31363d8f45 41da96281f6c8902191b2c6cc8e07e31363d8f45 2009-11-25T12:41:43-08:00 2009-11-24T19:34:15-08:00 Feature 2827 Option to disable managing internal files Add a flag "manage_internal_file_permissions" which is enabled by default. Disabling this flag prevents Puppet from managing the owner, group, or mode of files created from Puppet::Util::Settings::FileSetting I think this is a wide enough net to follow Luke's suggestion of "disable management of everything", and it certainly satisfies the requests I'm aware of, but if I've missed anything, let me know. Signed-off-by: Jesse Wolfe <jes5199@gmail.com> 7f8deeb56d419acc500cb18cc0d61d02abb9f9a1 James Turnbull james@lovedthanlost.net 2d137e2e1ce603ee2727d66b1aba57458bf4d1be Richard Soderberg rs@pi007.sv2.upperbeyond.com http://github.com/reductivelabs/puppet/commit/c9f40be6c567d8de328b9d79dde357672323925a c9f40be6c567d8de328b9d79dde357672323925a 2009-11-19T13:07:52-08:00 2009-08-24T19:57:07-07:00 Fixed #2568 - Add database option 'dbconnections' This sets the ActiveRecords connection pool size, when connecting to remote databases (mysql, postgres). default is 0; the 'pool' argument is only passed to ActiveRecords when the value is 1 or greater. 1ed7730149eb8ac9efc26c96934ff7dfda903a5e James Turnbull james@lovedthanlost.net 089ac3e37dd1418751bc4dfe152e09fbacbc5122 Luke Kanies luke@madstop.com http://github.com/reductivelabs/puppet/commit/2d137e2e1ce603ee2727d66b1aba57458bf4d1be 2d137e2e1ce603ee2727d66b1aba57458bf4d1be 2009-11-19T12:27:21-08:00 2009-09-18T12:54:03-07:00 Fixing #1507 - Adding a :ca_name setting This allows one to specify the name to use in the CA certificate. It defaults to the :certname, but for those stuck using mod_ssl it can be changed. Signed-off-by: Luke Kanies <luke@madstop.com> 44660e699774dd54a6c721cac514cf41a2a543c9 James Turnbull james@lovedthanlost.net 28e1bc6e7b866727adfd16cba5418e08f1dd2fd8 Luke Kanies luke@madstop.com http://github.com/reductivelabs/puppet/commit/089ac3e37dd1418751bc4dfe152e09fbacbc5122 089ac3e37dd1418751bc4dfe152e09fbacbc5122 2009-11-19T12:27:20-08:00 2009-09-18T12:48:12-07:00 Fixing #2617 - using the searched-for REST name This allows a separation between the wrapper class and its internals, which is (at least) necessary for the CA cert, which might not be found using the internal name. Signed-off-by: Luke Kanies <luke@madstop.com> 857232720ead186d188cf94c126baf846d509692 James Turnbull james@lovedthanlost.net 2d4b795e81e4f7953210d51be56c77bed3b77609 Luke Kanies luke@madstop.com http://github.com/reductivelabs/puppet/commit/28e1bc6e7b866727adfd16cba5418e08f1dd2fd8 28e1bc6e7b866727adfd16cba5418e08f1dd2fd8 2009-11-19T12:24:51-08:00 2009-09-17T17:13:59-07:00 Always using the CA_name constant instead of "ca" Signed-off-by: Luke Kanies <luke@madstop.com> 09d913f03257f4defbb873d189aa619df27c3455 James Turnbull james@lovedthanlost.net 0f6181680974f8307eb4ef5e4f6b75b58a195321 Deepak Giridharagopal deepak@brownman.org http://github.com/reductivelabs/puppet/commit/2d4b795e81e4f7953210d51be56c77bed3b77609 2d4b795e81e4f7953210d51be56c77bed3b77609 2009-11-18T19:00:41-08:00 2009-10-10T14:38:20-07:00 Fix #1934 - detailed-exitcodes for puppetd This option only works when --onetime is specified, as it doesn't make much sense to worry about exit codes in the context of a long-running daemon. This required a refactoring of the existing --detailed-exitcodes code, as "puppetd" wasn't directly creating a transaction object (like "puppet" does). Added Report::exit_status, which did what was previously hard-coded into the "puppet" executable. An Agent's "run" method now returns a value (the result of the individual client class' "run" method) The "puppetd" agent's "run" method now returns a transaction report, as that seems like the logical thing to return as the result of applying a catalog. Signed-off-by: Deepak Giridharagopal <deepak@brownman.org> 5a79c9b16e774973034b822f978b4ecb2bdd01fd James Turnbull james@lovedthanlost.net 53be6f81261db1b7a022ec683e1a637cd2c5c93e Rein Henrichs reinh@reinh.com http://github.com/reductivelabs/puppet/commit/0f6181680974f8307eb4ef5e4f6b75b58a195321 0f6181680974f8307eb4ef5e4f6b75b58a195321 2009-11-18T18:45:32-08:00 2009-10-15T16:38:44-07:00 Fix #2649 Allow ssl dir creation in --noop mode Wrap Puppet::Settings.use in a block that disables noop mode during the execution of the block and ensures that noop returns to its original value afterwards. This allows internal puppet catalog operations like ssl directory creation to occur even when puppet is run in --noop mode. This should actually solve a broader class of related bugs. cdce3b45da4ba2e98eb63e41ababe8805a91993b James Turnbull james@lovedthanlost.net 391786f0b43e514d58336f465bc53fb7a5c34884 Brice Figureau brice-puppet@daysofwonder.com http://github.com/reductivelabs/puppet/commit/53be6f81261db1b7a022ec683e1a637cd2c5c93e 53be6f81261db1b7a022ec683e1a637cd2c5c93e 2009-11-11T13:08:04-08:00 2009-11-10T09:19:59-08:00 Fix #2796 - Fix puppetdoc rdoc selector parsing This patch fix this bug by adding more to_s methods to ast member so that puppetdoc can just to_s the AST to reconstruct the original puppet code. Of course this is not perfect, but should work most of the time. Signed-off-by: Brice Figureau <brice-puppet@daysofwonder.com> 3bca7ea658e44d09dd989f0ef1047b570708ab8a James Turnbull james@lovedthanlost.net b832d815c3211f22945cbce56dfbf61116f7a792 Brice Figureau brice-puppet@daysofwonder.com http://github.com/reductivelabs/puppet/commit/391786f0b43e514d58336f465bc53fb7a5c34884 391786f0b43e514d58336f465bc53fb7a5c34884 2009-11-11T13:08:04-08:00 2009-11-10T08:57:26-08:00 Fix #2795 - puppetdoc rdoc reports a better error message When puppetdoc rdoc dies with an unhandled exception, the error message produced didn't mention the file and line where the parser choked. This patch fixes this by trying to locate on which AST structure the rdoc system failed. Signed-off-by: Brice Figureau <brice-puppet@daysofwonder.com> 0d90f61a792b47075b07064fedcce6e9a9dd68be James Turnbull james@lovedthanlost.net b1deb89bae67f7d71ffe412ce4fd8e99c6e1c159 Brice Figureau brice-puppet@daysofwonder.com http://github.com/reductivelabs/puppet/commit/b832d815c3211f22945cbce56dfbf61116f7a792 b832d815c3211f22945cbce56dfbf61116f7a792 2009-11-04T11:21:16-08:00 2009-11-04T11:21:16-08:00 Fix #2784 - puppetdoc/rdoc didn't parse mono-instruction class content class klass { include a, b, c } wasn't producing any rdoc documentation. We were thinking code was always embedded in an array which is not the case for mono-instruction code. Signed-off-by: Brice Figureau <brice-puppet@daysofwonder.com> 347076d81c5c5bd176b24a3bec4f83b452c80a63 Brice Figureau brice-puppet@daysofwonder.com ced5a7887836d1491273b5d6728589f494f8a337 Brice Figureau brice-puppet@daysofwonder.com http://github.com/reductivelabs/puppet/commit/b1deb89bae67f7d71ffe412ce4fd8e99c6e1c159 b1deb89bae67f7d71ffe412ce4fd8e99c6e1c159 2009-10-23T14:36:58-07:00 2009-10-13T14:31:54-07:00 Covers the RDoc Puppet Parser with specs This doesn't cover all the code, only the part that interacts with Puppet internals which is what matters when Puppet changes. This patch also contains an integration test. Signed-off-by: Brice Figureau <brice-puppet@daysofwonder.com> 8f464dc3828e6499b17f3fc228b578b6297b6a8b James Turnbull james@lovedthanlost.net 8d9fbbd4b9d7f1d467ea6123fedcf0ee74f4e8cc Brice Figureau brice-puppet@daysofwonder.com http://github.com/reductivelabs/puppet/commit/ced5a7887836d1491273b5d6728589f494f8a337 ced5a7887836d1491273b5d6728589f494f8a337 2009-10-23T14:36:58-07:00 2009-10-13T14:47:06-07:00 Fix #2376 - Display class/node inheritance in puppetdoc While we were keeping track of superclass/nodes during RDoc generation we weren't doing the reverse. This patch enhance Puppetdoc RDoc mode by tracking inheritance and for each base/super class/nodes displays the list of inherited classes /nodes. Signed-off-by: Brice Figureau <brice-puppet@daysofwonder.com> d3f90aff910a1177d92f998013f490a0b321d520 James Turnbull james@lovedthanlost.net 41b7c3c70082a03563a6b59f23e72ba3735e6efe Brice Figureau brice-puppet@daysofwonder.com http://github.com/reductivelabs/puppet/commit/8d9fbbd4b9d7f1d467ea6123fedcf0ee74f4e8cc 8d9fbbd4b9d7f1d467ea6123fedcf0ee74f4e8cc 2009-10-23T14:36:58-07:00 2009-10-15T11:22:46-07:00 Fix #2703 - add 'require' to puppetdoc Puppetdoc wasn't parsing 'require'. This patch adds a 'require' section to list all required class from nodes and classes. Signed-off-by: Brice Figureau <brice-puppet@daysofwonder.com> 4d077ecbd90400fc3b779dd0b529f4735e9fc096 James Turnbull james@lovedthanlost.net 66a44ddc3032654109036371a5f3a60dd2ab4a9f Luke Kanies luke@madstop.com http://github.com/reductivelabs/puppet/commit/41b7c3c70082a03563a6b59f23e72ba3735e6efe 41b7c3c70082a03563a6b59f23e72ba3735e6efe 2009-10-23T14:36:58-07:00 2009-10-14T17:12:56-07:00 Adding an example yaml node script Signed-off-by: Luke Kanies <luke@madstop.com> 6536278a2e0c27736ab40e4c3b18db93e81ddcfb James Turnbull james@lovedthanlost.net c61335f66f897bc64992c4e9209ea517193c8e30 David Lutterkort lutter@redhat.com http://github.com/reductivelabs/puppet/commit/66a44ddc3032654109036371a5f3a60dd2ab4a9f 66a44ddc3032654109036371a5f3a60dd2ab4a9f 2009-10-23T14:36:58-07:00 2009-10-05T20:32:38-07:00 type augeas: add 'incl' and 'lens' parameters These parameters allow loading a file anywhere on the filesystem; using them also greatly speeds up processing the resource. * lib/puppet/type/augeas.rb: add 'incl' and 'lens' parameters; change default for 'context' when 'incl' is given. * lib/puppet/provider/augeas/augeas.rb: when 'lens' and 'incl' are given, only load that file * spec/unit/type/augeas.rb: check that constraints on new parameters are enforced This fixes ticket #2694 95f790721ec7b8389f1813ef3fc1d23affb890c1 James Turnbull james@lovedthanlost.net aea1e5fa34412dd843b937263d92c4fab9628b83 Avi Miller avi.miller@gmail.com http://github.com/reductivelabs/puppet/commit/c61335f66f897bc64992c4e9209ea517193c8e30 c61335f66f897bc64992c4e9209ea517193c8e30 2009-10-23T14:36:58-07:00 2009-10-02T04:55:35-07:00 Patch to address feature #2571 to add Oracle support to Puppet Adapter requires specifying database, username and password. Signed-off-by: Avi Miller <avi.miller@gmail.com> 16e53b465cf88fd6162f7e73fea045b189bc0fa9 James Turnbull james@lovedthanlost.net fbdded7647b1b625b5d695ea85b706298924f259 Todd Zullinger tmz@pobox.com http://github.com/reductivelabs/puppet/commit/aea1e5fa34412dd843b937263d92c4fab9628b83 aea1e5fa34412dd843b937263d92c4fab9628b83 2009-10-23T06:59:37-07:00 2009-10-20T10:35:08-07:00 Update Red Hat spec file for 0.25.1 Minor packaging fixes included since 0.25.0: - Include the pi program and man page (R.I.Pienaar) - Move puppetca to puppet package, it has uses on client systems - Drop redundant %doc from manpage %file listings c52897eeac2557a71be9c84974a97a82d9cb0e25 Todd Zullinger tmz@pobox.com 4d9f76ad2653542e53a8020be9eeadb8f354837c Markus Roberts Markus@reality.com http://github.com/reductivelabs/puppet/commit/fbdded7647b1b625b5d695ea85b706298924f259 fbdded7647b1b625b5d695ea85b706298924f259 2009-10-22T21:52:22-07:00 2009-10-08T14:36:20-07:00 Ticket #2685 (Type error in ssh_authorized_keys) In post processing a Symbol was being passed to StringScanner. StringScanner was not happy with this. The error message lost backtrace information and the test coverage was both inadequate and broken (see #2745). To be fully effective, this patch needs/assumes the patch for Signed-off-by: Markus Roberts <Markus@reality.com> e02d12d28534321af7c6fb91bb8932fc406c930a James Turnbull james@lovedthanlost.net b4bcfe9106c43855fbb4d1d147945ddb0e08ab34 Markus Roberts Markus@reality.com http://github.com/reductivelabs/puppet/commit/4d9f76ad2653542e53a8020be9eeadb8f354837c 4d9f76ad2653542e53a8020be9eeadb8f354837c 2009-10-22T21:49:31-07:00 2009-10-21T22:10:02-07:00 Fix for #2745 fakedata tests not working The old fakedata test facility was not playing nicely with the spec tests; although it looped through all the files failures in any example file after the first were being ignored because of the way fakedataparse was interacting with the before blocks. Signed-off-by: Markus Roberts <Markus@reality.com> e6f8d17ba1a8a1f86d0001797074c1478167d91f James Turnbull james@lovedthanlost.net ae528f62e898fac37ea7d37c6fcff2e5c0954782 Markus Roberts Markus@reality.com http://github.com/reductivelabs/puppet/commit/b4bcfe9106c43855fbb4d1d147945ddb0e08ab34 b4bcfe9106c43855fbb4d1d147945ddb0e08ab34 2009-10-21T02:22:47-07:00 2009-10-20T19:52:50-07:00 Fix for #2736, target doesn't work for ssh_authorized_keys There were a number of problems here (duplicated code, meaningless tests, etc.) but the core was that the last definition of target ignored the provided value if there was also a user specified. Signed-off-by: Markus Roberts <Markus@reality.com> d8bd98bb1cd2154488d76a4f2c0847fa1d830224 James Turnbull james@lovedthanlost.net f59f8054dc0d1c86169b954fab96df650f38dd23 Markus Roberts Markus@reality.com http://github.com/reductivelabs/puppet/commit/ae528f62e898fac37ea7d37c6fcff2e5c0954782 ae528f62e898fac37ea7d37c6fcff2e5c0954782 2009-10-19T20:20:31-07:00 2009-10-19T09:25:55-07:00 Ticket #2734 PSON/JSON not serializing classes of a catalog Now it does, there are tests to prove it, and the related tests for tags and version have been strengthend. Signed-off-by: Markus Roberts <Markus@reality.com> df1f2249434b194164d6645090dcad17e628daca Markus Roberts Markus@reality.com 6ba122f62bf22c955a6923604a46a8ab22d8770b Jesse Wolfe jes5199@gmail.com http://github.com/reductivelabs/puppet/commit/f59f8054dc0d1c86169b954fab96df650f38dd23 f59f8054dc0d1c86169b954fab96df650f38dd23 2009-10-19T01:47:07-07:00 2009-10-16T23:45:02-07:00 Bug #1900 Parsing of quoted $ in stdin When code comes in via STDIN or --code , Puppet::Util::Settings interpolates $values in the code, which is probably never the intended behavior. This is the least destructive fix I could think of: have Puppet::Parser::Interpreter ask for the uninterpolated value. More general fixes could be to: a) Add an escape character to Settings's interpolator, and escape STDIN b) Add a mechanism to Settings to mark some values as uninterpolated Signed-off-by: Jesse Wolfe <jes5199@gmail.com> a2de2de0a2c784b6b889b038724a9a05858ee1be James Turnbull james@lovedthanlost.net bca3b70437666a8b840af032cab20fc1ea4f18a2 Luke Kanies luke@madstop.com http://github.com/reductivelabs/puppet/commit/6ba122f62bf22c955a6923604a46a8ab22d8770b 6ba122f62bf22c955a6923604a46a8ab22d8770b 2009-10-18T17:06:28-07:00 2009-10-18T17:06:28-07:00 Fixing #2735 - node classes are immed. added to classlist This commit adds any external node classes to the classlist at compiler initialization, so that at least those classes will be isolated from any ordering issues encountered when testing the contents of the class list during compilation. Signed-off-by: Luke Kanies <luke@madstop.com> 251e36e5753ea15af4a3da4afaea2778fbaa5114 Luke Kanies luke@madstop.com ce46be5773656f68eddc7edd6212e283b46f9320 Markus Roberts Markus@reality.com http://github.com/reductivelabs/puppet/commit/bca3b70437666a8b840af032cab20fc1ea4f18a2 bca3b70437666a8b840af032cab20fc1ea4f18a2 2009-10-16T18:23:33-07:00 2009-10-09T15:23:19-07:00 Bundling of pure ruby json lib as "pson" Bundeling and renaming the pure ruby json library to addresses a number of cross version serliaization bugs (#2615, et al). This patch adds a subset of the files from the json_pure gem to lib/puppet/external/pson (renamed to avoid conflicts with rails) so that we will always have a known-good erialization format available. The pure ruby json gem as distibuted defers to the compiled version if it is installed. This is problematic in some circumstances so the files that have been brought over have been modified to always and only use the bundled version. It's a large patch, so here's a breakdown of the change categories: The majority of the lines are only marginally interesting: * The json lib itself (in lib/puppet/external/pson) make up the bulk of the lines. * Renaming of json to pson make up the second largest group. Somewhat more interesting are the following, which can be located by searching the diffs for the indicated strings: * Adjusting tests to reflect the changes * Changing the encoding/decoding behavior so that nested structures (e.g. resources) don't serialize as escaped strings. This should make it much easier to process the results with external tools, if needed. Search for "to_pson" and "to_pson_data_hash" * Cleaning up the envelope/metadata * Now provides a document_type (as opposed to a ruby class name) by using a symple registration scheme instead of constant lookup (search for "document_type") * Added an api_version (search for "api_version") * Added a hash for document metadata (search for "metadata") * Removing the yaml monkeypatch and instead disabling yaml serialization on ruby 1.8.1 in favor of pson (search for "yaml") * Cleaning up the json/rails feature interaction (they're now totally independent) (search for "feature") 0cde5cd7b39fc5a5e41b636d1f55a7ed71d6518b James Turnbull james@lovedthanlost.net b0518c3938be6cef34eafeb0460116d98b2a64ca Markus Roberts Markus@reality.com http://github.com/reductivelabs/puppet/commit/ce46be5773656f68eddc7edd6212e283b46f9320 ce46be5773656f68eddc7edd6212e283b46f9320 2009-10-16T11:56:40-07:00 2009-09-23T16:58:14-07:00 Proposed alternative solution for #2664 (REGEX / DIV lexing) This is my proposed attack on the lexing problem, with a few minor cleanups to simplify its integration. The strategy: * Anotate tokens with a method "acceptable?" that determines if they can be generated in a given context. Have this default to true. * Give the lexer the notion of a context; initialize it and update it as needed. The present context records the name of the last significant token generated and a start_of_line flag. * When a token is found to match, check if it is acceptable in the present context before generating it. These changes don't result any any change in behaviour but they enable: * Give the REGEX token an acceptable? rule that only permits a regular expression in specific contexts. The other changes were a fix to the scan bug Brice reported, adjusting a test and clearing up some cluttered conditions in the context collection path. Added tests and subsumed change restricting REGEX to one line. e7d752c707fd3520bbeebd7edb6b6dc8059433e9 Markus Roberts Markus@reality.com 8a7308249783fc75d450fc2428cba52a5ad30a10 Markus Roberts Markus@reality.com http://github.com/reductivelabs/puppet/commit/b0518c3938be6cef34eafeb0460116d98b2a64ca b0518c3938be6cef34eafeb0460116d98b2a64ca 2009-10-15T02:43:49-07:00 2009-09-30T15:00:19-07:00 Fix for #2681 (duplicate resource) Refactor to not generate explicit resources and to not bail out if one of a set can not be ensured absend. Signed-off-by: Markus Roberts <Markus@reality.com> c974faa6c80ad4b08b3c76182775abc3e0a4d21a James Turnbull james@lovedthanlost.net 54ded1bd2b8c023d6e480c21f1b2b03f3b7859ba Rein Henrichs reinh@reinh.com http://github.com/reductivelabs/puppet/commit/8a7308249783fc75d450fc2428cba52a5ad30a10 8a7308249783fc75d450fc2428cba52a5ad30a10 2009-10-14T21:58:26-07:00 2009-10-13T18:21:06-07:00 Fix #2707 config_version fails more helpfully Use Puppet::Util.execute to run the config_version command and reraise its potential Puppet::ExecutionFailure exception as a more useful Pupppet::ParseError 8b4b9557fb169fac7a2f12778df09c3b5d864812 James Turnbull james@lovedthanlost.net 4c3c2799364cc970a144c63eb92ae58f086f280c Ohad Levy ohadlevy@gmail.com http://github.com/reductivelabs/puppet/commit/54ded1bd2b8c023d6e480c21f1b2b03f3b7859ba 54ded1bd2b8c023d6e480c21f1b2b03f3b7859ba 2009-10-13T02:50:04-07:00 2009-10-11T19:17:22-07:00 Fixes #1719, this avoids calling the external binary *which* everytime we are looking for a binary d3331a0054079ebf69ee19ec65adbb59d960965c James Turnbull james@lovedthanlost.net