@@ -19,12 +19,13 @@ if (array_key_exists('feedback', $_REQUEST)) {
// suppressed@auma.pair.com or anonymous@auma.pair.com
// FogBugz would try to send them an email and generate another
// ticket telling me "Undelivered Mail Returned to Sender"
- // TODO: It'd be nice to make sure the string looks like a
- // real email address but I'll assume everyone is playing nice.
- if ($_REQUEST['email'] == '') {
- $email = 'YOUR_EMAIL_ADDRESS_HERE@gmail.com';
- } else {
+
+ // Check for well formatted email address, if it's OK use their address in the "from" header, else
+ // use generic support address
+ if (eregi('^[a-zA-Z0-9._-]+@[a-zA-Z0-9-]+\.[a-zA-Z.]{2,5}$', $_REQUEST['email'])) {
$email = $_REQUEST['email'];
+ } else {
+ $email = 'YOUR_EMAIL_ADDRESS_HERE@gmail.com';
}
$feedback = $_REQUEST['feedback'];
$bundleID = $_REQUEST['bundleID'];
jrfeedback.php
88221115a3b511eb1011fc44e6e00ca777bf4e68
Clint Shryock
cshryock@deltasys.com
http://github.com/rentzsch/jrfeedbackprovider/commit/b6b1ab1e629a7be218b805f09bcba177ff6b3407
b6b1ab1e629a7be218b805f09bcba177ff6b3407
2009-07-18T16:10:36-07:00
2009-07-16T14:03:56-07:00
added regular expression to test if the email address supplied is well formed. if so, use supplied email address in the 'from' header, else use generic support email address
Signed-off-by: Jonathan 'Wolf' Rentzsch <jwr.git@redshed.net>
19eb1d2ed886a56e67ae377a271840d64fcb2592
Jonathan 'Wolf' Rentzsch
jwr.git@redshed.net