@@ -48,7 +48,13 @@ // Create the mime multipart boundary. // TODO scan `values` to ensure uniqueness of `boundary`. Loop+regen UUID if collision is discovered. - NSString *uuid = [(id)CFUUIDCreateString(kCFAllocatorDefault, CFUUIDCreate(kCFAllocatorDefault)) autorelease]; + CFUUIDRef cfUuid = CFUUIDCreate(kCFAllocatorDefault); + NSString * uuid = (id)CFUUIDCreateString(kCFAllocatorDefault, cfUuid); + CFRelease(cfUuid); +#if MAC_OS_X_VERSION_MAX_ALLOWED >= MAC_OS_X_VERSION_10_5 + uuid = NSMakeCollectable(uuid); +#endif + uuid = [uuid autorelease]; NSString *boundary = [NSString stringWithFormat:@"x-mime-boundary://%@", uuid]; //-- lib/NSURLRequest+postForm.m c183d9b54bd6e68a73a7f2686de93c95855382a8 Dave Dribin dave@dribin.org http://github.com/rentzsch/jrfeedbackprovider/commit/bd5bf6f528b98d355210594f35c3b7a7740caf3f bd5bf6f528b98d355210594f35c3b7a7740caf3f 2009-05-25T12:54:37-07:00 2009-05-25T12:10:46-07:00 Fix leaked return of CFUUIDCreate() (reported by clang static analyzer). Also make GC dual-mode safe by calling NSMakeCollectable() on return of CFUUIDCreateString() Signed-off-by: Jonathan 'Wolf' Rentzsch <jwr.git@redshed.net> 86fcc037a472c9df10401ca28d4749a5d0364267 Jonathan 'Wolf' Rentzsch jwr.git@redshed.net