riotfamily / riot

As discussed in the online conference:

1.) JavaScript Errors like "Das Objekt unterstützt diese Eigenschaft oder Methode nicht." breaks

 some functions of the toolbar

2.) IE7: Add-Component couldn't render the component list (a gray line is rendered instead)

When indent is set to false on a nested form, that contains only one single element the label is not rendered. The code causing this unexpected behavior is here:

NestedForm_noindent.ftl, line 11:

<#if element.label?? && (elements.elements?size > 1)>

I assume that the original intention was to support wrapping a nested-form around an (anonymous?) element to explicitly set the value to null (see dgmsgsrc -> messageBundleEntry -> defaultMessage). However the label is shown there though it shouldn't.

Ants are only rendered onmouseenter which is not fired when leaving a nested element. Fix: elements should be pushed on a stack when entered and popped on leave.

As the parent is mapped reverse, the moved ContentPage is not updated itself. This is why the onUpdate method of the LifeCycle is not called, leaving the pages path untouched. The overall result is that the page is being moved in the sitemap, but its request URL is left unchanged.

If no specific image height is set, the preview frame has a height of 100px and is not expandable through dragging and clicking which makes it impossible to crop images that are supposed to have a height of more than 100px

In notification popups keys for message bundle are null, and in search form all strings are hard-coded and have no keys for message bundle at all.

"required" and "regex" properties for textfield tag don't show any error messages in form, if this textfield tag surrounded by "editable-if-new" tag.

When the image configuration has both (min & max) values for width and height, the corner is moveable on the x-axix only, but never on the y-axis to make the image smaller. I.E. 100-600 px×100-600 px

Test configuration:
<media:image-upload min-width="100" min-height="100" max-width="600" max-height="600" />

If new richtext chunks are created, one is able to edit the chunks but not to remove them. After a page reload everything works as expected again.

Like in pre-9.0 versions it should be possible to choose a particular backoffice form by an discriminator value of a bean property. It would be great if java enums would be supported as discriminator.

I've just noticed that the "preserve focus" functionality after form save with CTRL+s doesn't work.

The problem lies in the function save(stayInForm) of form.ftl which creates hidden "focus" element used to return focus to correct element after form is reloaded.
The value that is currently submitted is textual representation of the component i.e. [HTMLTextElement]. What we really want to send here is the id property of the activeElement instead.

My fix was to change save() function to:

        function save(stayInForm) {
            if (stayInForm) {
                form.insert(new Element('input', {
                    type: 'hidden', 
                    name: 'focus', 
                    value: (document.activeElement.id) ? document.activeElement.id.match(/^e\d+/g) : null}));
            }
            Element.addClassName(document.body, 'busy');
            form.down('input.button-save').click();
        }

As you can see, I modified the code to send the id of the component. This id is matched for pattern (^e\d+) which is for a valid element of the form. This works quite well even for cases when you have richtext, which is dynamically generated element.
In order to avoid the NullPointerException in the above Javascript we need to always have the document.activeElement property set. Therefore, we also need to change the focus listener in the form.ftl to:

        if (document.addEventListener && typeof document.activeElement == 'undefined') {
            document.addEventListener("focus", function(e) {
                if (e && e.target) {
                    document.activeElement = e.target;
                }
            }, true);
        } 

I hope you can include the fix for this issue in the 9.0.x branch.

I have following filter form with initializer:

<form id="filter-documents" bean-class="Document" 
    initializer-class="DocumentFormInitializer">
    <selectbox bind="website" label-property="website" choose-label="All...">
        <options ref="restrictedStagingHqlOptionsModel">
            <property name="hql" value="from Website" />
        </options>
    </selectbox>
    <our:menufield bind="currentMenu" />
</form>

Within the initializer I add change listener to the selectbox which
triggers change in the menufield. Currently, this works as expected on forms
but doesn't work in the filter forms since (1) the events are not propagated
at all and (2) the initializer actually is never initialized.

We've noticed that there are some problems in how split buttons are shown in IE8 (i.e. when using spellchecker plugin)
The patch below (based on tinymce 3.2.7's ui.css) solves the the issue:

*** ui.css.orig 2010-03-31 17:58:27.269476452 +0200 --- ui.css 2010-03-31 17:47:13.000000000 +0200

* 21,27 ** .riotSkin table.mceToolbar, .riotSkin tr.mceFirst .mceToolbar tr td, .riotSkin tr.mceLast .mceToolbar tr td {border:0; margin:0; padding:0;} .riotSkin td.mceToolbar {padding-top:1px; vertical-align:top;background:#ebebeb;} .riotSkin .mceIframeContainer {border-top:1px solid #CCC; border-bottom:1px solid #CCC} ! .riotSkin .mceStatusbar {font:11px'Lucida Grande',Helvetica,Arial,sans-serif; overflow:visible; color:#666; display:block; height:20px} .riotSkin .mceStatusbar div {float:left; margin:3px 0 0 4px; color:#666;} .riotSkin .mceStatusbar a.mceResize {display:block; float:right; background:url('img/icons.png') -801px -2px; width:20px; height:20px; cursor:se-resize} .riotSkin .mceStatusbar a:hover {text-decoration:underline} --- 21,27 ---- .riotSkin table.mceToolbar, .riotSkin tr.mceFirst .mceToolbar tr td, .riotSkin tr.mceLast .mceToolbar tr td {border:0; margin:0; padding:0;} .riotSkin td.mceToolbar {padding-top:1px; vertical-align:top;background:#ebebeb;} .riotSkin .mceIframeContainer {border-top:1px solid #CCC; border-bottom:1px solid #CCC} ! .riotSkin .mceStatusbar {font:11px'Lucida Grande',Helvetica,Arial,sans-serif; line-height:16px; overflow:visible; color:#666; display:block; height:20px} .riotSkin .mceStatusbar div {float:left; margin:3px 0 0 4px; color:#666;} .riotSkin .mceStatusbar a.mceResize {display:block; float:right; background:url('img/icons.png') -801px -2px; width:20px; height:20px; cursor:se-resize} .riotSkin .mceStatusbar a:hover {text-decoration:underline}

* 36,42 ** .riotSkin .mceButton {display:block; border:1px solid transparent; width:20px; height:20px; margin-right:1px} .riotSkin a.mceButtonEnabled:hover {border:1px solid #ccc; background-color:#F1F1F1} .riotSkin a.mceButtonActive, .riotSkin a.mceButtonSelected {border:1px solid #ccc; background-color:#F1F1F1} ! .riotSkin .mceButtonDisabled .mceIcon {opacity:0.3; filter:alpha(opacity=30)} .riotSkin .mceButtonLabeled {width:auto} .riotSkin .mceButtonLabeled span.mceIcon {float:left} .riotSkin span.mceButtonLabel {display:block; font-size:10px; padding:4px 6px 0 22px; font-family:Tahoma,Verdana,Arial,Helvetica} --- 36,42 ---- .riotSkin .mceButton {display:block; border:1px solid transparent; width:20px; height:20px; margin-right:1px} .riotSkin a.mceButtonEnabled:hover {border:1px solid #ccc; background-color:#F1F1F1} .riotSkin a.mceButtonActive, .riotSkin a.mceButtonSelected {border:1px solid #ccc; background-color:#F1F1F1} ! .riotSkin .mceButtonDisabled .mceIcon {opacity:0.3; -ms-filter:'alpha(opacity=30)'; filter:alpha(opacity=30)} .riotSkin .mceButtonLabeled {width:auto} .riotSkin .mceButtonLabeled span.mceIcon {float:left} .riotSkin span.mceButtonLabel {display:block; font-size:10px; padding:4px 6px 0 22px; font-family:Tahoma,Verdana,Arial,Helvetica}

* 63,74 ** .riotSkin .mceSplitButton a, .riotSkin .mceSplitButton span {height:20px; display:block} .riotSkin .mceSplitButton a.mceAction {width:20px; border:1px solid #F0F0EE; border-right:0;} .riotSkin .mceSplitButton span.mceAction {width:20px; background:url('img/icons.png') 20px 20px;} ! .riotSkin .mceSplitButton a.mceOpen {width:9px; border:1px solid #F0F0EE;} ! .riotSkin .mceSplitButton span.mceOpen {width:9px; background:url('img/icons.png') -741px 0;} .riotSkin table.mceSplitButtonEnabled:hover a.mceAction, .riotSkin .mceSplitButtonHover a.mceAction, .riotSkin .mceSplitButtonSelected a.mceAction {border:1px solid #0A246A; border-right:0; background-color:#B2BBD0} ! .riotSkin table.mceSplitButtonEnabled:hover a.mceOpen, .riotSkin .mceSplitButtonHover a.mceOpen, .riotSkin .mceSplitButtonSelected a.mceOpen {border:1px solid #0A246A;} ! .riotSkin table.mceSplitButtonEnabled:hover span.mceOpen, .riotSkin .mceSplitButtonHover span.mceOpen, .riotSkin .mceSplitButtonSelected span.mceOpen {background-color:#B2BBD0} ! .riotSkin .mceSplitButtonDisabled .mceAction, .riotSkin .mceSplitButtonDisabled span.mceOpen {opacity:0.3; filter:alpha(opacity=30)} .riotSkin .mceSplitButtonActive a.mceAction {border:1px solid #0A246A; background-color:#C2CBE0} .riotSkin .mceSplitButtonActive a.mceOpen {border-left:0;}

--- 63,74 ---- .riotSkin .mceSplitButton a, .riotSkin .mceSplitButton span {height:20px; display:block} .riotSkin .mceSplitButton a.mceAction {width:20px; border:1px solid #F0F0EE; border-right:0;} .riotSkin .mceSplitButton span.mceAction {width:20px; background:url('img/icons.png') 20px 20px;} ! .riotSkin .mceSplitButton a.mceOpen {width:9px; background:url(img/icons.png) -741px 0; border:1px solid #F0F0EE;} ! .riotSkin .mceSplitButton span.mceOpen {display:none} ! .riotSkin table.mceSplitButtonEnabled:hover a.mceAction, .riotSkin .mceSplitButtonHover a.mceAction, .riotSkin .mceSplitButtonSelected a.mceAction {border:1px solid #0A246A; border-right:0; background-color:#B2BBD0} ! .riotSkin table.mceSplitButtonEnabled:hover a.mceOpen, .riotSkin .mceSplitButtonHover a.mceOpen, .riotSkin .mceSplitButtonSelected a.mceOpen {background-color:#B2BBD0; border:1px solid #0A246A;} ! .riotSkin .mceSplitButtonDisabled .mceAction, .riotSkin .mceSplitButtonDisabled a.mceOpen {opacity:0.3; -ms-filter:'alpha(opacity=30)'; filter:alpha(opacity=30)} .riotSkin .mceSplitButtonActive a.mceAction {border:1px solid #0A246A; background-color:#C2CBE0} .riotSkin .mceSplitButtonActive a.mceOpen {border-left:0;}

* 106,112 ** .riotSkin .mceMenuItemSub a {background:url('img/menu-arrow.png') no-repeat top right;}

/ Progress,Resize / ! .riotSkin .mceBlocker {position:absolute; left:0; top:0; z-index:1000; opacity:0.5; filter:alpha(opacity=50); background:#FFF} .riotSkin .mceProgress {position:absolute; left:0; top:0; z-index:1001; background:url('img/progress.gif') no-repeat; width:32px; height:32px; margin:-16px 0 0 -16px} .riotSkin .mcePlaceHolder {border:1px dotted gray}

--- 106,112 ---- .riotSkin .mceMenuItemSub a {background:url('img/menu-arrow.png') no-repeat top right;}

/ Progress,Resize / ! .riotSkin .mceBlocker {position:absolute; left:0; top:0; z-index:1000; opacity:0.5; -ms-filter:'alpha(opacity=50)'; filter:alpha(opacity=50); background:#FFF} .riotSkin .mceProgress {position:absolute; left:0; top:0; z-index:1001; background:url('img/progress.gif') no-repeat; width:32px; height:32px; margin:-16px 0 0 -16px} .riotSkin .mcePlaceHolder {border:1px dotted gray}

Currently, there is code in list.js that adds "busy" to the body
class when commands are executed. This works quite well, but there
is no placeholder for showing the "Please wait ..." message, so
the only way to have it is using screenlet containing code:

 <@c.message "label.busy">Please wait ...</@c.message>

on every list and form.

(In case you wonder why placeholder, I tried only to change the cursor to wait on busy, but that doesn't work properly with IE8,
so I thought that good old "Please wait..." message should do
the job much better...)

Also the body class doesn't get changed when user clicks on
save in the forms. I suggest the following improvements:

1) Add dummy and hidden container to the screen.ftl:

<div id="busy_indicator">
  <@c.message "label.busy">Please wait ...</@c.message>
</div>

also make it hidden as default in common.css:

#busy_indicator {
  display: none;
  position: absolute;
  right: 20px; 
  top: 0px;
  padding: 2px 4px;
  background-color: ${error_color};
  color: #FFFFFF;
  z-index: 2000;
}

2) To indicate that user is saving a form (CTRL+S or save button),
add following code to function save(stayInForm):(line 54) just before a call to form.down():

<code>Element.addClassName(document.body, 'busy');</code>

3) To indicate that user us using a filter or page browsing on a list page add
calls to setBusy() and setIdle() to list.js function updateRowsAndPager().

4) Add support in resources.js to have global LOADING and LOADED states indicating that all css and js have been loaded, which can be hooked into using callbacks.

The Goto Site command does not work correctly when the application is running on other ports than 80/443 because the port number is not included in the absolute URL being constructed. Consider using the port of the current request (if available) or make it configurable via application.properties.

ReverseHandlerMappings should support URL-resolution of handlers with multiple @RequestMapping annotations.

Currently the choose button is only available on the specified target list. It would be nice if one could select items from higher-level lists if they are assignment-compatible. This must of course be configurable - an option might be to specify multiple target lists.

Currently pages in the sitemap can only be cut but not copied.

When cropping is disabled, the image should be shown zoomed out initialilly. This improves the handling of large images in the back office

Currently all UI labels are read from a MessageSource. As most applications only use a single language for their admin interface it would be convenient if one could specify labels directly.

After the server has been restarted, the open list views (such as commands inside sitemap) don't work correctly. List has to be refreshed.

Currently when server is restarted our users loose all work in progress since they get automatically redirected to the login page. This is caused by the implementation of the dwr.engine.setTextHtmlHandler in list.js that currently looks like this:

dwr.engine.setTextHtmlHandler(function() {

  location.reload();

});

Possible solution:

Make user-friendly warning about session being expired and allow user to copy data before he/she is forced to login again:

dwr.engine.setTextHtmlHandler(function(pageData) {

riot.notification.show({"icon":"","autohide": false, "duration" : 600, "title":"Session expired", "message":"Your session has expired! <br />Please save your work to an empty notepad and login again by <a href=\"#\" onclick=\"location.reload()\">reloading</a> this page."});

});

Original issue title: minifyCSS and minifyScript controllers are not working

I get following error message when running riotfamily.

Expression pathForHandler("minifyScriptController") is undefined on line 375, column 41 in classpath:org/riotfamily/common/web/macro/common.ftl.
The problematic instruction:
----------
==> macro resource [on line 81, column 1 in classpath:org/riotfamily/common/web/macro/common.ftl]
 in user-directive c.scripts [on line 44, column 9 in classpath:org/riotfamily/core/view/riot.ftl]
 in user-directive riot.scripts [on line 5, column 9 in classpath:/org/riotfamily/core/security/ui/LoginForm.ftl]
----------

After spending some time debugging this issue it seems the problem is with the {version} in riot-core/riot-servlet.xml where the bean minifyScript is defined:

<bean id="minifyScriptController" name="/resources/{version}/joined.js" class="org.riotfamily.common.web.performance.MinifyScriptController">
    <description>
        Controller to compress (minify) JavaScript files.
    </description>
    <constructor-arg ref="javaScriptCompressor" />
</bean>

The same problem is with the minifyCSSController...
My workaround so far has been overriding current controller with the same mapping but without version: name="/resources/joined.js". That seems to work just fine, but it would be nice to see this issue solved "properly".

At current in 9 if you want to add custom commands to lists, overriding these is not possible unless the list itself is defined as a toplevel bean. Use case is to add a custom command to the "sites" list.

Message Bundle Entries shall be escaped when rendered if possible

It would be nice, if one could have different content forms, depending on the context path.

Example:

<p:system-page name="searches" path-component="search" handler="folderController">

            <p:system-page name="one" handler="searchPageController" form="searchForm">
                <p:type name="waitingScreen" > 
                 <p:handler>
                      <bean class="org.riotfamily.common.web.controller.CacheableViewController" >
                             <property name="viewName" value="pages/common/static.ftl" />
                      </bean>
                 </p:handler>
                </p:type>
            </p:system-page>
            <p:system-page name="two" handler="searchPageController">
                <p:type-ref name="waitingScreen" />
            </p:system-page>
            <p:type name="three" handler="searchPageController" >
                 <p:type-ref name="waitingScreen" />
            </p:type>         
        </p:system-page>

"waitingScreen" works well for page "one" and "two" but for type "three" it leads to:

Caused by: java.lang.IllegalArgumentException: Referenced type not found: waitingScreen

at org.springframework.util.Assert.notNull(Assert.java:112)
at org.riotfamily.pages.config.PageTypeRef.register(PageTypeRef.java:22)
at org.riotfamily.pages.config.AbstractPageType.register(AbstractPageType.java:86)
at org.riotfamily.pages.config.AbstractPageType.register(AbstractPageType.java:86)
at org.riotfamily.pages.config.SystemPageType.register(SystemPageType.java:107)
at org.riotfamily.pages.config.SystemPageType.register(SystemPageType.java:110)
at org.riotfamily.pages.config.SitemapSchema.setRootPage(SitemapSchema.java:95)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
at java.lang.reflect.Method.invoke(Method.java:597)
at org.springframework.beans.BeanWrapperImpl.setPropertyValue(BeanWrapperImpl.java:1101)
... 49 more