@@ -10,7 +10,7 @@ module StripAttributes end end end - + # Necessary because Rails has removed the narrowing of attributes using :only # and :except on Base#attributes def self.narrow(attributes, options) @@ -25,7 +25,7 @@ module StripAttributes attributes.slice(*only) else raise ArgumentError, "Options does not specify :except or :only (#{options.keys.inspect})" - end + end end end end lib/strip_attributes.rb @@ -2,10 +2,11 @@ require "#{File.dirname(__FILE__)}/test_helper" module MockAttributes def self.included(base) - base.column :foo, :string - base.column :bar, :string - base.column :biz, :string - base.column :baz, :string + base.column :foo, :string + base.column :bar, :string + base.column :biz, :string + base.column :baz, :string + base.column :bang, :string end end @@ -36,7 +37,7 @@ end class StripAttributesTest < Test::Unit::TestCase def setup - @init_params = { :foo => "\tfoo", :bar => "bar \t ", :biz => "\tbiz ", :baz => "" } + @init_params = { :foo => "\tfoo", :bar => "bar \t ", :biz => "\tbiz ", :baz => "", :bang => " " } end def test_should_exist @@ -50,6 +51,7 @@ class StripAttributesTest < Test::Unit::TestCase assert_equal "bar", record.bar assert_equal "biz", record.biz assert_nil record.baz + assert_nil record.bang end def test_should_strip_only_one_field @@ -59,6 +61,7 @@ class StripAttributesTest < Test::Unit::TestCase assert_equal "bar \t ", record.bar assert_equal "\tbiz ", record.biz assert_equal "", record.baz + assert_equal " ", record.bang end def test_should_strip_only_three_fields @@ -68,6 +71,7 @@ class StripAttributesTest < Test::Unit::TestCase assert_equal "bar", record.bar assert_equal "biz", record.biz assert_equal "", record.baz + assert_equal " ", record.bang end def test_should_strip_all_except_one_field @@ -77,6 +81,7 @@ class StripAttributesTest < Test::Unit::TestCase assert_equal "bar", record.bar assert_equal "biz", record.biz assert_nil record.baz + assert_nil record.bang end def test_should_strip_all_except_three_fields @@ -86,5 +91,6 @@ class StripAttributesTest < Test::Unit::TestCase assert_equal "bar \t ", record.bar assert_equal "\tbiz ", record.biz assert_nil record.baz + assert_nil record.bang end end test/strip_attributes_test.rb 618e3c88cb5f12300f2f14086cc6a77920df0a87 Erik Bryn ebryn@marketmonitors.com http://github.com/rmm5t/strip_attributes/commit/3448cfd0ad3aaa110dbca94b2f1dc741c8bc95e0 3448cfd0ad3aaa110dbca94b2f1dc741c8bc95e0 2009-04-16T14:30:08-07:00 2009-04-15T19:34:06-07:00 Added tests for solely whitespace filled strings 9a3b24852103968f2db34b4b65671227f9c334c9 Ryan McGeary ryanongit@mcgeary.org