Fix XSS in $file_extension #8193
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks. I fixed it using a different function in bdb3165. |
Ma27
added a commit
to Ma27/nixpkgs
that referenced
this pull request
Nov 13, 2021
ChangeLog: https://github.com/roundcube/roundcubemail/releases/tag/1.4.12 This fixes a XSS[1] and a SQL-injection[2] vulnerability. Both are already fixed on 1.5.0 which is available on `nixos-unstable`[3]. [1] roundcube/roundcubemail#8193 [2] roundcube/roundcubemail@4e1358b [3] https://nixpk.gs/pr-tracker.html?pr=142148
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is possible to inject arbitrary html/js code through attachment's $file_extension variable that will be executed while displaying "attachmentvalidationerror" warning.