Close #1669 (#1670)

* Close #1669

* Fix test

Author: Hosch250

RetailCoder.VBE/Inspections/ParameterCanBeByValInspection.cs

@@ -1,6 +1,5 @@
 using System.Collections.Generic;
 using System.Linq;
-using System.Windows.Threading;
 using Rubberduck.Common;
 using Rubberduck.Parsing.Grammar;
 using Rubberduck.Parsing.Symbols;
@@ -13,11 +12,8 @@ public sealed class ParameterCanBeByValInspection : InspectionBase
         public ParameterCanBeByValInspection(RubberduckParserState state)
             : base(state, CodeInspectionSeverity.Suggestion)
         {
-            _dispatcher = Dispatcher.CurrentDispatcher;
         }
 
-        private readonly Dispatcher _dispatcher;
-
         public override string Meta { get { return InspectionsUI.ParameterCanBeByValInspectionMeta; } }
         public override string Description { get { return InspectionsUI.ParameterCanBeByValInspectionName; } }
         public override CodeInspectionType InspectionType { get { return CodeInspectionType.CodeQualityIssues; } }

RetailCoder.VBE/Inspections/ParameterCanBeByValInspectionResult.cs

@@ -36,12 +36,12 @@ public PassParameterByValueQuickFix(ParserRuleContext context, QualifiedSelectio
 
         public override void Fix()
         {
-            var parameter = Context.GetText();
+            var parameter = Context.Parent.GetText();
             var newContent = string.Concat(Tokens.ByVal, " ", parameter.Replace(Tokens.ByRef, string.Empty).Trim());
             var selection = Selection.Selection;
 
             var module = Selection.QualifiedName.Component.CodeModule;
-            var lines = module.get_Lines(selection.StartLine, selection.LineCount);
+            var lines = module.Lines[selection.StartLine, selection.LineCount];
 
             var result = lines.Replace(parameter, newContent);
             module.ReplaceLine(selection.StartLine, result);

RubberduckTests/Inspections/ParameterCanBeByValInspectionTests.cs

@@ -197,10 +197,10 @@ public void ParameterCanByByVal_ReturnsResult_QuickFixWorks_PassedByUnspecified(
 
         [TestMethod]
         [TestCategory("Inspections")]
-        public void ParameterCanByByVal_ReturnsResult_QuickFixWorks_PassedByRefUnassigned()
+        public void ParameterCanByByVal_ReturnsResult_QuickFixWorks_PassedByRef()
         {
             const string inputCode =
-@"Sub Foo(arg1 As String)
+@"Sub Foo(ByRef arg1 As String)
 End Sub";
 
             const string expectedCode =