disable logging by default

Andrin Meier · Andrin Meier · commit 171f113fa792 · 2016-05-30T20:13:56.000+02:00
diff --git a/RetailCoder.VBE/App.cs b/RetailCoder.VBE/App.cs
@@ -65,6 +65,9 @@ public App(VBE vbe, IMessageBox messageBox,
             _indenter = indenter;
             _hooks = hooks;
             _logger = LogManager.GetCurrentClassLogger();
+            // Anyone else could be starting a parse task before we get to disable logging (if the user has configured it so)
+            // that is why we are conservative and disable logging by default.
+            LogManager.DisableLogging();
 
             _hooks.MessageReceived += _hooks_MessageReceived;
             _configService.SettingsChanged += _configService_SettingsChanged;
@@ -145,7 +148,6 @@ private void UpdateLoggingLevel()
             {
                 return;
             }
-            LogManager.EnableLogging();
             LogLevelHelper.SetMinimumLogLevel(fileRule, LogLevel.FromOrdinal(_config.UserSettings.GeneralSettings.MinimumLogLevel));
         }
 

Original file line number	Diff line number	Diff line change
`@@ -65,6 +65,9 @@ public App(VBE vbe, IMessageBox messageBox,`
`65`	`65`	`_indenter = indenter;`
`66`	`66`	`_hooks = hooks;`
`67`	`67`	`_logger = LogManager.GetCurrentClassLogger();`
	`68`	`+ // Anyone else could be starting a parse task before we get to disable logging (if the user has configured it so)`
	`69`	`+ // that is why we are conservative and disable logging by default.`
	`70`	`+ LogManager.DisableLogging();`
`68`	`71`
`69`	`72`	`_hooks.MessageReceived += _hooks_MessageReceived;`
`70`	`73`	`_configService.SettingsChanged += _configService_SettingsChanged;`
`@@ -145,7 +148,6 @@ private void UpdateLoggingLevel()`
`145`	`148`	`{`
`146`	`149`	`return;`
`147`	`150`	`}`
`148`		`- LogManager.EnableLogging();`
`149`	`151`	`LogLevelHelper.SetMinimumLogLevel(fileRule, LogLevel.FromOrdinal(_config.UserSettings.GeneralSettings.MinimumLogLevel));`
`150`	`152`	`}`
`151`	`153`