From ad162f1a8aa5b3bdd25bbb350ddb529dc1f17403 Mon Sep 17 00:00:00 2001 From: Mathieu Guindon Date: Tue, 20 Apr 2021 09:24:46 -0400 Subject: [PATCH] added more tests --- ...icitActiveSheetReferenceInspectionTests.cs | 21 +++++++++++++++++++ ...ContainingSheetreferenceInspectionTests.cs | 16 ++++++++++++++ 2 files changed, 37 insertions(+) diff --git a/RubberduckTests/Inspections/ImplicitActiveSheetReferenceInspectionTests.cs b/RubberduckTests/Inspections/ImplicitActiveSheetReferenceInspectionTests.cs index e70b802e7d..d8e5abee28 100644 --- a/RubberduckTests/Inspections/ImplicitActiveSheetReferenceInspectionTests.cs +++ b/RubberduckTests/Inspections/ImplicitActiveSheetReferenceInspectionTests.cs @@ -154,6 +154,27 @@ End Sub Assert.AreEqual(0, InspectionResultsForModules(modules, ReferenceLibrary.Excel, DefaultDocumentModuleSupertypeNames).Count()); } + [Test] + [Category("Inspections")] + public void ImplicitActiveSheetReference_NoResultForWorksheetFunction() + { + const string inputCode = + @"Sub foo() + Debug.Print GetSheet.Cells(1, 1) +End Sub + +Private Function GetSheet() As Worksheet +End Function +"; + var modules = new (string, string, ComponentType)[] + { + ("ThisWorkbook", string.Empty, ComponentType.Document), + ("Sheet1", string.Empty, ComponentType.Document), + ("Module1", inputCode, ComponentType.StandardModule) + }; + Assert.AreEqual(0, InspectionResultsForModules(modules, ReferenceLibrary.Excel, DefaultDocumentModuleSupertypeNames).Count()); + } + [Test] [Category("Inspections")] public void ImplicitActiveSheetReference_Ignored_DoesNotReportRange() diff --git a/RubberduckTests/Inspections/ImplicitContainingSheetreferenceInspectionTests.cs b/RubberduckTests/Inspections/ImplicitContainingSheetreferenceInspectionTests.cs index c5b7e36e7a..9eba2969e3 100644 --- a/RubberduckTests/Inspections/ImplicitContainingSheetreferenceInspectionTests.cs +++ b/RubberduckTests/Inspections/ImplicitContainingSheetreferenceInspectionTests.cs @@ -126,6 +126,22 @@ End Sub Assert.AreEqual(0, InspectionResultsInWorksheet(inputCode).Count()); } + [Test] + [Category("Inspections")] + public void ImplicitContainingSheetReference_NoResultForWorksheetFunction() + { + const string inputCode = +@"Sub foo() + Dim arr1 As Variant + arr1 = GetSheet.Range(""A1:B2"") +End Sub + +Function GetSheet() As Worksheet +End Function +"; + Assert.AreEqual(0, InspectionResultsInWorksheet(inputCode).Count()); + } + [Test] [Category("Inspections")] public void InspectionName()