Merge branch 'next' into Issue1807

Author: Hosch250

RetailCoder.VBE/Inspections/ImplicitActiveSheetReferenceInspection.cs

@@ -36,7 +36,9 @@ public override IEnumerable<InspectionResultBase> GetInspectionResults()
             }
 
             var matches = BuiltInDeclarations.Where(item =>
-                Targets.Contains(item.IdentifierName)).ToList();
+                        Targets.Contains(item.IdentifierName) &&
+                        item.ParentScope == "EXCEL.EXE;Excel._Global" &&
+                        item.AsTypeName == "Range").ToList();
 
             var issues = matches.Where(item => item.References.Any())
                 .SelectMany(declaration => declaration.References);

RetailCoder.VBE/UI/CodeExplorer/CodeExplorerControl.xaml

@@ -676,7 +676,7 @@
                                   IsCheckable="True" />
                         <MenuItem Name="SortBySelection"
                                   Style="{DynamicResource MenuItemStyle}" VerticalAlignment="Center" 
-                                  Header="{Resx ResxName=Rubberduck.UI.RubberduckUI, Key=SortStyle_BySelection}"
+                                  Header="{Resx ResxName=Rubberduck.UI.RubberduckUI, Key=SortStyle_ByCodeOrder}"
                                   IsChecked="{Binding SortBySelection, UpdateSourceTrigger=PropertyChanged}" 
                                   Command="{Binding SetSelectionSortCommand}"
                                   CommandParameter="{Binding ElementName=SortBySelection, Path=IsChecked}"

RetailCoder.VBE/UI/RubberduckUI.Designer.cs

@@ -1578,8 +1578,8 @@ All our stargazers, likers & followers, for the warm fuzzies
   <data name="SortStyle_ByType" xml:space="preserve">
     <value>By type</value>
   </data>
-  <data name="SortStyle_BySelection" xml:space="preserve">
-    <value>By selection</value>
+  <data name="SortStyle_ByCodeOrder" xml:space="preserve">
+    <value>By code order</value>
   </data>
   <data name="CodeExplorer_RefreshComponent" xml:space="preserve">
     <value>Refresh component</value>

RetailCoder.VBE/UI/RubberduckUI.resx

@@ -119,6 +119,11 @@ private IExpressionBinding Visit(Declaration module, Declaration parent, VBAPars
             return new SimpleNameDefaultBinding(_declarationFinder, Declaration.GetProjectParent(parent), module, parent, expression, Identifier.GetName(expression.identifier()), statementContext);
         }
 
+        private IExpressionBinding Visit(Declaration module, Declaration parent, VBAParser.IdentifierValueContext expression, IBoundExpression withBlockVariable, StatementResolutionContext statementContext)
+        {
+            return new SimpleNameDefaultBinding(_declarationFinder, Declaration.GetProjectParent(parent), module, parent, expression, Identifier.GetName(expression), statementContext);
+        }
+
         private IExpressionBinding Visit(Declaration module, Declaration parent, VBAParser.MemberAccessExprContext expression, IBoundExpression withBlockVariable, StatementResolutionContext statementContext)
         {
             dynamic lExpression = expression.lExpression();

Rubberduck.Parsing/Binding/DefaultBindingContext.cs

@@ -104,6 +104,19 @@ public bool IsGlobalClassModule
                     attributeIsGlobalClassModule = value.Single() == "True";
                 }
                 _isGlobal = attributeIsGlobalClassModule;
+
+                if (!_isGlobal.Value)
+                {
+                    foreach (var type in Subtypes)
+                    {
+                        if (type is ClassModuleDeclaration && ((ClassModuleDeclaration) type).IsGlobalClassModule)
+                        {
+                            _isGlobal = true;
+                            break;
+                        }
+                    }
+                }
+
                 return _isGlobal.Value;
             }
         }

Rubberduck.Parsing/Symbols/ClassModuleDeclaration.cs

@@ -207,6 +207,11 @@ public List<Declaration> GetDeclarationsForReference(Reference reference)
                     attributes.AddPredeclaredIdTypeAttribute();
                 }
 
+                if (typeAttributes.wTypeFlags.HasFlag(TYPEFLAGS.TYPEFLAG_FAPPOBJECT))
+                {
+                    attributes.AddGlobalClassAttribute();
+                }
+
                 Declaration moduleDeclaration;
                 switch (typeDeclarationType)
                 {

Rubberduck.Parsing/Symbols/ReferencedDeclarationsCollector.cs

@@ -39,5 +39,10 @@ public void AddPredeclaredIdTypeAttribute()
         {
             Add("VB_PredeclaredId", new[] {"True"});
         }
+
+        public void AddGlobalClassAttribute()
+        {
+            Add("VB_GlobalNamespace", new[] {"True"});
+        }
     }
 }

Rubberduck.Parsing/VBA/Attributes.cs

@@ -1957,6 +1957,26 @@ End Sub
             Assert.AreEqual(4, declaration.References.Count());
         }
 
+        [TestMethod]
+        public void FieldLengthStmt_IsReferenceToLocalVariable()
+        {
+            // arrange
+            var code = @"
+Public Sub Test()
+    Const Len As Integer = 4
+    Dim a As String * Len
+End Sub
+";
+            // act
+            var state = Resolve(code);
+
+            // assert
+            var declaration = state.AllUserDeclarations.Single(item =>
+                item.DeclarationType == DeclarationType.Constant && item.IdentifierName == "Len");
+
+            Assert.AreEqual(1, declaration.References.Count());
+        }
+
         // Ignored because handling forms/hierarchies is an open issue.
         [Ignore]
         [TestMethod]