Fix test for assignments inside For Each statements

Author: comintern

Rubberduck.CodeAnalysis/Inspections/Concrete/VariableRequiresSetAssignmentEvaluator.cs

@@ -42,7 +42,8 @@ public static bool RequiresSetAssignment(IdentifierReference reference, Rubberdu
             }
 
             // For Each iterators are implicitly set.
-            if (reference.Context.GetAncestor<VBAParser.ForEachStmtContext>() != null)
+            var letStmtContext = reference.Context.GetAncestor<VBAParser.LetStmtContext>();
+            if (reference.Context.GetAncestor<VBAParser.ForEachStmtContext>() != null && letStmtContext == null)
             {
                 return false;
             }
@@ -60,9 +61,7 @@ public static bool RequiresSetAssignment(IdentifierReference reference, Rubberdu
                 return parameters != null && parameters.All(p => p.IsOptional);
             }
 
-            // assigned declaration is a variant. we need to know about the RHS of the assignment.
-
-            var letStmtContext = reference.Context.GetAncestor<VBAParser.LetStmtContext>();
+            // assigned declaration is a variant. we need to know about the RHS of the assignment.           
             if (letStmtContext == null)
             {
                 // not an assignment

RubberduckTests/Inspections/ObjectVariableNotSetInspectionTests.cs

@@ -398,6 +398,58 @@ For Each foo In bar
             AssertInputCodeYieldsExpectedInspectionResultCount(input, expectResultCount);
         }
 
+        [Test]
+        [Category("Inspections")]
+        public void ObjectVariableNotSet_ForEachObject_ReturnsNoResult()
+        {
+
+            var expectResultCount = 0;
+            var input =
+                @"
+Private Sub Test()
+    Dim bar As Object
+    For Each foo In bar
+    Next
+End Sub";
+            AssertInputCodeYieldsExpectedInspectionResultCount(input, expectResultCount);
+        }
+
+        [Test]
+        [Category("Inspections")]
+        public void ObjectVariableNotSet_InsideForEachObject_ReturnsResult()
+        {
+
+            var expectResultCount = 1;
+            var input =
+                @"
+Private Sub Test()
+    Dim bar As Variant
+    Dim baz As Object
+    For Each foo In bar
+        baz = foo
+    Next
+End Sub";
+            AssertInputCodeYieldsExpectedInspectionResultCount(input, expectResultCount);
+        }
+
+        [Test]
+        [Category("Inspections")]
+        public void ObjectVariableNotSet_InsideForEachSetObject_ReturnsNoResult()
+        {
+
+            var expectResultCount = 0;
+            var input =
+                @"
+Private Sub Test()
+    Dim bar As Variant
+    Dim baz As Object
+    For Each foo In bar
+        Set baz = foo
+    Next
+End Sub";
+            AssertInputCodeYieldsExpectedInspectionResultCount(input, expectResultCount);
+        }
+
         [Test]
         [Category("Inspections")]
         public void ObjectVariableNotSet_RSet_ReturnsNoResult()