@@ -1,5 +1,8 @@ fakeweb (development) +* fix the #http_version of :file and :string responses, which was returning the + request URI instead of something sensible like "1.0" [Chris Kampmeier] + * add method aliases in the Net::HTTP patch to eliminate warnings when running with -w [Joshua Clingenpeel] CHANGELOG @@ -15,7 +15,7 @@ module FakeWeb response = baked_response else code, msg = meta_information - response = Net::HTTPResponse.send(:response_class, code.to_s).new(uri, code.to_s, msg) + response = Net::HTTPResponse.send(:response_class, code.to_s).new("1.0", code.to_s, msg) response.instance_variable_set(:@body, content) end lib/fake_web/responder.rb @@ -504,4 +504,16 @@ class TestFakeWeb < Test::Unit::TestCase Net::HTTP.get(URI.parse("http://example.com")) end end + + def test_http_version_from_string_response + FakeWeb.register_uri(:get, "http://example.com", :string => "example") + response = Net::HTTP.start("example.com") { |http| http.get("/") } + assert_equal "1.0", response.http_version + end + + def test_http_version_from_file_response + FakeWeb.register_uri(:get, "http://example.com", :file => File.dirname(__FILE__) + '/fixtures/test_example.txt') + response = Net::HTTP.start("example.com") { |http| http.get("/") } + assert_equal "1.0", response.http_version + end end test/test_fake_web.rb 3f201e035d5c748c2a468081fc40f3ea7a372bef Chris Kampmeier chris@kampers.net http://github.com/rubyist/fakeweb/commit/92a6dfa47abd0656e5c9a8c18baccfe89f864746 92a6dfa47abd0656e5c9a8c18baccfe89f864746 2009-05-26T02:31:20-07:00 2009-05-26T02:20:44-07:00 Fix that :string and :file responses were returning the request URI as the HTTP version, instead of something sensible like "1.0" a488d035edb6126d463012f3888198e66a1e7231 Chris Kampmeier chris@kampers.net