@@ -24,7 +24,7 @@ describe "BigDecimal#>" do @values = [@mixed, @pos_int, @neg_int, @pos_frac, @neg_frac, -2**32, -2**31, -2**30, -2**16, -2**8, -100, -10, -1, - @zero , 1, 2, 10, 2**8, 2**16, 2**32, @int_mock, @zero_pos, @zero_neg] + @zero , 1, 2, 10, 10.5, 2**8, 2**16, 2**32, @int_mock, @zero_pos, @zero_neg] @infinity = BigDecimal("Infinity") @infinity_neg = BigDecimal("-Infinity") @@ -64,28 +64,24 @@ describe "BigDecimal#>" do (@infinity_neg > @infinity).should == false end - it "properly handles NaN values" do - @values += [@infinity, @infinity_neg, @nan] - @values << nil - @values << Object.new - @values.each { |val| - (@nan > val).should == nil - } - - lambda { 10 > @nan }.should raise_error(ArgumentError) - (10.5 > @nan).should == false - - (@infinity > @nan).should == nil - (@infinity_neg > @nan).should == nil - (@zero > @nan).should == nil + ruby_bug "redmine:2349", "1.8.7" do + it "properly handles NaN values" do + @values += [@infinity, @infinity_neg, @nan] + @values.each { |val| + (@nan > val).should == false + (val > @nan).should == false + } + end end - it "returns nil if the argument is nil" do - (@zero > nil).should == nil - (@infinity > nil).should == nil - (@infinity_neg > nil).should == nil - (@mixed > nil).should == nil - (@pos_int > nil).should == nil - (@neg_frac > nil).should == nil + ruby_bug "redmine:2349", "1.8.7" do + it "raises an ArgumentError if the argument can't be coerced into a BigDecimal" do + lambda {@zero > nil }.should raise_error(ArgumentError) + lambda {@infinity > nil }.should raise_error(ArgumentError) + lambda {@infinity_neg > nil }.should raise_error(ArgumentError) + lambda {@mixed > nil }.should raise_error(ArgumentError) + lambda {@pos_int > nil }.should raise_error(ArgumentError) + lambda {@neg_frac > nil }.should raise_error(ArgumentError) + end end end library/bigdecimal/gt_spec.rb @@ -24,7 +24,7 @@ describe "BigDecimal#>=" do @values = [@mixed, @pos_int, @neg_int, @pos_frac, @neg_frac, -2**32, -2**31, -2**30, -2**16, -2**8, -100, -10, -1, - @zero , 1, 2, 10, 2**8, 2**16, 2**32, @int_mock, @zero_pos, @zero_neg] + @zero , 1, 2, 10, 10.5, 2**8, 2**16, 2**32, @int_mock, @zero_pos, @zero_neg] @infinity = BigDecimal("Infinity") @infinity_neg = BigDecimal("-Infinity") @@ -68,28 +68,24 @@ describe "BigDecimal#>=" do (@infinity_neg >= @infinity).should == false end - it "properly handles NaN values" do - @values += [@infinity, @infinity_neg, @nan] - @values << nil - @values << Object.new - @values.each { |val| - (@nan >= val).should == nil - } - - lambda { 10 >= @nan }.should raise_error(ArgumentError) - (10.5 >= @nan).should == false - - (@infinity >= @nan).should == nil - (@infinity_neg >= @nan).should == nil - (@zero >= @nan).should == nil + ruby_bug "redmine:2349", "1.8.7" do + it "properly handles NaN values" do + @values += [@infinity, @infinity_neg, @nan] + @values.each { |val| + (@nan >= val).should == false + (val >= @nan).should == false + } + end end - it "returns nil if the argument is nil" do - (@zero >= nil).should == nil - (@infinity >= nil).should == nil - (@infinity_neg >= nil).should == nil - (@mixed >= nil).should == nil - (@pos_int >= nil).should == nil - (@neg_frac >= nil).should == nil + ruby_bug "redmine:2349", "1.8.7" do + it "returns nil if the argument is nil" do + lambda {@zero >= nil }.should raise_error(ArgumentError) + lambda {@infinity >= nil }.should raise_error(ArgumentError) + lambda {@infinity_neg >= nil }.should raise_error(ArgumentError) + lambda {@mixed >= nil }.should raise_error(ArgumentError) + lambda {@pos_int >= nil }.should raise_error(ArgumentError) + lambda {@neg_frac >= nil }.should raise_error(ArgumentError) + end end end library/bigdecimal/gte_spec.rb @@ -24,7 +24,7 @@ describe "BigDecimal#<" do @values = [@mixed, @pos_int, @neg_int, @pos_frac, @neg_frac, -2**32, -2**31, -2**30, -2**16, -2**8, -100, -10, -1, - @zero , 1, 2, 10, 2**8, 2**16, 2**32, @int_mock, @zero_pos, @zero_neg] + @zero , 1, 2, 10, 10.5, 2**8, 2**16, 2**32, @int_mock, @zero_pos, @zero_neg] @infinity = BigDecimal("Infinity") @infinity_neg = BigDecimal("-Infinity") @@ -62,28 +62,24 @@ describe "BigDecimal#<" do (@infinity_neg < @infinity).should == true end - it "properly handles NaN values" do - @values += [@infinity, @infinity_neg, @nan] - @values << nil - @values << Object.new - @values.each { |val| - (@nan < val).should == nil - } - - lambda { 10 < @nan }.should raise_error(ArgumentError) - (10.5 < @nan).should == false - - (@infinity < @nan).should == nil - (@infinity_neg < @nan).should == nil - (@zero < @nan).should == nil + ruby_bug "redmine:2349", "1.8.7" do + it "properly handles NaN values" do + @values += [@infinity, @infinity_neg, @nan] + @values.each { |val| + (@nan < val).should == false + (val < @nan).should == false + } + end end - it "returns nil if the argument is nil" do - (@zero < nil).should == nil - (@infinity < nil).should == nil - (@infinity_neg < nil).should == nil - (@mixed < nil).should == nil - (@pos_int < nil).should == nil - (@neg_frac < nil).should == nil + ruby_bug "redmine:2349", "1.8.7" do + it "raises an ArgumentError if the argument can't be coerced into a BigDecimal" do + lambda {@zero < nil }.should raise_error(ArgumentError) + lambda {@infinity < nil }.should raise_error(ArgumentError) + lambda {@infinity_neg < nil }.should raise_error(ArgumentError) + lambda {@mixed < nil }.should raise_error(ArgumentError) + lambda {@pos_int < nil }.should raise_error(ArgumentError) + lambda {@neg_frac < nil }.should raise_error(ArgumentError) + end end end library/bigdecimal/lt_spec.rb @@ -24,7 +24,7 @@ describe "BigDecimal#<=" do @values = [@mixed, @pos_int, @neg_int, @pos_frac, @neg_frac, -2**32, -2**31, -2**30, -2**16, -2**8, -100, -10, -1, - @zero , 1, 2, 10, 2**8, 2**16, 2**32, @int_mock, @zero_pos, @zero_neg] + @zero , 1, 2, 10, 10.5, 2**8, 2**16, 2**32, @int_mock, @zero_pos, @zero_neg] @infinity = BigDecimal("Infinity") @infinity_neg = BigDecimal("-Infinity") @@ -68,28 +68,24 @@ describe "BigDecimal#<=" do (@infinity_neg <= @infinity).should == true end - it "properly handles NaN values" do - @values += [@infinity, @infinity_neg, @nan] - @values << nil - @values << Object.new - @values.each { |val| - (@nan <= val).should == nil - } - - lambda { 10 <= @nan }.should raise_error(ArgumentError) - (10.5 <= @nan).should == false - - (@infinity <= @nan).should == nil - (@infinity_neg <= @nan).should == nil - (@zero <= @nan).should == nil + ruby_bug "redmine:2349", "1.8.7" do + it "properly handles NaN values" do + @values += [@infinity, @infinity_neg, @nan] + @values.each { |val| + (@nan <= val).should == false + (val <= @nan).should == false + } + end end - it "returns nil if the argument is nil" do - (@zero <= nil).should == nil - (@infinity <= nil).should == nil - (@infinity_neg <= nil).should == nil - (@mixed <= nil).should == nil - (@pos_int <= nil).should == nil - (@neg_frac <= nil).should == nil + ruby_bug "redmine:2349", "1.8.7" do + it "raises an ArgumentError if the argument can't be coerced into a BigDecimal" do + lambda {@zero <= nil }.should raise_error(ArgumentError) + lambda {@infinity <= nil }.should raise_error(ArgumentError) + lambda {@infinity_neg <= nil }.should raise_error(ArgumentError) + lambda {@mixed <= nil }.should raise_error(ArgumentError) + lambda {@pos_int <= nil }.should raise_error(ArgumentError) + lambda {@neg_frac <= nil }.should raise_error(ArgumentError) + end end end library/bigdecimal/lte_spec.rb @@ -12,7 +12,7 @@ describe :bigdecimal_eql, :shared => true do @infinity_minus = BigDecimal("-Infinity") end - it "test for equality" do + it "tests for equality" do @bg6543_21.send(@method, @bg6543_21).should == true @a.send(@method, @a).should == true @a.send(@method, @b).should == false @@ -20,14 +20,16 @@ describe :bigdecimal_eql, :shared => true do @bigint.send(@method, 1000).should == true end - it "NaN is never equal to any number" do - @nan.send(@method, @nan).should_not == true - @a.send(@method, @nan).should_not == true - @nan.send(@method, @a).should_not == true - @nan.send(@method, @infinity).should_not == true - @nan.send(@method, @infinity_minus).should_not == true - @infinity.send(@method, @nan).should_not == true - @infinity_minus.send(@method, @nan).should_not == true + ruby_bug "redmine:2349", "1.8.7" do + it "NaN is never equal to any number" do + @nan.send(@method, @nan).should == false + @a.send(@method, @nan).should == false + @nan.send(@method, @a).should == false + @nan.send(@method, @infinity).should == false + @nan.send(@method, @infinity_minus).should == false + @infinity.send(@method, @nan).should == false + @infinity_minus.send(@method, @nan).should == false + end end it "returns true for infinity values with the same sign" do @@ -40,16 +42,24 @@ describe :bigdecimal_eql, :shared => true do BigDecimal("-Infinity").send(@method, @infinity_minus).should == true end - it "does not return true for infinity values with different signs" do - @infinity.send(@method, @infinity_minus).should_not == true - @infinity_minus.send(@method, @infinity).should_not == true + it "returns false for infinity values with different signs" do + @infinity.send(@method, @infinity_minus).should == false + @infinity_minus.send(@method, @infinity).should == false end - it "does not return true when ininite value compared to finite one" do - @infinity.send(@method, @a).should_not == true - @infinity_minus.send(@method, @a).should_not == true + it "returns false when infinite value compared to finite one" do + @infinity.send(@method, @a).should == false + @infinity_minus.send(@method, @a).should == false - @a.send(@method, @infinity).should_not == true - @a.send(@method, @infinity_minus).should_not == true + @a.send(@method, @infinity).should == false + @a.send(@method, @infinity_minus).should == false + end + + ruby_bug "redmine:2349", "1.8.7" do + it "returns false when compared objects that can not be coerced into BigDecimal" do + @infinity.send(@method, nil).should == false + @bigint.send(@method, nil).should == false + @nan.send(@method, nil).should == false + end end end library/bigdecimal/shared/eql.rb 91dbc0ddd01e609048b64c94e6b2d9d7cc244dad Marc-Andre Lafortune github@marc-andre.ca http://github.com/rubyspec/rubyspec/commit/d2f7130b65ec94ba110a6b405d348e1c4138f956 d2f7130b65ec94ba110a6b405d348e1c4138f956 2009-11-08T22:37:45-08:00 2009-11-08T22:37:08-08:00 lib/bigdecimal: Fix comparison specs (redmine:2349) b5feec3fb9221073c7f6558d66d16097e4a86840 Marc-Andre Lafortune github@marc-andre.ca