@@ -33,7 +33,7 @@ spec = Gem::Specification.new do |spec| spec.rdoc_options << '--title' << 'Ruport Documentation' << '--main' << 'README' << '-q' spec.add_dependency('fastercsv', '>= 1.1.0') - spec.add_dependency('pdf-writer', '= 1.1.7') + spec.add_dependency('pdf-writer', '= 1.1.8') spec.author = "Gregory Brown" spec.email = " gregory.t.brown@gmail.com" spec.rubyforge_project = "ruport" Rakefile @@ -526,7 +526,8 @@ module Ruport::Data # table.column_names.include?("a") #=> false # def rename_column(old_name,new_name) - self.column_names[column_names.index(old_name)] = new_name + index = column_names.index(old_name) or return + self.column_names[index] = new_name each { |r| r.rename_attribute(old_name,new_name,false)} end lib/ruport/data/table.rb @@ -662,6 +662,13 @@ class TestTableColumnOperations < Test::Unit::TestCase assert_equal Table(%w[a foo c], :data => [[1,6,6],[4,9,9]]), a end + def test_ensure_renaming_a_missing_column_fails_silently + a = Table(%w[a b c]) + assert_nothing_raised do + a.rename_column("d", "z") + end + end + end class TestTableFromCSV < Test::Unit::TestCase test/table_test.rb bc1b6e841754aa9c4754e3b8ddaa9decaf66d930 sandal sandal@bb2e8eb0-7117-0410-aac4-c024b40ed5f7 http://github.com/ruport/ruport/commit/853db0b15757f7414c0706a9f2eb0580532a5e5a 853db0b15757f7414c0706a9f2eb0580532a5e5a 2008-03-31T14:44:01-07:00 2008-03-31T14:44:01-07:00 Making Table#rename_column fail silently git-svn-id: http://stonecode.svnrepository.com/svn/ruport/ruport/trunk@1293 bb2e8eb0-7117-0410-aac4-c024b40ed5f7 3cfbce8d8eec0ce528935b7fc070c3a211f69c54 sandal sandal@bb2e8eb0-7117-0410-aac4-c024b40ed5f7