From 04233a1675272d4a21440943f1441b586cdf0afd Mon Sep 17 00:00:00 2001 From: nham Date: Mon, 11 Aug 2014 15:00:07 -0400 Subject: [PATCH] Change std::fmt::{Float,LowerExp,UpperExp} to not print '-NaN' for f32::NAN and f64::NAN --- src/libcore/fmt/mod.rs | 7 ++++--- src/test/run-pass/format-nan.rs | 18 ++++++++++++++++++ 2 files changed, 22 insertions(+), 3 deletions(-) create mode 100644 src/test/run-pass/format-nan.rs diff --git a/src/libcore/fmt/mod.rs b/src/libcore/fmt/mod.rs index 48bbc8401fe96..9cb64747c91b4 100644 --- a/src/libcore/fmt/mod.rs +++ b/src/libcore/fmt/mod.rs @@ -19,6 +19,7 @@ use collections::Collection; use iter::{Iterator, range}; use kinds::Copy; use mem; +use num::Float; use option::{Option, Some, None}; use ops::Deref; use result::{Ok, Err}; @@ -584,7 +585,7 @@ macro_rules! floating(($ty:ident) => { float::ExpNone, false, |bytes| { - fmt.pad_integral(*self >= 0.0, "", bytes) + fmt.pad_integral(self.is_nan() || *self >= 0.0, "", bytes) }) } } @@ -605,7 +606,7 @@ macro_rules! floating(($ty:ident) => { float::ExpDec, false, |bytes| { - fmt.pad_integral(*self >= 0.0, "", bytes) + fmt.pad_integral(self.is_nan() || *self >= 0.0, "", bytes) }) } } @@ -626,7 +627,7 @@ macro_rules! floating(($ty:ident) => { float::ExpDec, true, |bytes| { - fmt.pad_integral(*self >= 0.0, "", bytes) + fmt.pad_integral(self.is_nan() || *self >= 0.0, "", bytes) }) } } diff --git a/src/test/run-pass/format-nan.rs b/src/test/run-pass/format-nan.rs new file mode 100644 index 0000000000000..1024bc21d2b0a --- /dev/null +++ b/src/test/run-pass/format-nan.rs @@ -0,0 +1,18 @@ +// Copyright 2014 The Rust Project Developers. See the COPYRIGHT +// file at the top-level directory of this distribution and at +// http://rust-lang.org/COPYRIGHT. +// +// Licensed under the Apache License, Version 2.0 or the MIT license +// , at your +// option. This file may not be copied, modified, or distributed +// except according to those terms. + +pub fn main() { + use std::f64; + let x = "NaN".to_string(); + assert_eq!(format!("{}", f64::NAN), x); + assert_eq!(format!("{:e}", f64::NAN), x); + assert_eq!(format!("{:E}", f64::NAN), x); +} +