From 39543e91f51eead5a00242e7eda6a0fced06ceea Mon Sep 17 00:00:00 2001 From: Ariel Ben-Yehuda Date: Mon, 13 Apr 2015 19:27:58 +0300 Subject: [PATCH] Don't try to suggest fields of an enum Fixes #24365 --- src/librustc_typeck/check/mod.rs | 4 ++-- src/test/compile-fail/issue-24365.rs | 29 ++++++++++++++++++++++++++++ 2 files changed, 31 insertions(+), 2 deletions(-) create mode 100644 src/test/compile-fail/issue-24365.rs diff --git a/src/librustc_typeck/check/mod.rs b/src/librustc_typeck/check/mod.rs index 862c454a38833..ed8c82e05e50b 100644 --- a/src/librustc_typeck/check/mod.rs +++ b/src/librustc_typeck/check/mod.rs @@ -2691,8 +2691,8 @@ fn check_expr_with_unifier<'a, 'tcx, F>(fcx: &FnCtxt<'a, 'tcx>, actual) }, expr_t, None); - if let Some(t) = ty::ty_to_def_id(expr_t) { - suggest_field_names(t, field, tcx, vec![]); + if let ty::ty_struct(did, _) = expr_t.sty { + suggest_field_names(did, field, tcx, vec![]); } } diff --git a/src/test/compile-fail/issue-24365.rs b/src/test/compile-fail/issue-24365.rs new file mode 100644 index 0000000000000..a4df42a8c70f2 --- /dev/null +++ b/src/test/compile-fail/issue-24365.rs @@ -0,0 +1,29 @@ +// Copyright 2015 The Rust Project Developers. See the COPYRIGHT +// file at the top-level directory of this distribution and at +// http://rust-lang.org/COPYRIGHT. +// +// Licensed under the Apache License, Version 2.0 or the MIT license +// , at your +// option. This file may not be copied, modified, or distributed +// except according to those terms. + +pub enum Attribute { + Code {attr_name_idx: u16}, +} + +pub enum Foo { + Bar +} + +fn test(a: Foo) { + println!("{}", a.b); //~ ERROR attempted access of field +} + +fn main() { + let x = Attribute::Code { + attr_name_idx: 42, + }; + let z = (&x).attr_name_idx; //~ ERROR attempted access of field + let y = x.attr_name_idx; //~ ERROR attempted access of field +}