From 4ecdec1fb665363ee46af24a9a6edf73a9b602ec Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Esteban=20K=C3=BCber?= Date: Fri, 14 Aug 2020 10:16:34 -0700 Subject: [PATCH] review comment: suggestion message wording --- src/librustc_resolve/late/diagnostics.rs | 3 ++- src/test/ui/issues/issue-5099.stderr | 4 ++-- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/src/librustc_resolve/late/diagnostics.rs b/src/librustc_resolve/late/diagnostics.rs index 67a9d9b4ec1b4..3df6a230b0f09 100644 --- a/src/librustc_resolve/late/diagnostics.rs +++ b/src/librustc_resolve/late/diagnostics.rs @@ -202,7 +202,8 @@ impl<'a> LateResolutionVisitor<'a, '_, '_> { }; err.span_suggestion_verbose( span, - "you are also missing a `self` receiver argument", + "if you meant to use `self`, you are also missing a `self` receiver \ + argument", sugg.to_string(), Applicability::MaybeIncorrect, ); diff --git a/src/test/ui/issues/issue-5099.stderr b/src/test/ui/issues/issue-5099.stderr index 56b02c45a08d7..b52fd28b2b575 100644 --- a/src/test/ui/issues/issue-5099.stderr +++ b/src/test/ui/issues/issue-5099.stderr @@ -8,7 +8,7 @@ help: you might have meant to use `self` here instead | LL | self.a | ^^^^ -help: you are also missing a `self` receiver argument +help: if you meant to use `self`, you are also missing a `self` receiver argument | LL | fn a(&self) -> A { | ^^^^^ @@ -23,7 +23,7 @@ help: you might have meant to use `self` here instead | LL | self.b(x); | ^^^^ -help: you are also missing a `self` receiver argument +help: if you meant to use `self`, you are also missing a `self` receiver argument | LL | fn b(&self, x: i32) { | ^^^^^^