From 7c4ca59f4b10d20f0f3e902f847641311abb093c Mon Sep 17 00:00:00 2001
From: Josh Stone <jistone@redhat.com>
Date: Fri, 17 Apr 2020 11:36:56 -0700
Subject: [PATCH] Lint must_use on mem::replace

This adds a hint on `mem::replace`, "if you don't need the old value,
you can just assign the new value directly". This is in similar spirit
to the `must_use` on `ManuallyDrop::take`.
---
 src/libcore/mem/mod.rs | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/libcore/mem/mod.rs b/src/libcore/mem/mod.rs
index 07f7d28bb7546..3fa2b7a2d042c 100644
--- a/src/libcore/mem/mod.rs
+++ b/src/libcore/mem/mod.rs
@@ -808,6 +808,7 @@ pub fn take<T: Default>(dest: &mut T) -> T {
 /// [`Clone`]: ../../std/clone/trait.Clone.html
 #[inline]
 #[stable(feature = "rust1", since = "1.0.0")]
+#[must_use = "if you don't need the old value, you can just assign the new value directly"]
 pub fn replace<T>(dest: &mut T, mut src: T) -> T {
     swap(dest, &mut src);
     src