diff --git a/src/liballoc/alloc/tests.rs b/src/liballoc/alloc/tests.rs index 956298d7836b8..c902971638b8e 100644 --- a/src/liballoc/alloc/tests.rs +++ b/src/liballoc/alloc/tests.rs @@ -22,7 +22,7 @@ fn allocate_zeroed() { } #[bench] -#[cfg(not(miri))] // Miri does not support benchmarks +#[cfg_attr(miri, ignore)] // Miri does not support benchmarks fn alloc_owned_small(b: &mut Bencher) { b.iter(|| { let _: Box<_> = box 10; diff --git a/src/liballoc/collections/linked_list/tests.rs b/src/liballoc/collections/linked_list/tests.rs index 94b92df129400..1b1d8eab39bfc 100644 --- a/src/liballoc/collections/linked_list/tests.rs +++ b/src/liballoc/collections/linked_list/tests.rs @@ -182,7 +182,7 @@ fn test_insert_prev() { #[test] #[cfg_attr(target_os = "emscripten", ignore)] -#[cfg(not(miri))] // Miri does not support threads +#[cfg_attr(miri, ignore)] // Miri does not support threads fn test_send() { let n = list_from(&[1, 2, 3]); thread::spawn(move || { diff --git a/src/liballoc/collections/vec_deque/tests.rs b/src/liballoc/collections/vec_deque/tests.rs index 8dc097cc08805..f2ce5b1d15dde 100644 --- a/src/liballoc/collections/vec_deque/tests.rs +++ b/src/liballoc/collections/vec_deque/tests.rs @@ -3,7 +3,7 @@ use super::*; use ::test; #[bench] -#[cfg(not(miri))] // Miri does not support benchmarks +#[cfg_attr(miri, ignore)] // Miri does not support benchmarks fn bench_push_back_100(b: &mut test::Bencher) { let mut deq = VecDeque::with_capacity(101); b.iter(|| { @@ -16,7 +16,7 @@ fn bench_push_back_100(b: &mut test::Bencher) { } #[bench] -#[cfg(not(miri))] // Miri does not support benchmarks +#[cfg_attr(miri, ignore)] // Miri does not support benchmarks fn bench_push_front_100(b: &mut test::Bencher) { let mut deq = VecDeque::with_capacity(101); b.iter(|| { @@ -29,7 +29,7 @@ fn bench_push_front_100(b: &mut test::Bencher) { } #[bench] -#[cfg(not(miri))] // Miri does not support benchmarks +#[cfg_attr(miri, ignore)] // Miri does not support benchmarks fn bench_pop_back_100(b: &mut test::Bencher) { let mut deq = VecDeque::::with_capacity(101); @@ -43,7 +43,7 @@ fn bench_pop_back_100(b: &mut test::Bencher) { } #[bench] -#[cfg(not(miri))] // Miri does not support benchmarks +#[cfg_attr(miri, ignore)] // Miri does not support benchmarks fn bench_pop_front_100(b: &mut test::Bencher) { let mut deq = VecDeque::::with_capacity(101); diff --git a/src/liballoc/sync/tests.rs b/src/liballoc/sync/tests.rs index 9220f5e0333ef..9ddba495b7e78 100644 --- a/src/liballoc/sync/tests.rs +++ b/src/liballoc/sync/tests.rs @@ -29,7 +29,7 @@ impl Drop for Canary { #[test] #[cfg_attr(target_os = "emscripten", ignore)] -#[cfg(not(miri))] // Miri does not support threads +#[cfg_attr(miri, ignore)] // Miri does not support threads fn manually_share_arc() { let v = vec![1, 2, 3, 4, 5, 6, 7, 8, 9, 10]; let arc_v = Arc::new(v); @@ -334,7 +334,7 @@ fn test_ptr_eq() { #[test] #[cfg_attr(target_os = "emscripten", ignore)] -#[cfg(not(miri))] // Miri does not support threads +#[cfg_attr(miri, ignore)] // Miri does not support threads fn test_weak_count_locked() { let mut a = Arc::new(atomic::AtomicBool::new(false)); let a2 = a.clone(); diff --git a/src/liballoc/tests/slice.rs b/src/liballoc/tests/slice.rs index d9707b9574078..ec45de7c79e28 100644 --- a/src/liballoc/tests/slice.rs +++ b/src/liballoc/tests/slice.rs @@ -388,7 +388,7 @@ fn test_reverse() { } #[test] -#[cfg(not(miri))] // Miri is too slow +#[cfg_attr(miri, ignore)] // Miri is too slow fn test_sort() { let mut rng = thread_rng(); @@ -1610,7 +1610,7 @@ fn panic_safe() { let moduli = &[5, 20, 50]; #[cfg(miri)] - let lens = (1..13); + let lens = 1..13; #[cfg(miri)] let moduli = &[10]; diff --git a/src/liballoc/tests/str.rs b/src/liballoc/tests/str.rs index cb73c7c179cbf..1b011242d0137 100644 --- a/src/liballoc/tests/str.rs +++ b/src/liballoc/tests/str.rs @@ -166,7 +166,7 @@ fn test_join_for_different_lengths_with_long_separator() { } #[test] -#[cfg(not(miri))] // Miri is too slow +#[cfg_attr(miri, ignore)] // Miri is too slow fn test_unsafe_slice() { assert_eq!("ab", unsafe {"abc".get_unchecked(0..2)}); assert_eq!("bc", unsafe {"abc".get_unchecked(1..3)}); @@ -483,8 +483,8 @@ mod slice_index { } #[test] - #[cfg(not(target_os = "emscripten"))] // hits an OOM - #[cfg(not(miri))] // Miri is too slow + #[cfg_attr(target_os = "emscripten", ignore)] // hits an OOM + #[cfg_attr(miri, ignore)] // Miri is too slow fn simple_big() { fn a_million_letter_x() -> String { let mut i = 0; @@ -1069,7 +1069,7 @@ fn test_rev_iterator() { } #[test] -#[cfg(not(miri))] // Miri is too slow +#[cfg_attr(miri, ignore)] // Miri is too slow fn test_chars_decoding() { let mut bytes = [0; 4]; for c in (0..0x110000).filter_map(std::char::from_u32) { @@ -1081,7 +1081,7 @@ fn test_chars_decoding() { } #[test] -#[cfg(not(miri))] // Miri is too slow +#[cfg_attr(miri, ignore)] // Miri is too slow fn test_chars_rev_decoding() { let mut bytes = [0; 4]; for c in (0..0x110000).filter_map(std::char::from_u32) { @@ -1380,7 +1380,6 @@ fn test_bool_from_str() { assert_eq!("not even a boolean".parse::().ok(), None); } -#[cfg(not(miri))] // Miri is too slow fn check_contains_all_substrings(s: &str) { assert!(s.contains("")); for i in 0..s.len() { @@ -1391,7 +1390,7 @@ fn check_contains_all_substrings(s: &str) { } #[test] -#[cfg(not(miri))] // Miri is too slow +#[cfg_attr(miri, ignore)] // Miri is too slow fn strslice_issue_16589() { assert!("bananas".contains("nana")); @@ -1408,7 +1407,7 @@ fn strslice_issue_16878() { #[test] -#[cfg(not(miri))] // Miri is too slow +#[cfg_attr(miri, ignore)] // Miri is too slow fn test_strslice_contains() { let x = "There are moments, Jeeves, when one asks oneself, 'Do trousers matter?'"; check_contains_all_substrings(x); diff --git a/src/liballoc/tests/string.rs b/src/liballoc/tests/string.rs index 55edf56345b59..fe7b4ff24b8c9 100644 --- a/src/liballoc/tests/string.rs +++ b/src/liballoc/tests/string.rs @@ -523,7 +523,7 @@ fn test_reserve_exact() { } #[test] -#[cfg(not(miri))] // Miri does not support signalling OOM +#[cfg_attr(miri, ignore)] // Miri does not support signalling OOM fn test_try_reserve() { // These are the interesting cases: @@ -601,7 +601,7 @@ fn test_try_reserve() { } #[test] -#[cfg(not(miri))] // Miri does not support signalling OOM +#[cfg_attr(miri, ignore)] // Miri does not support signalling OOM fn test_try_reserve_exact() { // This is exactly the same as test_try_reserve with the method changed. diff --git a/src/liballoc/tests/vec.rs b/src/liballoc/tests/vec.rs index 9ee254f99acdf..5e788d61f84fd 100644 --- a/src/liballoc/tests/vec.rs +++ b/src/liballoc/tests/vec.rs @@ -1080,7 +1080,7 @@ fn test_reserve_exact() { } #[test] -#[cfg(not(miri))] // Miri does not support signalling OOM +#[cfg_attr(miri, ignore)] // Miri does not support signalling OOM fn test_try_reserve() { // These are the interesting cases: @@ -1183,7 +1183,7 @@ fn test_try_reserve() { } #[test] -#[cfg(not(miri))] // Miri does not support signalling OOM +#[cfg_attr(miri, ignore)] // Miri does not support signalling OOM fn test_try_reserve_exact() { // This is exactly the same as test_try_reserve with the method changed. diff --git a/src/liballoc/tests/vec_deque.rs b/src/liballoc/tests/vec_deque.rs index 5a0162a536175..ebcc832017172 100644 --- a/src/liballoc/tests/vec_deque.rs +++ b/src/liballoc/tests/vec_deque.rs @@ -1100,7 +1100,7 @@ fn test_reserve_exact_2() { } #[test] -#[cfg(not(miri))] // Miri does not support signalling OOM +#[cfg_attr(miri, ignore)] // Miri does not support signalling OOM fn test_try_reserve() { // These are the interesting cases: // * exactly isize::MAX should never trigger a CapacityOverflow (can be OOM) @@ -1214,7 +1214,7 @@ fn test_try_reserve() { } #[test] -#[cfg(not(miri))] // Miri does not support signalling OOM +#[cfg_attr(miri, ignore)] // Miri does not support signalling OOM fn test_try_reserve_exact() { // This is exactly the same as test_try_reserve with the method changed. // See that test for comments.