From e7e1fd20deb95f74c4a33c76921907e039dff894 Mon Sep 17 00:00:00 2001 From: Ariel Ben-Yehuda Date: Tue, 19 May 2015 22:54:44 +0300 Subject: [PATCH] Fix rebase conflicts --- src/liballoc/arc.rs | 8 ++++++-- src/librustc_lint/builtin.rs | 2 +- src/librustc_trans/trans/expr.rs | 5 +++-- 3 files changed, 10 insertions(+), 5 deletions(-) diff --git a/src/liballoc/arc.rs b/src/liballoc/arc.rs index ff942444a6176..97e85b114b060 100644 --- a/src/liballoc/arc.rs +++ b/src/liballoc/arc.rs @@ -394,7 +394,9 @@ impl Drop for Arc { // it's run more than once) let ptr = *self._ptr; // if ptr.is_null() { return } - if ptr as usize == 0 || ptr as usize == mem::POST_DROP_USIZE { return } + if ptr as *mut u8 as usize == 0 || ptr as *mut u8 as usize == mem::POST_DROP_USIZE { + return + } // Because `fetch_sub` is already atomic, we do not need to synchronize // with other threads unless we are going to delete the object. This @@ -524,7 +526,9 @@ impl Drop for Weak { let ptr = *self._ptr; // see comments above for why this check is here - if ptr as usize == 0 || ptr as usize == mem::POST_DROP_USIZE { return } + if ptr as *mut u8 as usize == 0 || ptr as *mut u8 as usize == mem::POST_DROP_USIZE { + return + } // If we find out that we were the last weak pointer, then its time to // deallocate the data entirely. See the discussion in Arc::drop() about diff --git a/src/librustc_lint/builtin.rs b/src/librustc_lint/builtin.rs index 8d555240e707b..3716ee395bfd4 100644 --- a/src/librustc_lint/builtin.rs +++ b/src/librustc_lint/builtin.rs @@ -206,7 +206,7 @@ impl LintPass for TypeLimits { let (min, max) = int_ty_range(int_type); let negative = self.negated_expr_id == e.id; - if (negative && v > (min.abs() as u64)) || + if (negative && v > min.wrapping_neg() as u64) || (!negative && v > (max.abs() as u64)) { cx.span_lint(OVERFLOWING_LITERALS, e.span, &*format!("literal out of range for {:?}", t)); diff --git a/src/librustc_trans/trans/expr.rs b/src/librustc_trans/trans/expr.rs index 90741d1d58fbc..33eb3814087f5 100644 --- a/src/librustc_trans/trans/expr.rs +++ b/src/librustc_trans/trans/expr.rs @@ -2048,8 +2048,9 @@ fn trans_imm_cast<'blk, 'tcx>(bcx: Block<'blk, 'tcx>, } else { llsrc }; } - let _icx = push_ctxt("trans_cast"); let mut bcx = bcx; let ccx = - bcx.ccx(); + let _icx = push_ctxt("trans_cast"); + let mut bcx = bcx; + let ccx = bcx.ccx(); let t_in = expr_ty_adjusted(bcx, expr); let t_out = node_id_type(bcx, id);